Intent to Implement and Ship: KeyboardEventInit keyCode, charCode support

76 views
Skip to first unread message

Dave Tapuska

unread,
Nov 28, 2017, 2:34:28 PM11/28/17
to blink-dev
dtap...@chromium.org https://w3c.github.io/uievents/#legacy-dictionary-KeyboardEventInit Add support for initializing keyCode, charCode via KeyboardEventInit. Interop with other vendors (Firefox and Safari already support this today). Currently these fields cannot be initialized via the object constructor and there is no reason why they cannot be. Firefox: Shipped Edge: No public signals Safari: Shipped Web developers: No signals None None
Yes crbug.com/679439 https://www.chromestatus.com/features/5637291280171008 Yes

Chris Harrelson

unread,
Nov 30, 2017, 12:23:51 AM11/30/17
to Dave Tapuska, blink-dev
LGTM1

On Tue, Nov 28, 2017 at 11:34 AM, Dave Tapuska <dtap...@chromium.org> wrote:
dtap...@chromium.org https://w3c.github.io/uievents/#legacy-dictionary-KeyboardEventInit Add support for initializing keyCode, charCode via KeyboardEventInit. Interop with other vendors (Firefox and Safari already support this today). Currently these fields cannot be initialized via the object constructor and there is no reason why they cannot be. Firefox: Shipped Edge: No public signals Safari: Shipped Web developers: No signals None None
Yes crbug.com/679439 https://www.chromestatus.com/features/5637291280171008 Yes

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHXv1wmpmjoPON9tEKC7FYeCcHm3a9Z%3DidST1U3hqeZ21xtsJQ%40mail.gmail.com.

Daniel Bratell

unread,
Nov 30, 2017, 10:39:53 AM11/30/17
to Dave Tapuska, Chris Harrelson, blink-dev
LGTM2

(implementation note: Whenever a script is given more power to emulate events that are also user initiated there is a risk that bugs allow scripts to trick the browser. Something to test and verify doesn't happen)

/Daniel

On Thu, 30 Nov 2017 06:23:26 +0100, Chris Harrelson <chri...@chromium.org> wrote:

LGTM1

On Tue, Nov 28, 2017 at 11:34 AM, Dave Tapuska <dtap...@chromium.org> wrote:
dtap...@chromium.org https://w3c.github.io/uievents/#legacy-dictionary-KeyboardEventInit Add support for initializing keyCode, charCode via KeyboardEventInit. Interop with other vendors (Firefox and Safari already support this today). Currently these fields cannot be initialized via the object constructor and there is no reason why they cannot be. Firefox: Shipped Edge: No public signals Safari: Shipped Web developers: No signals None None
Yes crbug.com/679439 https://www.chromestatus.com/features/5637291280171008 Yes
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_iUPyyPkMTWrqsgwHE_8OLD9bLiEeNjZBMEqeFV_uf8A%40mail.gmail.com.



--
/* Opera Software, Linköping, Sweden: CET (UTC+1) */

Rick Byers

unread,
Dec 4, 2017, 5:27:05 AM12/4/17
to Daniel Bratell, Dave Tapuska, Chris Harrelson, blink-dev
The section for WPT is missing (is this the chromestatus.com template that needs updating?).

Unlike most keyboard events tests, this is trivially automatable, right?  Is there a WPT already, and if not can you add a quick one please?

On Nov 30, 2017 10:39 AM, "Daniel Bratell" <bra...@opera.com> wrote:
LGTM2

(implementation note: Whenever a script is given more power to emulate events that are also user initiated there is a risk that bugs allow scripts to trick the browser. Something to test and verify doesn't happen)

/Daniel

On Thu, 30 Nov 2017 06:23:26 +0100, Chris Harrelson <chri...@chromium.org> wrote:

LGTM1

On Tue, Nov 28, 2017 at 11:34 AM, Dave Tapuska <dtap...@chromium.org> wrote:
dtap...@chromium.org https://w3c.github.io/uievents/#legacy-dictionary-KeyboardEventInit Add support for initializing keyCode, charCode via KeyboardEventInit. Interop with other vendors (Firefox and Safari already support this today). Currently these fields cannot be initialized via the object constructor and there is no reason why they cannot be. Firefox: Shipped Edge: No public signals Safari: Shipped Web developers: No signals None None
Yes crbug.com/679439 https://www.chromestatus.com/features/5637291280171008 Yes
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.



--
/* Opera Software, Linköping, Sweden: CET (UTC+1) */

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/op.zaihf6wurbppqq%40cicero2.linkoping.osa.

Dave Tapuska

unread,
Dec 4, 2017, 11:36:14 AM12/4/17
to Rick Byers, Daniel Bratell, Chris Harrelson, blink-dev

Rick Byers

unread,
Dec 5, 2017, 10:48:46 AM12/5/17
to Dave Tapuska, Daniel Bratell, Chris Harrelson, blink-dev
Perfect, thanks!  LGTM3
Reply all
Reply to author
Forward
0 new messages