Request for comments: Invisible document marker "InCustomSpellcheckDictionary"

[Rouslan Solomakhin]

This is a request for comments, not an intent to implement yet.

Email:

rou...@chromium.org

Summary:

Add InCustomSpellcheckDictionary document marker type and some associated infrastructure. This marker type has no visual representation.

Motivation:

Server-side spellcheck in Chrome collects user feedback on misspellings to improve spellcheck suggestions. Chrome uses DocumentMarker::hash identifiers to keep track of misspellings in the documents. One of the feedback types is "This misspelled word is in user's custom spellcheck dictionary." Since words in custom dictionary do not have red squiggly underlines, Chrome cannot use DocumentMarker::hash identifiers to keep track of misspellings that are in the custom dictionary. This constraint forces Chrome to either over-send or under-send the feedback for the same word. This behavior reduces the quality of spellcheck suggestions.

Spec:

1. Add an InCustomSpellcheckDictionary value to WebCore::DocumentMarker::MarkerType enumerator.
   
2. Add an InCustomSpellcheckDictionary value to WebKit::WebTextCheckingType enum.
3. Clear InCustomSpellcheckDictionary marker when also clearing Spelling or Grammar markers.
4. Add WebKit::WebView::customSpellcheckDictionaryMarkers() method that is similar to the existing WebKit::WebView::spellingMarkers().

Compatibility / feature dashboard:

This change is for Chrome-Blink API. This change would not be visible by web developers. There will be no row on the feature dashboard for this feature.

Platforms:

All.

Tracking bug:

If we decide to go through with this, then I will create a tracking bug.

Requesting to ship?

No.

[Rouslan Solomakhin]

Great! Thank you. I did not have much time to implement this, but it's still on my plate. I'll be getting back to it eventually.

On Tue, Jun 25, 2013 at 2:56 PM, Eric Seidel <ese...@chromium.org> wrote:

I guess there aren't a lot of comments.

Intent-to-* threads (which form you're following) are all about
web-facing features for Blink.  If Chome needs slightly different
Blink APIs exposed for spell-check, go for it. :)

[Eric Seidel]

I guess there aren't a lot of comments.

Intent-to-* threads (which form you're following) are all about
web-facing features for Blink. If Chome needs slightly different
Blink APIs exposed for spell-check, go for it. :)

On Thu, May 30, 2013 at 1:47 PM, Rouslan Solomakhin
<rou...@chromium.org> wrote: