Intent to Implement: Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose

24 views
Skip to first unread message

Luna

unread,
Nov 11, 2016, 4:23:53 PM11/11/16
to blink-dev
https://w3c.github.io/webrtc-pc/#rtcpeerconnectioniceevent

Firefox: Shipped Edge: No public signals Safari: No public signals Web developers: No signals

https://crbug.com/659286

https://www.chromestatus.com/features/5685429277818880

Is this feature supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
Yes

Philip Jägenstedt

unread,
Nov 11, 2016, 4:32:16 PM11/11/16
to Luna, blink-dev
Changing title to "Intent to Ship" to reflect that this won't happen behind a flag. Will also update https://bit.ly/blinkintents.

This is also a change I suggested after looking at window.*RTC* in various browsers, but again I think it's trivial so LGTM1.

Rick Byers

unread,
Nov 12, 2016, 2:33:32 PM11/12/16
to Philip Jägenstedt, Luna, blink-dev
So the compat risk is basically zero because RTCIceCandidateEvent was [NoInterfaceObject] and there's no reason to think anyone is using feature detection of window.RTCPeerConnectionIceEvent, right?

LGTM2

Philip Jägenstedt

unread,
Nov 13, 2016, 4:17:15 PM11/13/16
to Rick Byers, Luna, blink-dev
That's right. When exposing new interfaces we typically don't expect any compat fallout, but I took a quick look at "RTCPeerConnectionIceEvent" in httparchive, only 9 hits. All except one in lists of interfaces, and one was feature detection for WebRTC:

if ("RTCIceCandidate" in window || "RTCPeerConnectionIceEvent" in window) { ... }

Since RTCIceCandidate is already exposed, nothing will change.

TAMURA, Kent

unread,
Nov 14, 2016, 9:10:46 PM11/14/16
to Philip Jägenstedt, Rick Byers, Luna, blink-dev
LGTM3.

--
TAMURA Kent
Software Engineer, Google


Reply all
Reply to author
Forward
0 new messages