Primary eng (and PM) emails
Summary
Keyboard event are currently filtered in fullscreen for Element.webkitRequestFullScreen() with no argument, HTMLVideoElement.webkitEnterFullscreen() and webkitEnterFullScreen(). Changes:
Motivation
This filtering is an odd remnant from a time when it was thought that we would prevent keyboard use in fullscreen to prevent spoofing, and that keyboard access in fullscreen would have a different permissions UI. This model did not end up in the spec and we have the same UI regardless.
Getting rid of this will simplify the fullscreen implementation a little bit, and more importantly remove a difference with the (not yet shipped) unprefixed API that one could accidentally depend on.
Compatibility Risk
Low. This could break pages that depend on keyboard events being filtered and have event handlers that break the page if run, which is likely a minority of the 0.001% (see below) of page loads where the filtering happens.
The removal of Document.webkitFullScreenKeyboardInputAllowed seems like the greater risk, as making it undefined where it was previously true could cause some fullscreen Web app to pick a different code path.
Alternative implementation suggestion for web developers
Don't handle key events in fullscreen. Don't check Document.webkitFullScreenKeyboardInputAllowed.
Usage information from UseCounter
Document.webkitFullScreenKeyboardInputAllowed is accessed in ~0.01% of page loads:
https://www.chromestatus.com/metrics/feature/timeline/popularity/319
The event filtering has an effect on ~0.001% of page loads:
https://www.chromestatus.com/metrics/feature/timeline/popularity/474
Element.ALLOW_KEYBOARD_INPUT does not have a counter as it was only recently that UseCounter started working for constants. Given that this constant only makes sense with Element.webkitRequestFullScreen() and that Element.webkitRequestFullScreen(Element.ALLOW_KEYBOARD_INPUT) will continue to do the same thing, I'm not worried.
Entry on chromestatus.com, crbug.com, or MDN
None.
Requesting approval to remove too?
Yes.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
+1