Intent to Implement and Ship: Overscroll Behavior logical longhands

76 views
Skip to first unread message

Majid Valipour

unread,
Jun 26, 2019, 12:26:50 PM6/26/19
to blink-dev
maj...@chromium.org N/A Specification: https://drafts.csswg.org/css-overscroll-behavior-1/#overscroll-behavior-longhands-logical The change is small enough to skip TAG review. It is an addition of flow relative longhands to an established CSS property with consensus from CSSWG. I can file for a review if owners think it is required. Flow relative longhands for overscroll-behavior: - overscroll-behavior-inline - overscroll-behavior-block
These will map to physical versions `overscroll-behavior-{x,y}` accordingly.
The implementation is in this CL which I will land if this intent is approved. Provide author with the ability to control overscroll-behavior through logical dimensions.
Risk is low. There is consensus in CSSWG to add these and the only other engine that has overscroll-behavior implemented (Mozilla) plans to add them Firefox: Public support (https://github.com/w3c/csswg-drafts/issues/2473#issuecomment-380578511) Edge: No public signals Safari: No public signals Web developers: No signals This property is used most closely with `overflow`. Overflow logical longhands are implemented (behind CSSLogicalOverflow flag) but have not yet shipped. Ideally those will ship as well so developers will be able to specify overflow and overscroll-behavior using logical direction.
All developers tools for CSS may be used. Yes Yes Tests will be added to WPT to cover the new property as part of the CL: https://chromium-review.googlesource.com/c/chromium/src/+/1614026/6/third_party/blink/web_tests/external/wpt/css/css-overscroll-behavior/overscroll-behavior-logical.html https://bugs.chromium.org/p/chromium/issues/detail?id=833953 https://chromestatus.com/feature/5729982653399040

Chris Harrelson

unread,
Jun 27, 2019, 11:26:20 PM6/27/19
to Majid Valipour, blink-dev
LGTM1

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB8RdXszBm4tNhenEy%2BK-5priwZmFLv8dAnyVPcYS7nLda2FvQ%40mail.gmail.com.

Yoav Weiss

unread,
Jun 28, 2019, 6:54:23 AM6/28/19
to Majid Valipour, blink-dev
On Wed, Jun 26, 2019 at 6:26 PM Majid Valipour <maj...@chromium.org> wrote:
maj...@chromium.org N/A Specification: https://drafts.csswg.org/css-overscroll-behavior-1/#overscroll-behavior-longhands-logical The change is small enough to skip TAG review. It is an addition of flow relative longhands to an established CSS property with consensus from CSSWG. I can file for a review if owners think it is required. Flow relative longhands for overscroll-behavior: - overscroll-behavior-inline - overscroll-behavior-block
These will map to physical versions `overscroll-behavior-{x,y}` accordingly.
The implementation is in this CL which I will land if this intent is approved. Provide author with the ability to control overscroll-behavior through logical dimensions.
Risk is low. There is consensus in CSSWG to add these and the only other engine that has overscroll-behavior implemented (Mozilla) plans to add them Firefox: Public support (https://github.com/w3c/csswg-drafts/issues/2473#issuecomment-380578511)

Are you sure? The issue seems rather dormant.
 
Edge: No public signals Safari: No public signals

Have you reached out to them? Open issues?
 
Web developers: No signals This property is used most closely with `overflow`. Overflow logical longhands are implemented (behind CSSLogicalOverflow flag) but have not yet shipped. Ideally those will ship as well so developers will be able to specify overflow and overscroll-behavior using logical direction.

What's the recommended pattern for developers to use when this is shipped in one browser but not others? To use `@supports`? Or having non supporting browsers just ignore those rules is fine?
  
All developers tools for CSS may be used. Yes Yes Tests will be added to WPT to cover the new property as part of the CL: https://chromium-review.googlesource.com/c/chromium/src/+/1614026/6/third_party/blink/web_tests/external/wpt/css/css-overscroll-behavior/overscroll-behavior-logical.html https://bugs.chromium.org/p/chromium/issues/detail?id=833953 https://chromestatus.com/feature/5729982653399040

--

Majid Valipour

unread,
Jun 28, 2019, 4:15:31 PM6/28/19
to Yoav Weiss, Majid Valipour, blink-dev
On Fri, Jun 28, 2019 at 6:54 AM Yoav Weiss <yo...@yoav.ws> wrote:


On Wed, Jun 26, 2019 at 6:26 PM Majid Valipour <maj...@chromium.org> wrote:
maj...@chromium.org N/A Specification: https://drafts.csswg.org/css-overscroll-behavior-1/#overscroll-behavior-longhands-logical The change is small enough to skip TAG review. It is an addition of flow relative longhands to an established CSS property with consensus from CSSWG. I can file for a review if owners think it is required. Flow relative longhands for overscroll-behavior: - overscroll-behavior-inline - overscroll-behavior-block
These will map to physical versions `overscroll-behavior-{x,y}` accordingly.
The implementation is in this CL which I will land if this intent is approved. Provide author with the ability to control overscroll-behavior through logical dimensions.
Risk is low. There is consensus in CSSWG to add these and the only other engine that has overscroll-behavior implemented (Mozilla) plans to add them Firefox: Public support (https://github.com/w3c/csswg-drafts/issues/2473#issuecomment-380578511)

Are you sure? The issue seems rather dormant.

I pinged that thread and confirmed that they confirmed that they still support this. 
 
 
Edge: No public signals Safari: No public signals

Have you reached out to them? Open issues?

I didn't spend too much effort to reach out to them. I figured this is a small non-controversial addition that was asked by the working group.
I have now pinged the appropriate folks on the github issue to see if they can provide a clear signal. I will update the thread if/when I hear back.

 
 
Web developers: No signals This property is used most closely with `overflow`. Overflow logical longhands are implemented (behind CSSLogicalOverflow flag) but have not yet shipped. Ideally those will ship as well so developers will be able to specify overflow and overscroll-behavior using logical direction.

What's the recommended pattern for developers to use when this is shipped in one browser but not others? To use `@supports`? Or having non supporting browsers just ignore those rules is fine?

These will normally be used in stylesheet. The non-supporting browsers will ignore them per css forward-compat behavior. The authors would usually provide fallback by using the existing physical props.
There is a known pattern how to do such fallback as documented by the popular plugin that help implement it: https://github.com/csstools/postcss-logical
I have opened an issue on this plugin to have it support these new logical props once we ship them.

Yoav Weiss

unread,
Jun 30, 2019, 1:55:28 AM6/30/19
to Majid Valipour, blink-dev
LGTM2 - given the clear support signals from Mozilla and Webkit.

Daniel Bratell

unread,
Jul 4, 2019, 4:04:03 PM7/4/19
to Majid Valipour, Yoav Weiss, blink-dev
LGTM3, sorry for the delay for this trivial change.

/Daniel
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEjQFgqDasAYxB2mXX%2B5ywjq86UFp3ekek3wnBA42XWKpg%40mail.gmail.com.



--
/* Opera Software, Linköping, Sweden: CEST (UTC+2) */
Reply all
Reply to author
Forward
0 new messages