Intent to Implement: CSS Round Display

[ana...@gmail.com]

Contact email

hyojin...@lge.com, sangjo...@lge.com

Spec

http://www.w3.org/TR/css-round-display-1/

Summary

Implement device-radius media feature described in CSS Round Display Level 1.

Note that This feature was tried to ship Intel Crosswalk, and considered it to go upstream.

Motivation

LG's smart watch based on blink is being considered to support CSS Round Display.

The features of CSS Round Display are useful for watch app developers.

There might be better alternative method to specify the display shape, but refer to the link below.

https://lists.w3.org/Archives/Public/www-style/2015Jul/0420.html

Compatibility Risk

Firefox: No public signals

Edge: No public signals

Safari: No public signals

Web developers: Positive

Ongoing technical constraints

How to know what the display shape is. It needs to get the display shape from under-layers.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux,

Chrome OS, Android, and Android WebView)?

Yes

OWP launch tracking bug

https://code.google.com/p/chromium/issues/detail?id=535803

Link to entry on the Chrome Platform Status

None

Requesting approval to ship?

Yes

[Chris Harrelson]

Hi,

Implementing this cleanly and performantly might be hard to pull off. Before any code is written, I think there need to be design documents and discussions about how best to implement this. Also, has your team committed code to Blink before?

Thanks,

Chris

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

[Tab Atkins Jr.]

LGTM to implement the (device-radius) media feature.

As I expressed at the last CSSWG f2f, we're not currently interested
in implementing Round Display itself, as we believe it should be
handled through the Houdini APIs. As such, we're only currently
interested in the subset of features that give new behavior that is
required for implementing the spec in JS. This MQ is one of those, so
+1.

~TJ

[Rick Byers]

On Wed, Oct 7, 2015 at 12:22 PM, Chris Harrelson <chri...@chromium.org> wrote:

Hi,

Implementing this cleanly and performantly might be hard to pull off. Before any code is written, I think there need to be design documents and discussions about how best to implement this.

Chris, is your comment here specifically about the device-radius media feature?  Or are you talking about the other parts of the spec.  Naively, the media feature itself seems like it should be pretty straight forward.  And if, as Tab suggests, that's used as a primitive along with the Houdini APIs to build the rest in script, then that seems great from an engine complexity standpoint.

[Chris Harrelson]

On Wed, Oct 7, 2015 at 8:59 PM Rick Byers <rby...@chromium.org> wrote:

On Wed, Oct 7, 2015 at 12:22 PM, Chris Harrelson <chri...@chromium.org> wrote:

Hi,

Implementing this cleanly and performantly might be hard to pull off. Before any code is written, I think there need to be design documents and discussions about how best to implement this.

Chris, is your comment here specifically about the device-radius media feature?  Or are you talking about the other parts of the spec.  Naively, the media feature itself seems like it should be pretty straight forward.  And if, as Tab suggests, that's used as a primitive along with the Houdini APIs to build the rest in script, then that seems great from an engine complexity standpoint.

My concerns were about the other parts of the spec, which introduce polar coordinates and a non-rectangular layout screen. I agree that device-radius media queries are easy to add.

[ana...@gmail.com]

On Fri, Oct 9, 2015 at 1:22 AM Chris Harrelson <chri...@chromium.org> wrote:

On Wed, Oct 7, 2015 at 8:59 PM Rick Byers <rby...@chromium.org> wrote:

On Wed, Oct 7, 2015 at 12:22 PM, Chris Harrelson <chri...@chromium.org> wrote:

Hi,

Implementing this cleanly and performantly might be hard to pull off. Before any code is written, I think there need to be design documents and discussions about how best to implement this.

Chris, is your comment here specifically about the device-radius media feature?  Or are you talking about the other parts of the spec.  Naively, the media feature itself seems like it should be pretty straight forward.  And if, as Tab suggests, that's used as a primitive along with the Houdini APIs to build the rest in script, then that seems great from an engine complexity standpoint.

My concerns were about the other parts of the spec, which introduce polar coordinates and a non-rectangular layout screen. I agree that device-radius media queries are easy to add.

I also agree to add device-radius first, and the other parts of the spec should be developed more. The device-radius is intuitive and simple, and we've already implemented it in blink internally.

 

   

Also, has your team committed code to Blink before?

We're first to commit our codes to Blink. I'd like to briefly get a guide to proceed our contribution.

[Chris Harrelson]

On Mon, Oct 12, 2015 at 5:54 AM <ana...@gmail.com> wrote:

On Fri, Oct 9, 2015 at 1:22 AM Chris Harrelson <chri...@chromium.org> wrote:

On Wed, Oct 7, 2015 at 8:59 PM Rick Byers <rby...@chromium.org> wrote:

On Wed, Oct 7, 2015 at 12:22 PM, Chris Harrelson <chri...@chromium.org> wrote:

Hi,

Implementing this cleanly and performantly might be hard to pull off. Before any code is written, I think there need to be design documents and discussions about how best to implement this.

Chris, is your comment here specifically about the device-radius media feature?  Or are you talking about the other parts of the spec.  Naively, the media feature itself seems like it should be pretty straight forward.  And if, as Tab suggests, that's used as a primitive along with the Houdini APIs to build the rest in script, then that seems great from an engine complexity standpoint.

My concerns were about the other parts of the spec, which introduce polar coordinates and a non-rectangular layout screen. I agree that device-radius media queries are easy to add.

I also agree to add device-radius first, and the other parts of the spec should be developed more. The device-radius is intuitive and simple, and we've already implemented it in blink internally.

 

   

Also, has your team committed code to Blink before?

We're first to commit our codes to Blink. I'd like to briefly get a guide to proceed our contribution.

Well there is this:

https://www.chromium.org/developers/contributing-code

In general I don't think it's a good idea to try to jump directly to implementing difficult features before spending time building experience on the existing code and relationships with existing engineers and teams.

It would be great to start by fixing some existing bugs and TODOs in the code.

Chris

[ana...@gmail.com]

On Tue, Oct 13, 2015 at 3:07 AM Chris Harrelson <chri...@chromium.org> wrote:

On Mon, Oct 12, 2015 at 5:54 AM <ana...@gmail.com> wrote:

On Fri, Oct 9, 2015 at 1:22 AM Chris Harrelson <chri...@chromium.org> wrote:

On Wed, Oct 7, 2015 at 8:59 PM Rick Byers <rby...@chromium.org> wrote:

On Wed, Oct 7, 2015 at 12:22 PM, Chris Harrelson <chri...@chromium.org> wrote:

Hi,

Implementing this cleanly and performantly might be hard to pull off. Before any code is written, I think there need to be design documents and discussions about how best to implement this.

Chris, is your comment here specifically about the device-radius media feature?  Or are you talking about the other parts of the spec.  Naively, the media feature itself seems like it should be pretty straight forward.  And if, as Tab suggests, that's used as a primitive along with the Houdini APIs to build the rest in script, then that seems great from an engine complexity standpoint.

My concerns were about the other parts of the spec, which introduce polar coordinates and a non-rectangular layout screen. I agree that device-radius media queries are easy to add.

I also agree to add device-radius first, and the other parts of the spec should be developed more. The device-radius is intuitive and simple, and we've already implemented it in blink internally.

 

   

Also, has your team committed code to Blink before?

We're first to commit our codes to Blink. I'd like to briefly get a guide to proceed our contribution.

Well there is this:

https://www.chromium.org/developers/contributing-code

In general I don't think it's a good idea to try to jump directly to implementing difficult features before spending time building experience on the existing code and relationships with existing engineers and teams.

It would be great to start by fixing some existing bugs and TODOs in the code.

Chris

Ah, We have the experience to develop WebKit and Blink from old time, and received a review of our implementation from Intel Crosswalk side.

You can find the progress as follow. (changed more after that commit)

PR: https://github.com/crosswalk-project/blink-crosswalk/pull/67

Diff: https://github.com/anawhj/blink-crosswalk/commit/4f75904a3012cf6d287419c4b77284055ebe6624

Then, we'll go ahead to request applying device-radius into Blink as soon as prepared.

Hyojin

[Joone Hur]

Hi,

I’m enabling the device-radius based on Hyojin's patches for Android Wear in Crosswalk.

https://github.com/joone/crosswalk/commit/7d356128f397f40b70a7cb87784ab6b069d7b144

https://github.com/joone/chromium-crosswalk/commit/199f4bdd737b26fe07f8b545594b80d06c62ae71

There seems no way to get the device-radius value from Android Wear platform.

WindowInsets.isRound() can be only used to know whether the display is round or not, but if the display is oval, this API doesn’t help.

So we need an API that returns the device-radius value according to the display shape from the platform.

Thanks,

Joone

[Chris Harrelson]

It seems I misunderstood this thread. The original email was titled "Intent to Implement: CSS Round Display", but the summary details indicates it's just the media feature. LGTM to implement that. However, then API owners met and we concluded that the rest of the spec should not be implemented at this time.

Chris

[ana...@gmail.com]

I was hoping to review the implementation of CSS Round Display at first, and it seems to be clarified now.

Thanks,

Hyojin

[Chris Harrelson]

HI Hyojin,

When you start implementing, please also create an OWP feature tracking bug and an entry on chromestatus.com with a description.

Thanks,

Chris

[ana...@gmail.com]

Hi all,

I had proposed the implementation about 'device-radius' media feature a year ago, and suspended it due to a possibility of the spec change.

The change was completely merged in the spec document: https://drafts.csswg.org/css-round-display/ (chapter 3.1)

The following list is a summary of the change.

- The name of 'device-radius' is changed to 'shape' as a media feature to be used in Media Queries for determining what the display shape is.

- The functionality of the media feature('shape')  is same as before('device-radius').

- The value set of the media feature is chaged from numbers([<length>|<percentage>]) to strings(rect|round)

- The resolution for 'shape' media feature from CSS WG: https://log.csswg.org/irc.w3.org/css/2016-05-10/#e683089

- The 'shape' media feature can be used in several devices with web-based platform and rounded display (e.g. LG Smart Watch)

I already got LGTM before, but I'd like to get a re-confirmation about the implementation of 'shape' media feature with changes.

As one more question, how can I create the OWP feature tracking bug and an entry on chromestatus.com with a description, Chris Harrelson mentioned.

Is the following link OWP feature tracking bug?: https://bugs.chromium.org/p/chromium/issues/detail?id=535803

I wonder how I get the permission to create 'shape' description on chromestatus.com.

Thanks,

Hyojin

2015년 10월 15일 목요일 오전 2시 40분 8초 UTC+9, Chris Harrelson 님의 말:

[PhistucK]

You can create a launch bug using this link, I think -

https://bugs.chromium.org/p/chromium/issues/entry?template=OWP%20Launch%20Tracking

Regarding the ChromeStatus.com entry, you either need access, or just paste the information and I can add it.

☆PhistucK

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.