Intent to Implement and Ship: SubmitEvent interface

Jihwan Kim

unread,

Dec 1, 2019, 3:44:31 PM12/1/19

to blink-dev

Contact emails
bluewha...@gmail.com,tk...@chromium.org

Explainer
N/A

Design docs/spec
Specification: https://html.spec.whatwg.org/C/#the-submitevent-interface

TAG review
N/A; A trivial change on the existing feature

Summary
'submit' event, which is dispatch on form submission, gets its own interface, SubmitEvent, and it has 'submitter' property.

Motivation
Some web applications do their own form submission by preventDefault()ing 'submit' event. However, the event didn't tell which submit button triggered this submission. Adding 'submitter' property to the event enables application to refer to an entry data, the formaction attribute, the formenctype attribute, the formmethod attribute, and the formtarget attribute of the submitter button.

Risks
Interoperability and Compatibility
Compatibility: This is a small addition to an existing event. So compatibility risk is almost none.
Interoperability: A Mozilla developer is supportive. No objection from other vendors.

Firefox: Public support (https://github.com/whatwg/html/issues/3195#issue-271072906)
Edge: No public signals
Safari: No public signals
Web developers: Positive (https://github.com/whatwg/html/issues/3195)
See some comments in the issue.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux,
Chrome OS, Android, and Android WebView)?
Yes

Is this feature fully tested by web-platform-tests?
Yes
https://wpt.fyi/results/html/semantics/forms/form-submission-0/form-submission-algorithm.html?label=experimental&label=master will show new test cases.

Tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1014418

Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5187248926490624

Yoav Weiss

unread,

Dec 2, 2019, 12:31:52 AM12/2/19

to Jihwan Kim, blink-dev

LGTM1

On Sun, Dec 1, 2019 at 9:44 PM Jihwan Kim <bluewha...@gmail.com> wrote:

Contact emails
bluewha...@gmail.com,tk...@chromium.org

Explainer
N/A

A few lines outlining what this thing is, what's the motivation to adding it and how developers are supposed to use it would have been helpful in reviewing this.

Design docs/spec
Specification: https://html.spec.whatwg.org/C/#the-submitevent-interface

TAG review
N/A; A trivial change on the existing feature

Summary
'submit' event, which is dispatch on form submission, gets its own interface, SubmitEvent, and it has 'submitter' property.

Motivation
Some web applications do their own form submission by preventDefault()ing 'submit' event. However, the event didn't tell which submit button triggered this submission. Adding 'submitter' property to the event enables application to refer to an entry data, the formaction attribute, the formenctype attribute, the formmethod attribute, and the formtarget attribute of the submitter button.

Risks
Interoperability and Compatibility
Compatibility: This is a small addition to an existing event. So compatibility risk is almost none.
Interoperability: A Mozilla developer is supportive. No objection from other vendors.

Firefox: Public support (https://github.com/whatwg/html/issues/3195#issue-271072906)

Note: This typically doesn't count as public support, but as "positive signals".

To get public support from Mozilla would require opening an issue on their standard positions repo.

Edge: No public signals
Safari: No public signals

Can you open a WebKit issue?

Web developers: Positive (https://github.com/whatwg/html/issues/3195)
See some comments in the issue.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux,
Chrome OS, Android, and Android WebView)?
Yes

Is this feature fully tested by web-platform-tests?
Yes
https://wpt.fyi/results/html/semantics/forms/form-submission-0/form-submission-algorithm.html?label=experimental&label=master will show new test cases.

Tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1014418

Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5187248926490624

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/53ba8c39-3598-4f79-8860-dbb88be2ded2%40chromium.org.

Rick Byers

unread,

Dec 2, 2019, 11:26:32 AM12/2/19

to Yoav Weiss, Jihwan Kim, blink-dev, Boris Zbarsky

LGTM2 (assuming no objections surface from other implementers as a result of this thread - since there isn't currently any strong signal)

Seems trivial and likely non-controversial

On Mon, Dec 2, 2019 at 12:31 AM Yoav Weiss <yo...@yoav.ws> wrote:

LGTM1

On Sun, Dec 1, 2019 at 9:44 PM Jihwan Kim <bluewha...@gmail.com> wrote:
Contact emails
bluewha...@gmail.com,tk...@chromium.org

Explainer
N/A

A few lines outlining what this thing is, what's the motivation to adding it and how developers are supposed to use it would have been helpful in reviewing this.

This text is also used when constructing the blog entry, etc. so it is important even post-review. But I think the summary / motivation section capture everything I'd expect the blog entry to say. Maybe in one line: "Adds a 'submitter' property to 'submit' events to enable developers who intercept such events to reason about their source".

Design docs/spec
Specification: https://html.spec.whatwg.org/C/#the-submitevent-interface

TAG review
N/A; A trivial change on the existing feature

Summary
'submit' event, which is dispatch on form submission, gets its own interface, SubmitEvent, and it has 'submitter' property.

Motivation
Some web applications do their own form submission by preventDefault()ing 'submit' event. However, the event didn't tell which submit button triggered this submission. Adding 'submitter' property to the event enables application to refer to an entry data, the formaction attribute, the formenctype attribute, the formmethod attribute, and the formtarget attribute of the submitter button.

Risks
Interoperability and Compatibility
Compatibility: This is a small addition to an existing event. So compatibility risk is almost none.
Interoperability: A Mozilla developer is supportive. No objection from other vendors.

Firefox: Public support (https://github.com/whatwg/html/issues/3195#issue-271072906)

Note: This typically doesn't count as public support, but as "positive signals".
To get public support from Mozilla would require opening an issue on their standard positions repo.

The last I see from Boris on this issue is "I suspect we'd want to at least look at implementing this, yes, if people like the idea." from two years ago. +Boris, please let us know if you see any reason why Firefox may be opposed.

Edge: No public signals
Safari: No public signals

Can you open a WebKit issue?

Web developers: Positive (https://github.com/whatwg/html/issues/3195)
See some comments in the issue.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux,
Chrome OS, Android, and Android WebView)?
Yes

Is this feature fully tested by web-platform-tests?
Yes
https://wpt.fyi/results/html/semantics/forms/form-submission-0/form-submission-algorithm.html?label=experimental&label=master will show new test cases.

Tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1014418

Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5187248926490624

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/53ba8c39-3598-4f79-8860-dbb88be2ded2%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEiVbxpUaR5bnEwjTqYFXRr%3DNRnZcYkK7NN6a_FiMftxQg%40mail.gmail.com.

Chris Harrelson

unread,

Dec 2, 2019, 12:39:25 PM12/2/19

to Rick Byers, Yoav Weiss, Jihwan Kim, blink-dev, Boris Zbarsky

LGTM3

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8ESQaJbEcFJtQzBN8hNefWotSzS8cfoMo6EMoATSz_%2Bg%40mail.gmail.com.

Boris Zbarsky

unread,

Dec 2, 2019, 1:40:15 PM12/2/19

to Rick Byers, blink-dev

On 12/2/19 11:26 AM, Rick Byers wrote:
> LGTM2 (assuming no objections surface from other implementers as a
> result of this thread - since there isn't currently any strong signal)

Asking me is _slightly_ cheating, since I filed the spec issue asking
for this.

But in general, I don't think there are objections here on the Mozilla
side, and certainly not from me personally. Our bug that tracks
implementing this is at
https://bugzilla.mozilla.org/show_bug.cgi?id=1588715 and it looks like
generally people are planning to work on this, time permitting.

-Boris

Rick Byers

unread,

Dec 2, 2019, 1:50:30 PM12/2/19

to Boris Zbarsky, blink-dev, TAMURA, Kent

On Mon, Dec 2, 2019 at 1:40 PM Boris Zbarsky <bzba...@mit.edu> wrote:

On 12/2/19 11:26 AM, Rick Byers wrote:
> LGTM2 (assuming no objections surface from other implementers as a
> result of this thread - since there isn't currently any strong signal)

Asking me is _slightly_ cheating, since I filed the spec issue asking
for this.

Sorry :-)

But in general, I don't think there are objections here on the Mozilla
side, and certainly not from me personally. Our bug that tracks
implementing this is at
https://bugzilla.mozilla.org/show_bug.cgi?id=1588715 and it looks like
generally people are planning to work on this, time permitting.

That's perfect (sorry I missed it), thank you! And Thanks +tkent for filing the issue on Gecko.

-Boris

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/44cc4022-74b8-b3e8-bf15-3ac09a6d756e%40mit.edu.

Joe Medley

unread,

Dec 4, 2019, 3:42:38 PM12/4/19

to Rick Byers, Boris Zbarsky, blink-dev, TAMURA, Kent

The status entry is marked 'No active development'. I take it that is no longer the case?

Joe Medley | Technical Writer, Chrome DevRel | jme...@google.com | 816-678-7195

If an API's not documented it doesn't exist.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8%3DnbC0Cdt3JFfiFrv7RhV2S9v5s2wNeu8bj4529DyRrw%40mail.gmail.com.

TAMURA, Kent

unread,

Dec 4, 2019, 6:20:39 PM12/4/19

to Yoav Weiss, Jihwan Kim, blink-dev

Here is the WebKit issue without any reactions: https://bugs.webkit.org/show_bug.cgi?id=202978

Web developers: Positive (https://github.com/whatwg/html/issues/3195)
See some comments in the issue.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux,
Chrome OS, Android, and Android WebView)?
Yes

Is this feature fully tested by web-platform-tests?
Yes
https://wpt.fyi/results/html/semantics/forms/form-submission-0/form-submission-algorithm.html?label=experimental&label=master will show new test cases.

Tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1014418

Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5187248926490624

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/53ba8c39-3598-4f79-8860-dbb88be2ded2%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEiVbxpUaR5bnEwjTqYFXRr%3DNRnZcYkK7NN6a_FiMftxQg%40mail.gmail.com.

--

TAMURA Kent
Software Engineer, Google

TAMURA, Kent

unread,

Dec 4, 2019, 6:24:07 PM12/4/19

to Joe Medley, blink-dev

On Thu, Dec 5, 2019 at 5:42 AM Joe Medley <jme...@google.com> wrote:

The status entry is marked 'No active development'. I take it that is no longer the case?

Jihwan is working on implementing this feature, and the status should be "In development". I updated it.

Joe Medley

unread,

Dec 5, 2019, 11:30:49 AM12/5/19

to TAMURA, Kent, blink-dev

Great, thanks!

Joe Medley | Technical Writer, Chrome DevRel | jme...@google.com | 816-678-7195

If an API's not documented it doesn't exist.

Reply all

Reply to author

Forward