Intent to Implement and Ship: PaymentDetails.error

[Rouslan Solomakhin]

Contact emails

rou...@chromium.org, hs121...@samsung.com

Spec

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary

Tag review

Skipped. API surface too small.

Summary

When the payment request is updated using updateWith, the PaymentDetails can contain a message in the error field that will be displayed to the user.  The error field cannot be passed to the PaymentRequest constructor. Doing so will cause a TypeError to be thrown.

Motivation

This might commonly be used to explain why goods cannot be shipped to the chosen shipping address.

Interoperability risk

Firefox: No public signals

Edge: No public signals

Safari: No public signals

Web developers: Strongly positive

Compatibility risk

Small.

Ongoing technical constraints

None

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux,

Chrome OS, Android, and Android WebView)? Yes or no.

No. PaymentDetails.error can be used only for PaymentRequest, which is currently supported only on Android. Eventually more platforms will support PaymentRequest, except WebView.

OWP launch tracking bug

http://crbug.com/648240

Link to entry on the Chrome Platform Status

https://www.chromestatus.com/feature/4655740933373952

Requesting approval to ship?

Yes

[Chris Harrelson]

LGTM1

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

[Philip Jägenstedt]

The spec says "If details contains a value for error, then throw a TypeError" in the PaymentRequest constructor, but Blink makes an exception and doesn't throw for the empty string. Can you fix the spec or the implementation, and test this in web-platform-tests?

LGTM2 with that.

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

[Rouslan Solomakhin]

Sent out http://crrev.com/2532953006 for review to fix the implementation. Let me know if I misunderstood your concern.

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

[Philip Jägenstedt]

That's what I meant, thanks for fixing!

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

[TAMURA, Kent]

LGTM3

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

--

TAMURA Kent
Software Engineer, Google