Intent to Implement and Ship: DeviceOrientationEvent and DeviceMotionEvent constructors

[Reilly Grant]

Contact emails rei...@chromium.org Spec https://w3c.github.io/deviceorientation/spec-source-orientation.html Summary The DeviceOrientationEvent and DeviceMotionEvent constructors are defined by the DeviceOrientation Event Specification but were not were not implemented in Chrome. Firefox has already shipped these constructors as specified. Motivation These constructors are useful for constructing synthetic events and are needed to pass the DeviceOrientationEvent Web Platform Tests. Interoperability risk Firefox: Shipped Edge: No public signals Safari: No public signals Web developers: No signals

The DeviceOrientation Event Specification has been implemented by Chrome, Firefox and Mobile Safari however only Firefox has shipped the constructors for these event objects.

Compatibility risk

None. This functions have already been shipped by Firefox. Ongoing technical constraints

None Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? Yes or no.

Yes OWP launch tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=651767 Link to entry on the Chrome Platform Status https://www.chromestatus.com/features/4659236399218688 Requesting approval to ship?

Yes

[Rick Byers]

LGTM1, thanks for doing this!

Constructors are somewhat rare, but it's important that we follow the general DOM event construction pattern.

BTW, I'm trying to get in the habit of asking about web-platform-tests for new APIs.  In this case I see the bug came from a report of a failing test (and there are some other tests in that directory) so I assume we're in good shape test-wise.

[Chris Harrelson]

LGTM2

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.

[Dimitri Glazkov]

LGTM3

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

[Reilly Grant]

Thank you. I'll have to figure out how to import those tests but the coverage is already there and is what I used to check my implementation.

[Rick Byers]

I think it should be as easy as commenting out this line (and adding a comment line saying who owns the directory) and waiting for the daily auto-import.