Intent to Remove: MediaController

[Philip Jägenstedt]

Primary eng (and PM) emails

phi...@opera.com

Link to “Intent to Deprecate” thread

It was unshipped (put behind a flag) over a year ago, which generated some discussion:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/MVcoNSPs1UQ/LIF-fvu2lwoJ

Summary

Remove the code for MediaController entirely. Other than MediaController.cpp itself, that affects HTMLMediaElement and to some extent MediaControls.

MediaController is a mechanism for synchronizing the playback of multiple media elements. See the unshipping thread for details.

Motivation

We're considering removing MediaController from the HTML spec, and will do so if no implementors show interest in the feature: https://github.com/whatwg/html/issues/192

It's already disabled by default in Blink, but I'm sending this intent to highlight the removal, just in case somebody secretly plans to work on it.

If I get some LGTMs and no objects, I'll remove the code once the feature is gone from the spec.

(The rest of the template excluded as it is not relevant.)

[Chris Harrelson]

LGTM. Maybe just delete it now? is the code rotting or getting in the way?

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

[Philip Jägenstedt]

It actually does kind of get in the way, in particular it makes it such that one always has to consider MediaController when trying to play/pause a HTMLMediaElement. I'll prepare the CLs to show what would be simplified.

[Philip Jägenstedt]

Here it is: https://codereview.chromium.org/1373423003/

[Chris Harrelson]

On quick inspection, looks like a nice enough cleanup to me to justify deleting.

[TAMURA, Kent]

LGTM

--

TAMURA Kent
Software Engineer, Google

[Rick Byers]

Since this is already not shipped, I don't think any approval is necessary.  But LGTM2 anyway :-)

[Philip Jägenstedt]

Thanks everyone, I'll go ahead and remove the code!