Intent to remove RangeException

308 views
Skip to first unread message

Erik Arvidsson

unread,
May 3, 2013, 4:09:55 PM5/3/13
to blink-dev

(It isn't clear that this needs an "intent" email but better to err on side of being too clear.)

Primary eng

a...@google.com


Spec

http://http://dom.spec.whatwg.org/


Summary

A RangeException can be thrown when working with DOM ranges. The spec says to throw DOMException instead of RangeException. RangeException no longer exist in any spec (they used to be part of "DOM Level 2 Traversal and Range" spec).


Motivation

Clean up our surface area as well as increase web compatibility.


Compatibility Risk

Low. Firefox does not have RangeException and throws DOMException as specified.


Apple was in favor of this change but needed to keep their ObjectiveC bindings around: https://bugs.webkit.org/show_bug.cgi?id=102515#c5


Bug

https://code.google.com/p/chromium/issues/detail?id=229397


Patch

https://codereview.chromium.org/14705009


Row on feature dashboard?

No. Minor change


Requesting approval to ship?

Yes.



--
erik


Eric Seidel

unread,
May 3, 2013, 4:13:34 PM5/3/13
to Erik Arvidsson, blink-dev
LGTM. I don't think we need these emails, but it's still on my todo
list to reply to Max's email on the subject. :)

For trivial features where we're the only engine (other than WebKit)
implementing them, removing them seems obvious.

Dimitri Glazkov

unread,
May 7, 2013, 3:34:10 PM5/7/13
to Eric Seidel, Erik Arvidsson, blink-dev
LGTM as well. I also think we should not need LGTMx3 to remove
WebKit-only, low compat risk features.

:DG<

Adam Barth

unread,
May 7, 2013, 3:48:07 PM5/7/13
to Dimitri Glazkov, Eric Seidel, Erik Arvidsson, blink-dev
LGTM3 for completeness.
Reply all
Reply to author
Forward
Message has been deleted
0 new messages