You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Xing, blink-dev
LGTM1, thanks for driving this!
Rick Byers
unread,
Dec 16, 2016, 10:25:03 AM12/16/16
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Philip Jägenstedt, Xing, blink-dev, Geoffrey Sneddon, Boris Zbarsky
LGTM2
For others who haven't seen the related thread - these are just aliases of our existing prefixed -webkit-{min,max}-logical-{width,height} properties.
Unfortunately there don't appear to be any tests for this spec in csswg-test - the only hits I find are in vendor-imports/mozilla/ (maybe worth checking to see if we pass those tests once this is added?). Perhaps we have LayoutTests tests for -webkit-{min,max}-logical-{width,height} we could easily update and upstream to csswg-test?
Rick
PhistucK
unread,
Dec 16, 2016, 10:28:38 AM12/16/16
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Rick Byers, Philip Jägenstedt, Xing, blink-dev, Geoffrey Sneddon, Boris Zbarsky
Only partially related, but Mozilla people mentioned that they have CSS Grid tests that use those properties extensively, so maybe those could be useful as well (it will test both of the features, yes, but more tests are better than less tests ;)).
☆PhistucK
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
Dimitri Glazkov
unread,
Dec 16, 2016, 10:38:09 AM12/16/16
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Rick Byers, Philip Jägenstedt, blink-dev
LGTM3
Christian Biesinger
unread,
Dec 16, 2016, 1:03:12 PM12/16/16
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Dimitri Glazkov, Rick Byers, Philip Jägenstedt, blink-dev