Intent to Implement and Ship: replace() function of DOMTokenList

[TAMURA, Kent]

Contact emails

tk...@chromium.org 

Spec

https://dom.spec.whatwg.org/#dom-domtokenlist-replace

Summary

Adding replace(token, newToken) method to DOMTokenList such as element.classList.

Motivation

Improve DOM conformance and interoperability.

Interoperability and Compatibility Risk

The risk is very low.  Adding a new function to an existing interface, and two major browsers already shipped it.

Edge: No signals

Firefox: Shipped

Safari: Shipped

Web developers: No signals

Is this feature fully tested by web-platform-tests?

Yes.  http://w3c-test.org/dom/nodes/Element-classlist.html

Ongoing technical constraints

None.

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes.

OWP launch tracking bug

http://crbug.com/724906

Link to entry on the feature dashboard

https://www.chromestatus.com/feature/5691753315172352

Requesting approval to ship?

Yes.

-- 

TAMURA Kent
Software Engineer, Google

[Philip Jägenstedt]

LGTM1

This will leave Edge as the last engine to not support replace(), and they'll likely want to prioritize it. Can you file an issue at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/new/ pointing to this thread and the tests?

(In https://lists.w3.org/Archives/Public/public-test-infra/2017AprJun/thread.html#msg38 +John Jansen wondered if there's any good way to prioritize wpt failures, and this seems like a clear-cut case.)

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGUFvTrxa-cqVxjd-njKSO6kdQQckNfoWveuEfJ05uscQ%40mail.gmail.com.

[Jochen Eisinger]

lgtm2

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYeuM0JbStYp649WY2AFQaoH9-w9SunXCuwyZXizRzUb3g%40mail.gmail.com.

[John Jansen]

I wish all of the failures in W-P-T were this easy to prioritize 😊

[Rick Byers]

LGTM3

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/BLUPR0301MB20973FB0B38AD1D431E41A72F1F00%40BLUPR0301MB2097.namprd03.prod.outlook.com.

[TAMURA, Kent]

I think this is a part of https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11297888/ .

[John Jansen]

Excellent, thanks. It’s assigned to the correct person. I appreciate your comment on the passing status of the other browsers.