lsc-review - Google Groups

Groups

1–30 of 58

0 selected

Alex Ovsienko, … Nico Weber4

Oct 1

Linting with Ruff LSC

That breakage was rare, at least according to the agent I sent to investigate the issue. However, I

unread,

Linting with Ruff LSC

That breakage was rare, at least according to the agent I sent to investigate the issue. However, I

Oct 1

Md.Parvez Ahamed

Sep 22

unread,

Sep 22

Matt Stark, Colin Blundell5

Sep 11

[LSC Proposal] Enabling check_includes_strict for chromium

On Fri, Sep 11, 2026 at 1:54 AM Matt Stark <ms...@google.com> wrote: What I'm taking away is

unread,

[LSC Proposal] Enabling check_includes_strict for chromium

On Fri, Sep 11, 2026 at 1:54 AM Matt Stark <ms...@google.com> wrote: What I'm taking away is

Sep 11

Matt Stark, … Colin Blundell8

Sep 9

[LSC Proposal] Eliminating allow_circular_includes_from in chromium

Hello, I've added those four folks to lsc-owners-override@ for this use case (discussion on the

unread,

[LSC Proposal] Eliminating allow_circular_includes_from in chromium

Hello, I've added those four folks to lsc-owners-override@ for this use case (discussion on the

Sep 9

Alex Ovsienko, … Nico Weber10

Sep 8

VPython UV config conversion

Also, the Security team explicitly wanted lock files to find and remove bad hashes, which we couldn

unread,

VPython UV config conversion

Also, the Security team explicitly wanted lock files to find and remove bad hashes, which we couldn

Sep 8

Steven Holte, Nico Weber3

Aug 13

Chrome LSC: Sort out opt-guide junk drawers

I added wittman@ as requested in the doc. On Tue, Aug 11, 2026 at 3:09 PM 'Steven Holte' via

unread,

Chrome LSC: Sort out opt-guide junk drawers

I added wittman@ as requested in the doc. On Tue, Aug 11, 2026 at 3:09 PM 'Steven Holte' via

Aug 13

Yuki Shiino, … Stephen Nusko6

Aug 13

Request for LSC for DCHECK-to-CHECK conversions

Thanks Nico! Yeah I asked Yuki to expand it to the team since vacations would otherwise block the

unread,

Request for LSC for DCHECK-to-CHECK conversions

Thanks Nico! Yeah I asked Yuki to expand it to the team since vacations would otherwise block the

Aug 13

Alex Ovsienko, … Nico Weber3

Jul 29

Chromium Ruff formatting

Given that the main doc had good discussion and python owners seem to be happy with this, direction,

unread,

Chromium Ruff formatting

Given that the main doc had good discussion and python owners seem to be happy with this, direction,

Jul 29

Alex Ovsienko, Colin Blundell2

Jul 21

Pylint Chromium LSC review

Thanks! I left comments on the doc. Best, Colin On Tue, Jul 21, 2026 at 6:53 AM 'Alex Ovsienko

unread,

Pylint Chromium LSC review

Thanks! I left comments on the doc. Best, Colin On Tue, Jul 21, 2026 at 6:53 AM 'Alex Ovsienko

Jul 21

Emily Shack, Colin Blundell7

Jun 25

Icon Renaming: Request for LSC Approval

Thanks, Emily! I just removed you from the list - +1 to filing the new LSC request (referencing this

unread,

Icon Renaming: Request for LSC Approval

Thanks, Emily! I just removed you from the list - +1 to filing the new LSC request (referencing this

Jun 25

Alison Gale, … Colin Blundell12

May 4

LSC to migrate crbug IDs to issue tracker IDs

👍 On Mon, May 4, 2026 at 6:45 PM Alison Gale <ag...@google.com> wrote: It was only going to be

unread,

LSC to migrate crbug IDs to issue tracker IDs

👍 On Mon, May 4, 2026 at 6:45 PM Alison Gale <ag...@google.com> wrote: It was only going to be

May 4

Lynne Jiang, Nico Weber3

Apr 23

LSC Review Request: TFLite -> LiteRT Migration

Hi Nico, Sounds good, thanks for the approval! I'll send the changes over to you for the review.

unread,

LSC Review Request: TFLite -> LiteRT Migration

Hi Nico, Sounds good, thanks for the approval! I'll send the changes over to you for the review.

Apr 23

Thomas Lukaszewicz, Colin Blundell5

Apr 8

LSC to convert all KeyedService factories from base::Singleton to base::NoDestructor

On Tue, Apr 7, 2026 at 8:47 PM Thomas Lukaszewicz <tl...@chromium.org> wrote: Pull out the two

unread,

LSC to convert all KeyedService factories from base::Singleton to base::NoDestructor

On Tue, Apr 7, 2026 at 8:47 PM Thomas Lukaszewicz <tl...@chromium.org> wrote: Pull out the two

Apr 8

Cliff Smolinsky, Colin Blundell6

Apr 3

Request for review: Update KeyedServiceFactories from Singleton to NoDestructor

Bummer! Let's just make this the canonical thread then. This was my reply on the other thread:

unread,

Request for review: Update KeyedServiceFactories from Singleton to NoDestructor

Bummer! Let's just make this the canonical thread then. This was my reply on the other thread:

Apr 3

Jeffrey Yu (via Google Docs), … Jeffrey Yu6

Feb 26

Document shared with you: "[Chromium] Migrate std::unordered to Abseil Containers LSC"

Acknowledged. Abandoned the existing in-flight CLs. On Thu, Feb 26, 2026 at 10:53 AM Nico Weber <

unread,

Document shared with you: "[Chromium] Migrate std::unordered to Abseil Containers LSC"

Acknowledged. Abandoned the existing in-flight CLs. On Thu, Feb 26, 2026 at 10:53 AM Nico Weber <

Feb 26

Solomon Kinard, … Alison Gale7

Jan 28

LSC: Migrate crbug/ links to Buganizer from Monorail

I didn't realize you were linking a CL that had the change rather than describing the change in

unread,

LSC: Migrate crbug/ links to Buganizer from Monorail

I didn't realize you were linking a CL that had the change rather than describing the change in

Jan 28

Charlie Harrison, Rick Byers4

12/16/25

LSC: Migrating GURL Accessors

Ah thanks Charlie, glad to hear that we didn't in fact drop the review entirely. On Tue, Dec 16,

unread,

LSC: Migrating GURL Accessors

Ah thanks Charlie, glad to hear that we didn't in fact drop the review entirely. On Tue, Dec 16,

12/16/25

Daniel Vogelheim, … Rick Byers3

12/15/25

EXPECT_CALL with catch-all matchers

Oof, I also missed this thread. Clearly we need to change something about the lsc-review list, ATLs

unread,

EXPECT_CALL with catch-all matchers

Oof, I also missed this thread. Clearly we need to change something about the lsc-review list, ATLs

12/15/25

Steven Holte, Nico Weber2

10/20/25

Owners-Override for crrev/7045952 [Split an interface into 2]

Done! On Fri, Oct 17, 2025 at 5:28 PM 'Steven Holte' via lsc-review <lsc-review@chromium.

unread,

Owners-Override for crrev/7045952 [Split an interface into 2]

Done! On Fri, Oct 17, 2025 at 5:28 PM 'Steven Holte' via lsc-review <lsc-review@chromium.

10/20/25

Charles Meng, … Nico Weber13

6/18/25

LSC Request - Removing chrome::FindBrowserWithTab

Sure, I originally had all the changes in a single commit before I found out about the LSC process. I

unread,

LSC Request - Removing chrome::FindBrowserWithTab

Sure, I originally had all the changes in a single commit before I found out about the LSC process. I

6/18/25

Steven Holte, Nico Weber2

6/3/25

Request Global Approval for updating includes of renamed files

Lgtm. I added wit...@chromium.org to the global OO+1 list. On Tue, Jun 3, 2025, 2:12 PM 'Steven

unread,

Request Global Approval for updating includes of renamed files

Lgtm. I added wit...@chromium.org to the global OO+1 list. On Tue, Jun 3, 2025, 2:12 PM 'Steven

6/3/25

Steven Holte (via Google Docs)

6/2/25

Document shared with you: "components-optimization-guide-core-subdirs-lsc"

Steven Holte shared a document Steven Holte (ho...@google.com) has invited you to edit the following

unread,

Document shared with you: "components-optimization-guide-core-subdirs-lsc"

Steven Holte shared a document Steven Holte (ho...@google.com) has invited you to edit the following

6/2/25

3/5/25

LSC proposal - Migrate web_applications folder to webapps folder

Any updates here? :) Ho Cheung <hoch...@chromium.org> 於 2025年2月13日週四上午11:03寫道： Dear LSC

unread,

LSC proposal - Migrate web_applications folder to webapps folder

Any updates here? :) Ho Cheung <hoch...@chromium.org> 於 2025年2月13日週四上午11:03寫道： Dear LSC

3/5/25

Arthur Milchior, Rick Byers3

1/26/25

Hi, It seems I still have OO+, while the LSC is fully landed. Thanks Rick for giving it to me. Can I

unread,

Hi, It seems I still have OO+, while the LSC is fully landed. Thanks Rick for giving it to me. Can I

1/26/25

Peter Kasting, … Peter Boström14

12/17/24

Seeking input: C++ style change policy

On Mon, Dec 16, 2024 at 5:20 PM Peter Kasting <pkas...@google.com> wrote: I tweaked to resolve

unread,

Seeking input: C++ style change policy

On Mon, Dec 16, 2024 at 5:20 PM Peter Kasting <pkas...@google.com> wrote: I tweaked to resolve

12/17/24

10/13/24

unread,

10/13/24

Devon Loehr, Nico Weber2

7/25/24

LSC for removing implicit `this` capture in lambdas

lgtm! On Thu, Jul 25, 2024 at 11:45 AM 'Devon Loehr' via lsc-review <lsc-review@chromium.

unread,

LSC for removing implicit `this` capture in lambdas

lgtm! On Thu, Jul 25, 2024 at 11:45 AM 'Devon Loehr' via lsc-review <lsc-review@chromium.

7/25/24

Takuto Ikuta, John Abd-El-Malek3

2/16/24

LSC to remove unnecessary include from browser_test_base.h

Ah, I see. Then let me ask for global approval there directly. Thanks. On Fri, Feb 16, 2024 at 4:27

unread,

LSC to remove unnecessary include from browser_test_base.h

Ah, I see. Then let me ask for global approval there directly. Thanks. On Fri, Feb 16, 2024 at 4:27

2/16/24

Andrew Grieve, John Abd-El-Malek2

10/13/23

LSC for reformatting java code

LGTM. Andrew you already have owners override so you should be good to go. On Fri, Oct 13, 2023 at 12

unread,

LSC for reformatting java code

LGTM. Andrew you already have owners override so you should be good to go. On Fri, Oct 13, 2023 at 12

10/13/23

Keishi Hattori, … Keishi Hattori3

7/27/23

Requesting LSC for BRP Renderer rewrite

Thanks! On Thu, Jul 27, 2023 at 7:42 AM John Abd-El-Malek <j...@google.com> wrote: Done, please

unread,

Requesting LSC for BRP Renderer rewrite

Thanks! On Thu, Jul 27, 2023 at 7:42 AM John Abd-El-Malek <j...@google.com> wrote: Done, please

7/27/23

Search

Clear search

Close search

Google apps

Main menu