Hi Waldo
Waldo Withers ha scrito il 09/03/2015 alle 20:42:
> Hi,
> We're students at Cornell working as contributors to codebender, and we
> want to commit a patch to the Arduino IDE as well, since we have found
> an area that we could improve.
I'm glad you'd like to contribute
>
> I am fairly certain that it would be a straightforward task that we
> could complete in a timely manner, and in fact I have already laid the
> groundwork for other purposes. Would this change be accepted? Anything
> we should keep in mind? Also, could someone point us to the test cases
> for this part of the code? If there aren't we'd write some, so could you
> point us to where to put them?
A general advice is to make separate commits for separate modifications,
and keep the overall patch as small as possible to ease review.
There is a handful of test cases but probably not one that tests this
particular piece of code. Adding a test case greatly simplifies the review.
I can't wait to see your patch
Regards
Federico