VOTE: Christian Murphy for uPortal-home / uPortal-application-framework Committer

[Andrew Petro]

Proposed: that Christian Murphy is recognized as a uPortal-home and uPortal-application-framework Committer.

Christian has been reviewing pull requests and contributing code quality and continuous integration improvements to these projects. The projects are better off for his attentions and I expect will continue to be more better off for his continued attentions.

There are primary reasons to add Christian as a committer: Christian is bringing a lot of thoughtfulness and direct value.

There are also secondary reasons to add Christian as a committer: adding a non-UW committer will help the project work through its aspirations to be adopted and collaborated upon beyond UW.

Committership is a state of mind. It's clear that Christian regards himself as a steward of these projects as shown by his attention to code and CI quality and particularly in the way he interacts with other project participants. It's clear the existing Committers already regard Christian as a steward of the project -- I nearly merged a PR this morning with his +1 (our informal rule is to expect a +1 from a Committer who didn't compose the changeset before merging). This vote formalizes and memorializes what is potentially already in our minds.

This is a Consensus Approval vote: we need 3 Committer +1s and no Committer vetoes for the proposal to carry. The vote thread in concept would run for a week but in practice I expect will hear from all 5 existing Committers before then.

+1 for recognizing Christian Murphy as uPortal-home and uPortal-application-framework Committer.

-Andrew

PS:

uPortal community participants who are not (yet!) Committers on these sub-modules are welcome to express support on this thread or otherwise; it's best to annotate such support as non-binding for clarity in reviewing the thread to understand that the vote threshhold was achieved.  Example "+1 (advisory)" or "+1 (non-binding)".

References:

• Existing uPortal-home committers
• Existing uPortal-application-framework committers
• Apache rules adopted, as best we can, by reference

[Jim Helwig]

+1 (advisory)

--
You received this message because you are subscribed to the Google Groups "uPortal Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to uportal-dev...@apereo.org.
Visit this group at https://groups.google.com/a/apereo.org/group/uportal-dev/.

[sib...@wisc.edu]

+1

It's great having engagement on our pull requests so early and so often. Christian's involvement in the project has helped us stay committed to our open source goals and bettering of the code base.

[Timothy Vertein]

+1 (advisory)

Thank you,

Timothy Vertein

---

From: uport...@apereo.org <uport...@apereo.org> on behalf of sib...@wisc.edu <sib...@wisc.edu>
Sent: Monday, June 26, 2017 12:46 PM
To: uPortal Developers
Subject: [uportal-dev] Re: VOTE: Christian Murphy for uPortal-home / uPortal-application-framework Committer

 

--

[Doug Reed]

+1

---

From: uport...@apereo.org <uport...@apereo.org> on behalf of Andrew Petro <andrew...@wisc.edu>
Sent: Monday, June 26, 2017 12:38:43 PM
To: uPortal Developers
Subject: [uportal-dev] VOTE: Christian Murphy for uPortal-home / uPortal-application-framework Committer

 

--

[David Witter]

+1

On Monday, June 26, 2017 at 12:38:43 PM UTC-5, Andrew Petro wrote:

[Jim Helwig]

Reposting (via reply).

(For some odd reason, Andrew’s email recording the results of this vote is not appearing in the web archive of this thread. He sent it twice, and at least once it got through to my email client (and perhaps yours) but it mysteriously is not showing up; there is an equally mysterious "2 messages have been deleted” message at the bottom of the thread. As an admin of the group I did see that there were two pending messages yesterday, one of which I ‘approved’ but it still seemed to have been deleted. Weird.)

JimH

On Jun 27, 2017, at 12:22 PM, Andrew Petro <andrew...@wisc.edu> wrote:

With unanimous assent from the existing uPortal-home and uPortal-application-framework Committers, Christian Murphy is elected Committer in these contexts.

Andrew Petro: +1

Dave Sibley: +1

Doug Reed: +1

Tim Vertein: +1 (interpreting this as more than advisory, what with your being a committer in this context, Tim. :) ).

Zeke Witter: +1

Congratulations and welcome, Christian.

The MyUW Scrum team has a story for this sprint (starting today) to follow up on executing this, so COMMITTERS.md updates, GitHub access control updates, whatever else there is ought to gel no later than over the next couple of weeks.

-Andrew

On Monday, June 26, 2017 at 12:38:43 PM UTC-5, Andrew Petro wrote:

[Christian Murphy]

Thanks all!

Best Regards,

Christian Murphy

[Andrew Petro]

Christian,

You're quite welcome. The project is lucky to have your attentions.

I think it would now be entirely appropriate for you to start merging your own Pull Requests, e.g. https://github.com/UW-Madison-DoIT/uw-frame/pull/463 . Our (under-documented?) culture has been, when it's a Committer doing the PR proposing:

1. A committer proposes a changeset as a PR

2. At least one other committer +1s it

3. The original proposing committer merges it when it looks good, for reasonable meanings of looks good to the original committer. Comments are resolved, tests are passing, refactoring applied, tests added, whatever seems appropriate. It's usually the original committer doing the merge under the hypothesis that it's the original committer who's got the most context on whether the changeset is "ready".

This is culture, not hard-and-fast rules.

-Andrew