Upgrading Bootstrap version used in CAS 5.3.x

Graham Ballantyne

unread,

Jun 7, 2019, 5:04:25 PM6/7/19

to CAS Community

CAS includes Bootstrap, a HTML/CSS/JS framework. The version used in CAS 5.3.x is somewhat old, v4.1.0, and it has an issue that is affecting our site where users encounter an error when editing a file from SharePoint in the desktop version of Word. Our SharePoint site is behind CAS, so when Word attempts to open the file, it tries to load the CAS login page in its embedded browser, which is most likely based on an old version of IE. When this happens, a JS error is thrown which seems to originate from Bootstrap: Object.keys: argument is not an Object.

This would appear to be the same as https://github.com/twbs/bootstrap/issues/26320. The issue was fixed in a subsequent Bootstrap release.

CAS 6.x includes Bootstrap v4.1.3, and master is up to Bootstrap v4.3.1. Is there any way of getting the version of Bootstrap included in CAS 5.3.x. up to at least 4.1.3, which would fix this issue? Barring that, is there a way to do this in our overlay?

Thanks,
Graham.

–
Graham Ballantyne
Senior Systems Engineer | IT Services
Simon Fraser University | Strand Hall 1001
8888 University Dr., Burnaby, B.C. V5A 1S6
604-837-6698

Andy Ng

unread,

Jun 9, 2019, 9:18:26 PM6/9/19

to CAS Community

Hi Graham,

You can submit a PR (Pull Request) for this branch of CAS here: https://github.com/apereo/cas/tree/5.3.x

If I am not mistaken CAS 5.3.x is still under maintenance period, at least I saw that last update for CSA 5.3.x is 10 days ago (~ 1 Jun 2019). So just submit a PR and it should be fixed soon enough.

Cheers!

- Andy

Graham Ballantyne

unread,

Jun 9, 2019, 9:21:19 PM6/9/19

to cas-...@apereo.org

Hi Andy,

Can-do. Is bumping bumping the boostrapVersion property in https://github.com/apereo/cas/blob/5.3.x/gradle.properties#L247 all that needs to be done?

– Graham

--
- Website: https://apereo.github.io/cas
- Gitter Chatroom: https://gitter.im/apereo/cas
- List Guidelines: https://goo.gl/1VRrw7
- Contributions: https://goo.gl/mh7qDG
---
You received this message because you are subscribed to a topic in the Google Groups "CAS Community" group.
To unsubscribe from this topic, visit https://groups.google.com/a/apereo.org/d/topic/cas-user/MUoTl5982U8/unsubscribe.
To unsubscribe from this group and all its topics, send an email to cas-user+u...@apereo.org.
To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-user/9f69832b-3beb-4c78-ae34-3f9fbbc62890%40apereo.org.

Andy Ng

unread,

Jun 9, 2019, 9:28:15 PM6/9/19

to CAS Community

Hi Graham,

> Is bumping bumping the boostrapVersion property in https://github.com/apereo/cas/blob/5.3.x/gradle.properties#L247 all that needs to be done?

Pretty sure it is.

Although most of the time CAS project members will want you to also add some testing to it,

however with your use case, I think the testing is already done inside bootstrap so I think should be ok. You can include the description in your PR and see if need testing or not :)