Invalid constructor of InvalidCookieException - useless log message

[Petr Bodnár]

Hi,

this is the source code of org.apereo.cas.web.support.InvalidCookieException (v6.2.2):

public class InvalidCookieException extends RootCasException {
    private static final long serialVersionUID = -994393142011101111L;

    public InvalidCookieException(final String message) {
        super(message);
    }
}

As you can see, the constructor expects that it is passing "message" to the parent constructor. But in fact, it is passing in "code".

This has the negative effect of when the exception is logged in the CookieRetrievingCookieGenerator like this:

LOGGER.warn(e.getMessage());

... you will see just "null" as the logged message. Also, unlike various other exception classes, this one doesn't define its "code", not sure if this is not correct as well...

BTW I think this error might have arisen from the fact that RootCasException uses @RequiredArgsConstructor instead of simply declaring the one-parametric constructor explicitly. Something to contemplate about as well?

Can you please have a look at this? It seems like it shouldn't be hard to fix.

[Petr Bodnár]

Hi CAS authors, can you please have a look at this? I think this is a regular bug in the code.