Submit a CAS evolution for 6.6.12

52 views
Skip to first unread message

Jérémie

unread,
Sep 8, 2023, 4:18:35 AM9/8/23
to CAS Community
Hi,
 
I have developped a custom module for Apereo CAS to allow Okta MFA support for CAS Authentication

We have developed a custom working module based on a similar Authy project we've found online.

We are having trouble now to fork, adapt & submit our module to CAS 6.6.12 release due for the end of september. Our Pull Request has been automatically rejected : https://github.com/apereo/cas/pull/5751/files

I've never done that so I might not see obvious steps here.

Thank you  

John

unread,
Sep 8, 2023, 11:09:38 AM9/8/23
to CAS Community, Jérémie
You have basically one large commit for all changes, its much easier for apereo to see what and where is being changed if you make a commit for each section of changes. Also, why is there authy stuff in the mfa module, should probably be renamed, the classes, etc.. to okta, for example, "package org.apereo.cas.adaptors.authy" is already used in cas, should be changed to probably something like "org.apereo.cas.okta" since it already exist and would stay in line with how modules are packaged, the config probably should be under "org.apereo.cas.config" and not be 'authyconfiguration'

Jérémie

unread,
Sep 25, 2023, 5:06:38 AM9/25/23
to CAS Community, John, Jérémie
Yeah I see but I don't know how to split this much more. 

I've contacted a few person also that tells me that this won't pass in 6.x but more in 7.x. How can I be sure that this feature will be (when fixed) validated for Cas, or how will I know in which release (and when). 

We're working on removing all adherences to Authy right now. 

Ray Bon

unread,
Sep 25, 2023, 3:52:13 PM9/25/23
to cas-...@apereo.org, jbann...@gmail.com, crazybr...@gmail.com
Jérémie,


Ray

On Mon, 2023-09-25 at 00:48 -0700, Jérémie wrote:
Notice: This message was sent from outside the University of Victoria email system. Please be cautious with links and sensitive information.

Jérémie

unread,
Oct 12, 2023, 3:38:14 AM10/12/23
to CAS Community, Ray Bon, jbann...@gmail.com, crazybr...@gmail.com
Hi,

We received this email by contacting it : 
--

Hi, 

We're writing to let you know that the group you tried to contact (cas-dev) may not exist, or you may not have permission to post messages to the group. A few more details on why you weren't able to post:

 * You might have spelled or formatted the group name incorrectly.
 * The owner of the group may have removed this group.
 * You may need to join the group before receiving permission to post.
 * This group may not be open to posting.

If you have questions related to this or any other Google Group, visit the Help Center at https://support.google.com/a/apereo.org/bin/topic.py?topic=25838.

Thanks,

apereo.org admins

Reply all
Reply to author
Forward
0 new messages