Attempt at pull request for cas.personDirectory.principalAttribute

8 views
Skip to first unread message

Sam Hough

unread,
Feb 11, 2022, 4:55:03 AM2/11/22
to CAS Developer
Hi,

I'd like to have a go at providing a fix and automated test for this issue.


Anyone know if the original principal should be replaced by the persondir one or if it is a sorting issue?

 Any tips on if it should be a simple junit/unit test or puppet/integration test? Cross module (auth/personDirectory) so should be the latter?

One very minor thing, what is the coding standard for line continuation? Is that the local style? I've only ever used the rules from the original Sun doc https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html

Sorry if I should have been able to find out any of this from the docs.

Cheers

Sam

Reply all
Reply to author
Forward
0 new messages