Bug in ServicesManager cache (since 6.3)

[antoine m]

Hi,

I think there is a bug in the ServicesManager cache feature since version 6.3.

If i disable the automatic reload of services (cas.service-registry.schedule.enabled: false), the cache expire after 15mn (by default) and the cache is empty.

I can reproduce the problem in Oauth2 protocol : after 15mn, CAS fail to authorize any  legitimate service.

The  method servicesManager.getAllServicesOfType(OAuthRegisteredService.class) always return an empty collection because it query only the cache and not the ServiceRegistry source.

Regards,

Antoine

[Misagh]

Can you put together a test case that demonstrates the problem?

> --
> You received this message because you are subscribed to the Google Groups "CAS Developer" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to cas-dev+u...@apereo.org.
> To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-dev/07dd6859-df67-4c86-a8fd-327514093179n%40apereo.org.

[antoine m]

• application.yaml :

cas.service-registry.json.location: file:/etc/cas/config/services

cas.service-registry.json.watcher-enabled: false

cas.service-registry.schedule.enabled: false

• First request 

http://localhost:8080/oidc/authorize?response_type=code&client_id=oidc-authorization-code&redirect_uri=https://oidc-authorization-code&scope=openid%20alm

Redirect HTTP 302 => http://localhost:8080/login?service=http%3A%2F%2Flocalhost%3A8080%2Foauth2.0%2FcallbackAuthorize%3Fclient_id%3Doidc-authorization-code%26redirect_uri%3Dhttps%253A%252F%252Foidc-authorization-code%26response_type%3Dcode%26client_name%3DCasOAuthClient

in the log :

2021-10-22 12:39:34,205 DEBUG [org.apereo.cas.support.oauth.validator.authorization.BaseOAuth20AuthorizationRequestValidator] - <Locating registered service for client id [oidc-authorization-code]>

• 15mn later, same test

http://localhost:8080/oidc/authorize?response_type=code&client_id=oidc-authorization-code&redirect_uri=https://oidc-authorization-code&scope=openid%20alm

=> HTTP 401 Access Denied

in the log :

2021-10-22 12:54:19,208 WARN [org.apereo.cas.support.oauth.validator.authorization.BaseOAuth20AuthorizationRequestValidator] - <Registered service [oidc-authorization-code] is not found or is not authorized for access.>