# Review everything
* @somebody
# Review a specific technology
*.js @person
# Review a specific subproject
docs/* @anotherPerson
Hi Folks,A challenge that has been on my mind lately is code review.Code review is a key part of software development, having more eyes looking over the code helps reduce defects.However this only works if reviewers have time to review and interest the changes.In order to find a balance, allowing people to review what they have time to review and interest in, as well as getting all of the code reviewed.I purpose creating focused groups of reviewers, based on technologies and sub projects.Ideas on how how it could work:A CODEOWNERS file would be added to the project.
...
-0
1. Make the change. Ping the PR.
2. Wait X number of days, gently pinging the PR for feedback.
3. Merge after X expires.
Those who “own” an area may find energy, time and money to review; they know who they are. Putting their name down in a file doesn’t necessarily better either. They are watching the repo. They should be watching the repo. You generally want to watch stuff you “own” right? :) So you merge and if the owners/others find issues with your change, they’re welcomed back to submit yet another PR that fixes what they consider an improvement for a problem. Let them care, on their own.
In other words:
“You as a contributor may feel inclined to review something, anything, everything, or nothing. Do it as you like, on-demand, organically or in a process-oriented manner of your own design. Do what works for you. Do what you prefer. Provide feedback at all costs, in a timely fashion that works for you. We want to make progress. There is a window. We think it’s reasonable. We should try to fit in, but fret not if you can’t. There is always the next PR; there is always the next release. Keep calm and internalize this”.
Also as well intentioned as this may be, CODEOWNERS generally leads to code ownerships and perceptions of such for both the developers and the outside community. Beware.
--Misagh
--
You received this message because you are subscribed to the Google Groups "uPortal Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to uportal-dev...@apereo.org.
Visit this group at https://groups.google.com/a/apereo.org/group/uportal-dev/.
I nonetheless suspect it's solving problems that either aren't real or that we wouldn't have with better factoring the product into small Git repos for purpose-specific modules.
Also as well intentioned as this may be, CODEOWNERS generally leads to code ownerships and perceptions of such for both the developers and the outside community. Beware.
I like the way pull requests have historically worked, except that we should get a little speedier at responding to them.
None of us who work on Apereo uPortal do so full time. We tend to get pulled in other directions for days or occasionally a couple weeks. We have to be flexible.
I think we have project participants who skim uportal-dev@ but do not routinely hang out in GitHub looking for notifications. Jim Helwig jumps to mind but I doubt he is alone.
uportal-dev@ is a decent tool for talking about, well, developing uPortal. We should use it more.
Hypothesis: increasing the frequency of traffic on uPortal-dev@ about the Pull Requests will increase the discussion of the concepts in, the changes in, the purposes of the pull requests and will even increase the frequency of attention on the pull requests themselves.