Since cas 5.3.4, aup is doing an infinite loop.

[Curtis Ruck]

I'm trying to upgrade from 5.3.3 to 5.3.6 (so we can get opensaml 3.4.0 easily).

I am intentionally not using an AUP Repository (so each time cas restarts, the AUP is reshown).  So the DefaultAcceptableUsagePolicyRepository is involved.

When a user logs in, they get shown the AUP, they click accept, and then the AUP is reshown.

From what I can tell, the AcceptableUsagePolicySubmitAction submit's successfully, but the AcceptableUsagePolicyVerifyAction returns mustAccept, which triggers showing the AUP.

I'm guessing it was this commit that created this state: https://github.com/apereo/cas/commit/3dde1c31333f46591981cebf4fe7e314815d6c69  but don't understand the new webflow logic very well.

2018-11-30 14:25:54,713 DEBUG [XNIO-2 task-10] [org.springframework.webflow.mvc.servlet.FlowHandlerMapping] - <Mapping request with URI '/cas/login' to flow with id 'login'>

2018-11-30 14:25:54,714 DEBUG [XNIO-2 task-10] [org.springframework.webflow.executor.FlowExecutorImpl] - <Resuming flow execution with key .............>

2018-11-30 14:25:54,721 DEBUG [XNIO-2 task-10] [org.springframework.webflow.definition.registry.FlowDefinitionRegistryImpl] - <Getting FlowDefinition with id 'login'>

2018-11-30 14:25:54,721 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.impl.FlowExecutionImpl] - <Resuming in org.springframework.webflow.mvc.servlet.MvcExternalContext@41bd4db8>

2018-11-30 14:25:54,721 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Flow] - <Restoring [FlowVariable@556f7ef name = 'credential', valueFactory = [BeanFactoryVariableValueFactory@1293efd1 type = UsernamePasswordCredential]]>

2018-11-30 14:25:54,723 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.ViewState] - <Event 'submit' returned from view [ServletMvcView@68ae3dea view = org.thymeleaf.spring4.view.ThymeleafView@29f795d5]>

2018-11-30 14:25:54,723 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Transition] - <Executing [Transition@14d57054 on = submit, to = aupAcceptedAction]>

2018-11-30 14:25:54,723 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Transition] - <Exiting state 'acceptableUsagePolicyView'>

2018-11-30 14:25:54,723 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.ActionState] - <Entering state 'aupAcceptedAction' of flow 'login'>

2018-11-30 14:25:54,724 DEBUG [XNIO-2 task-10] [org.springframework.webflow.execution.ActionExecutor] - <Executing [EvaluateAction@1b85518c expression = acceptableUsagePolicySubmitAction, resultExpression = [null]]>

2018-11-30 14:25:54,724 DEBUG [XNIO-2 task-10] [org.springframework.webflow.execution.ActionExecutor] - <Executing org.apereo.cas.web.flow.AcceptableUsagePolicySubmitAction@9234db2>

2018-11-30 14:25:54,724 DEBUG [XNIO-2 task-10] [org.springframework.webflow.execution.ActionExecutor] - <Finished executing org.apereo.cas.web.flow.AcceptableUsagePolicySubmitAction@9234db2; result = success>

2018-11-30 14:25:54,724 DEBUG [XNIO-2 task-10] [org.springframework.webflow.execution.ActionExecutor] - <Finished executing [EvaluateAction@1b85518c expression = acceptableUsagePolicySubmitAction, resultExpression = [null]]; result = success>

2018-11-30 14:25:54,725 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Transition] - <Executing [Transition@76fac44b on = success, to = createTicketGrantingTicket]>

2018-11-30 14:25:54,725 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Transition] - <Exiting state 'aupAcceptedAction'>

2018-11-30 14:25:54,725 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.ActionState] - <Entering state 'createTicketGrantingTicket' of flow 'login'>

2018-11-30 14:25:54,725 DEBUG [XNIO-2 task-10] [org.springframework.webflow.execution.ActionExecutor] - <Executing [EvaluateAction@4742f229 expression = acceptableUsagePolicyVerifyAction, resultExpression = [null]]>

2018-11-30 14:25:54,726 DEBUG [XNIO-2 task-10] [org.springframework.webflow.execution.ActionExecutor] - <Executing org.apereo.cas.web.flow.AcceptableUsagePolicyVerifyAction@320ae84f>

2018-11-30 14:25:54,726 DEBUG [XNIO-2 task-10] [org.springframework.webflow.execution.ActionExecutor] - <Finished executing org.apereo.cas.web.flow.AcceptableUsagePolicyVerifyAction@320ae84f; result = mustAccept>

2018-11-30 14:25:54,726 DEBUG [XNIO-2 task-10] [org.springframework.webflow.execution.ActionExecutor] - <Finished executing [EvaluateAction@4742f229 expression = acceptableUsagePolicyVerifyAction, resultExpression = [null]]; result = mustAccept>

2018-11-30 14:25:54,726 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Transition] - <Executing [Transition@6a9ddd9a on = mustAccept, to = acceptableUsagePolicyView]>

2018-11-30 14:25:54,727 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Transition] - <Exiting state 'createTicketGrantingTicket'>

2018-11-30 14:25:54,727 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.ViewState] - <Entering state 'acceptableUsagePolicyView' of flow 'login'>

2018-11-30 14:25:54,730 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.impl.FlowExecutionImpl] - <Assigned key .............>

2018-11-30 14:25:54,731 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.ViewState] - <Rendering + [ServletMvcView@46e644d9 view = org.thymeleaf.spring4.view.ThymeleafView@29f795d5]>

2018-11-30 14:25:54,732 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.ViewState] - <  Flash scope = map[[empty]]>

2018-11-30 14:25:54,732 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.ViewState] - <  Messages = [DefaultMessageContext@7f48fcec sourceMessages = map[[null] -> list[[empty]]]]>

2018-11-30 14:25:54,750 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Transition] - <Completed transition execution.  As a result, the new state is 'acceptableUsagePolicyView' in flow 'login'>

2018-11-30 14:25:54,751 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Transition] - <Completed transition execution.  As a result, the new state is 'acceptableUsagePolicyView' in flow 'login'>

2018-11-30 14:25:54,751 DEBUG [XNIO-2 task-10] [org.springframework.webflow.engine.Transition] - <Completed transition execution.  As a result, the new state is 'acceptableUsagePolicyView' in flow 'login'>

[Curtis Ruck]

Nevermind, I found I had created my own in memory Repository, that didn't support the verify action.