Advice so I can fix a Duo 2FA / theme bug in CAS, thanks
13 views
Skip to first unread message
Chia-Ying Yang
Aug 16, 2021, 9:50:41 PM8/16/21
to CAS Community
Back again with another bug which I want to help fix, but don't know where to start. If anyone can offer any advice (not holding out much hope)...
When I override duo-security/casDuoLoginView.html, I find that CAS does not make use of it and still defaults to use the template in the default theme.
I recently helped fix a similar problem with the Logout page (https://github.com/apereo/cas/pull/5204 and 5208, ultimately fixed by Misagh), so I know the issue is the result of missing the service in the flow scope. Without the service in the flow scope, the theme resolver falls back to use templates in the default theme. I keep finding similar bugs, so I suspect this is a prevalent problem throughout the many modules of CAS.
Anyway, while debugging, I found that I cannot easily get the service as with logout, because Duo 2FA is in a subflow, so the requestContext does not have the service ID from which I can build a service. I can sort of find it buried in the main flow, but I don't have enough understanding of the webflow setup to know when and how to extract it.
Thanks in advance for any help.
When I override duo-security/casDuoLoginView.html, I find that CAS does not make use of it and still defaults to use the template in the default theme.
I recently helped fix a similar problem with the Logout page (https://github.com/apereo/cas/pull/5204 and 5208, ultimately fixed by Misagh), so I know the issue is the result of missing the service in the flow scope. Without the service in the flow scope, the theme resolver falls back to use templates in the default theme. I keep finding similar bugs, so I suspect this is a prevalent problem throughout the many modules of CAS.
Anyway, while debugging, I found that I cannot easily get the service as with logout, because Duo 2FA is in a subflow, so the requestContext does not have the service ID from which I can build a service. I can sort of find it buried in the main flow, but I don't have enough understanding of the webflow setup to know when and how to extract it.
Thanks in advance for any help.
Chia-Ying
Reply all
Reply to author
Forward
0 new messages