Link is broken in codelab.

[kenji matsuoka]

I found a mistake in codelab of CameraX.
https://codelabs.developers.google.com/codelabs/camerax-getting-started/#0
So, I clicked a "report a mistake".
However, I received the 404.

How can I send a mistake?

[Eric Ng]

Hi Kenji,

You can let us know here - what's the issue in the codelab? Thanks!

--
You received this message because you are subscribed to the Google Groups "Android CameraX Discussion Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to camerax-develop...@android.com.
To post to this group, send email to camerax-d...@android.com.
To view this discussion on the web visit https://groups.google.com/a/android.com/d/msgid/camerax-developers/f005a39a-cc02-47d0-a6de-70cb39113a12%40android.com.

--

-Eric Ng

[kenji matsuoka]

I found 2 mistakes。

1. We must to update Build.gradle as below in 3.Add the Gradle dependencies.

implementation 'androidx.appcompat:appcompat:1.1.0-alpha05'

Because,  androidx.appcompat:appcompat:1.0.2 is not working as LifecycleOwner.

2.allPermissionsGranted(): can more simply.

private fun allPermissionsGranted(): Boolean {
        return REQUIRED_PERMISSIONS.all {
            ContextCompat.checkSelfPermission(this, it) == PackageManager.PERMISSION_GRANTED
        }
}

[Eric Ng]

Thanks for reporting Kenji!

I've reported this issue internally (ID 133776671) - I can respond here once it's fixed/updated.

--
You received this message because you are subscribed to the Google Groups "Android CameraX Discussion Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to camerax-develop...@android.com.
To post to this group, send email to camerax-d...@android.com.

To view this discussion on the web visit https://groups.google.com/a/android.com/d/msgid/camerax-developers/edcad7ab-159c-4606-80b9-603216a958b1%40android.com.

--

-Eric Ng

[Eric Ng]

Hi Kenji,

Our team has fixed the errors and should appear live soon. Thanks!

--

-Eric Ng

[Alexandru Dragus]

Hello  all, great job on the group and app.

I don't think it makes seance to open a new thread so i will use this to report a possible mistake:

https://codelabs.developers.google.com/codelabs/camerax-getting-started#1

" Set up MainActivity.kt

1. Replace the code in MainActivity.kt, with this. It includes import statements, variables you will instantiate, functions you will implement, and constants.

        ...

import androidx.appcompat.app.AppCompatActivity
import android.os.Bundle
import android.Manifest
import android.content.pm.PackageManager

...

"

This does not have import com.example.cameraxapp thus resulting in an error for me.

Sorry if it's a false alert and i'm doing something wrong.

[Android CameraX Discussion Group]

Hello Alexandru,

Thanks for bringing this to our attention - we'll take a look and provide an update soon.

[Eric Ng]

Thanks Alexandru, I ran through the codelab and found a couple of issues. I did encounter an issue when trying to import com.example.cameraxapp. I filed an issue to track it at http://issuetracker.google.com/182909690 and cc'd you.

Thanks!

--

-Eric Ng

[Alexandru Dragus]

Thank you also for taking a step twirls improving the documentation.

Have a nice day.