Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Warning patrol

7 views
Skip to first unread message

Juergen Boemmels

unread,
Nov 20, 2003, 10:24:29 AM11/20/03
to Perl6 Internals
Hi,

from time to time i do a little warning patrol in parrot and configure
with --ccwarn=-Werror.
Only a few fixes in imcc are needed to compile warning-free, most of
them are unused parameters and variables.
I know IMCC is under heavy development right now so I will not comit
these fixes but only send them to the list as a suggestion.

bye
bö

warning.diff

Leopold Toetsch

unread,
Nov 20, 2003, 1:21:14 PM11/20/03
to Juergen Boemmels, perl6-i...@perl.org
Juergen Boemmels <boem...@physik.uni-kl.de> wrote:
> I know IMCC is under heavy development right now so I will not comit
> these fixes but only send them to the list as a suggestion.

Nethertheless I'd suggest to apply such patches[1] immediately[2]. It
could cause small rediffs[3] for people working on these files with
little impact. If one get hit she might consider to fix these warnings
in the first place next time ;-)

A clean running make not cluttered with tons of warnings gives a more
confidental feeling for the quality of the project and just looks
better.

> bye
> b=F6

[1] huge white-space-only changing fixes are not in that category
[2] the part in pbc.c was fixed, when I came along this file today
[3] :h diff helps in vim to achieve this. Emacs has for sure similar
possibilities.

leo

Jonathan Worthington

unread,
Nov 21, 2003, 9:45:24 PM11/21/03
to perl6-i...@perl.org
> A clean running make not cluttered with tons of warnings gives a more
> confidental feeling for the quality of the project and just looks
> better.
In the spirit of this, I attach a couple of patches that clear up some of
the many warnings on Win32. One of them is the long standing problem of
mixing optimization and debugging link flags, which results in a linker
warning under the VC++ linker.

The other removes various unreferenced variables and puts in some explicit
casts, which get rid of some warnings when compiling with VC++ (there's more
to go, but as the patch touches a fair few files I thought it best to send
it in tonight, as I don't know when I'll next get chance to hunt down any
more).

Jonathan

warningsfix.diff
linkfix.diff

Leopold Toetsch

unread,
Nov 22, 2003, 4:56:27 AM11/22/03
to Jonathan Worthington, perl6-i...@perl.org
Jonathan Worthington <jona...@jwcs.net> wrote:
> In the spirit of this, I attach a couple of patches that clear up some of
> the many warnings on Win32.

Thanks, applied.

> Jonathan

leo

Leopold Toetsch

unread,
Nov 22, 2003, 9:46:15 AM11/22/03
to Juergen Boemmels, perl6-i...@perl.org
Juergen Boemmels <boem...@physik.uni-kl.de> wrote:
> Only a few fixes in imcc are needed to compile warning-free, most of
> them are unused parameters and variables.

Applied. Thanks,

> bye
> b=F6

leo

0 new messages