libusb build broken due to structure member renaming
John Reynolds
hello, I've got a -current-related question to ask. akbeech forwarded me
his build log when trying to build the "linux" user-land libusb from the
port which I maintain (it is below). At first I said "impossible" because I'd
tested things thoroughly, but then noticed he was on a -current system. Digging
into things I see that sys/dev/usb/usb.h has had some commits lately that
renamed the usb structures. Things like "interface_index" went to
uai_interface_index, etc.
Question #1: are there plans to MFC these changes in the USB structures to
-stable in the near future?
Question #2: If not, is __FreeBSD_version >= 500030 the appropriate thing to
"key" off of in order to make a patch set for libusb so that it will compile
and work cleanly on a "fresh" -current?
(info obtained from
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-versions.html
)
If these changes are not going to be MFC'ed in the near future (i.e. for
4.6-RELEASE) then my tendency is to not put #ifdef flags all over the libusb
code testing for FreeBSD-current, but rather to locally patch the source if
make(1) can determine it's on a system with the 'new' structures. Comments?
-Jr
(please cc: as I don't subscribe directly to -current)
------- start of forwarded message -------
From: Beech Rintoul <akb...@anchoragerescue.org>
Subject: libusb build broken
To: joh...@reynoldsnet.org
Date: Sun, 24 Feb 2002 08:39:09 -0900
I,m getting the following when trying to compile libusb:
rm -f .libs/bsd.lo
cc -DHAVE_CONFIG_H -I. -I. -I. -O -pipe -Wall -c bsd.c -Wp,-MD,.deps/bsd.TPlo
-fPIC -DPIC -o .libs/bsd.lo
bsd.c: In function `usb_set_altinterface':
bsd.c:154: structure has no member named `interface_index'
bsd.c:155: structure has no member named `alt_no'
bsd.c: In function `usb_control_msg':
bsd.c:287: structure has no member named `request'
bsd.c:288: structure has no member named `request'
bsd.c:289: structure has no member named `request'
bsd.c:289: structure has no member named `request'
bsd.c:289: warning: left-hand operand of comma expression has no effect
bsd.c:290: structure has no member named `request'
bsd.c:290: structure has no member named `request'
bsd.c:290: warning: left-hand operand of comma expression has no effect
bsd.c:291: structure has no member named `request'
bsd.c:291: structure has no member named `request'
bsd.c:291: warning: left-hand operand of comma expression has no effect
bsd.c:293: structure has no member named `data'
bsd.c:294: structure has no member named `flags'
bsd.c:306: structure has no member named `request'
bsd.c:306: structure has no member named `request'
bsd.c:307: warning: control reaches end of non-void function
bsd.c: In function `usb_find_devices_on_bus':
bsd.c:324: structure has no member named `addr'
bsd.c:330: structure has no member named `devnames'
bsd.c:335: structure has no member named `devnames'
*** Error code 1
Stop in /usr/ports/devel/libusb/work/libusb-0.1.5.
*** Error code 1
My machine is a Celeron 500MHz runing -current (yesterday's build).
Beech
--
-------------------------------------------------------------------
Beech Rintoul - IT Manager - Instructor - akb...@anchoragerescue.org
/"\ ASCII Ribbon Campaign | Anchorage Gospel Rescue Mission
\ / - NO HTML/RTF in e-mail | P.O. Box 230510
X - NO Word docs in e-mail | Anchorage, AK 99523-0510
/ \ -----------------------------------------------------------------
------- end of forwarded message -------
--
John & Jennifer Reynolds joh...@reynoldsnet.org http://www.reynoldsnet.org/
Senior CAD Engineer, WCCG, Intel Corporation jrey...@sedona.ch.intel.com
Running FreeBSD since 2.1.5-RELEASE. FreeBSD: The Power to Serve!
"Unix is user friendly, it's just particular about the friends it chooses."
To Unsubscribe: send mail to majo...@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Bill Fenner
You could use http://people.freebsd.org/~fenner/__FreeBSD_version.html
to find an already-existing value of __FreeBSD_version to test based
on the date of the original change.
Bill