Error when installing module without Mercurial not clear

[Ivan Martinez]

Hello all,
I was trying to install mod_openid in Zotonic 0.8.1 with no success:

[ivanmr@localhost zotonic-0.8.1]$ bin/zotonic installmodule mod_openid
Getting module index
** Installing mod_openid ...
sh: hg: command not found
** mod_openid OK
cd deps/iconv && ./rebar compile
deps/z_logger/Makefile
make[1]: Entering directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/z_logger'
make[1]: Leaving directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/z_logger'
deps/gen_smtp/Makefile
make[1]: Entering directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/gen_smtp'
==> iconv (compile)
==> gen_smtp (compile)
make[1]: Leaving directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/gen_smtp'
deps/webzmachine/Makefile
make[1]: Entering directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/webzmachine'
==> webzmachine (get-deps)
==> webzmachine (compile)
make[1]: Leaving directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/webzmachine'
deps/mochiweb/Makefile
make[1]: Entering directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/mochiweb'
==> mochiweb (get-deps)
==> mochiweb (compile)
make[1]: Leaving directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/mochiweb'
deps/lager/Makefile
make[1]: Entering directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/lager'
./rebar get-deps
./rebar compile
==> lager (compile)
==> lager (get-deps)
make[1]: Leaving directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/deps/lager'
modules/mod_oauth/Makefile
make[1]: Entering directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/modules/mod_oauth'
make -C deps/erlang-oauth
make[2]: Entering directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/modules/mod_oauth/deps/erlang-oauth'
make[2]: Leaving directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/modules/mod_oauth/deps/erlang-oauth'
make[1]: Leaving directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/modules/mod_oauth'
Updating zotonic zotonic001
Update:'zoton...@localhost.localdomain'
There is no node with this name

I couldn't see what was wrong until I noticed the third output line, "sh: hg: command not found". I found this means I don't have Mercurial installed. Shouldn't the installation stop right here?. The fact it continues doing things and producing output lines makes it difficult to find where it failed.

Cheers,
Ivan Martinez

[Ivan Martinez]

I installed Mercurial and made another attempt, but this time it failed because I was missing git:

...
make[1]: Entering directory `/home/ivanmr/Documents/instalaciones/zotonic-0.8.1/priv/modules/mod_openid'
No erl_openid checkout. Command: git clone --depth 1 git://github.com/helllamer/erl_openid.git erl_openid
./build_deps: line 27: git: command not found
./build_deps: line 29: PWD: command not found
Failed to get erl_openid checkout into /erl_openid
...

Then I installed git and tried again, but now the problem is mod_openid folder is already created:

Getting module index
** Target path already exists: /home/ivanmr/Documents/instalaciones/zotonic-0.8.1/priv/modules/mod_openid

I deleted it and finally tried with success. It would be nice if it checked all the dependencies before doing anything.

Thank you,
Ivan Martinez

[Arjan Scherpenisse]

Totally agree; there is some sanity checking missing in the
installmodule command.

If you make an issue on github it might actually get fixed:
https://github.com/zotonic/zotonic/issues/new

cheers, Arjan

[Ivan Martinez]

https://github.com/zotonic/zotonic/issues/404

Thanks a lot,
Ivan Martinez

[Alain O'Dea]

Hi Ivan:

The fix is in master now :)  Thanks again for reporting this.

Best,
Alain