Error making module z_forum

[Rudi Angela]

Hi,

I need a forum so I downloaded the z_forum module by hand (as I have no hg installed) and put it in the zotonic/modules directory and then tried to rebuild Zotonic by calling 'make'. But I get this error on the z_forum module:

Recompile: modules/mod_zforum/mod_zforum

modules/mod_zforum/mod_zforum.erl:57: Warning: variable 'PostId' shadowed in 'fun'

Recompile: modules/mod_zforum/resources/resource_zforum

modules/mod_zforum/resources/resource_zforum.erl:22: can't find include lib "resource_html.hrl"

modules/mod_zforum/resources/resource_zforum.erl:24: Warning: function html/1 is unused

make: *** [erl] Error 1

Is the module broken?

Rudi

[Rudi Angela]

I guess you tested it with a Zotonic version prior to 0.9.

With version 0.9 there have been some hefty naming refactorings in the Zotonic code. E.g. 'resource' has been replaced by 'controller' in many module names. The include file 'resource_html.erl' (which is used by the forum module) has been renamed to 'controller_html_helper.hrl'. So that was causing the error when compiling the forum module. When I adapt the file 'resource_zforum.erl' to point to the new include file name it all compiles without problems.

Now I haven't yet tried to use the forum module, so I can't say if this is the only incompatibility brought about by Zotonic 0.9. I suggest you review the changes in 0.9 to assess the compatibility.

Rudi