Fix for Google Books titles

1 view
Skip to first unread message

Frank Bennett

unread,
May 14, 2010, 5:37:17 AM5/14/10
to zotero-dev
I have uploaded a patch and a fixed copy of the Google Books
translator to the Files area as Google+Books2.patch and Google
+Books2.js. I ran a diff against the Google+Books.js file already
uploaded by Rintze awhile ago, to address a separate issue; it looks
like, and I am assuming that, Rintze's version has already been
pushed, and that my patch incorporates his changes. If I'm mistaken
and that's not the case, please someone work out a merge between the
two versions.

Thanks,
Frank

--
You received this message because you are subscribed to the Google Groups "zotero-dev" group.
To post to this group, send email to zoter...@googlegroups.com.
To unsubscribe from this group, send email to zotero-dev+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/zotero-dev?hl=en.

Rintze Zelle

unread,
May 14, 2010, 7:01:59 AM5/14/10
to zotero-dev
On May 14, 11:37 am, Frank Bennett <biercena...@gmail.com> wrote:
> I am assuming that Rintze's version has already been pushed

It has: https://www.zotero.org/trac/changeset/6010

Rintze

Frank Bennett

unread,
May 26, 2010, 6:50:36 PM5/26/10
to zotero-dev
On May 14, 6:37 pm, Frank Bennett <biercena...@gmail.com> wrote:
> I have uploaded a patch and a fixed copy of the Google Books
> translator to the Files area as Google+Books2.patch and Google
> +Books2.js.  I ran a diff against the Google+Books.js file already
> uploaded by Rintze awhile ago, to address a separate issue; it looks
> like, and I am assuming that, Rintze's version has already been
> pushed, and that my patch incorporates his changes.  If I'm mistaken
> and that's not the case, please someone work out a merge between the
> two versions.

As Rintze indicates in his follow-on message, this patch is valid
against the current distributed version of the Google Books
translator.

Bump.


>
> Thanks,Frank

Dan Stillman

unread,
May 27, 2010, 1:29:03 PM5/27/10
to zoter...@googlegroups.com
On 5/26/10 6:50 PM, Frank Bennett wrote:
> On May 14, 6:37 pm, Frank Bennett<biercena...@gmail.com> wrote:
>
>> I have uploaded a patch and a fixed copy of the Google Books
>> translator to the Files area as Google+Books2.patch and Google
>> +Books2.js.
>>

Pushed.

Reply all
Reply to author
Forward
0 new messages