[PATCH] jart: new Limits tab

4 views
Skip to first unread message

Scott Parish

unread,
Dec 11, 2009, 9:26:42 PM12/11/09
to yaketyst...@googlegroups.com
Support for a new Limits control tab that will allow setting the
Y max or min. This is especially handy for cases where you have one
spike that is causing the graph to scale such that you can't see
the typical values.

jart: new Limits tab
0001-jart-new-Limits-tab.patch

srparish

unread,
Jan 1, 2010, 10:12:45 PM1/1/10
to yaketystats-devel
Any thoughts on this patch?

Thanks
sRp

>  0001-jart-new-Limits-tab.patch
> 7KViewDownload

Mark Plaksin

unread,
Jan 6, 2010, 1:01:47 PM1/6/10
to yaketyst...@googlegroups.com
srparish <srpa...@gmail.com> writes:

> Any thoughts on this patch?

Hi!

Thanks for the patch!

Sorry for the delay. Sorry for the spam on this list too. I thought
I'd set all of the YS lists so you had to join before posting but
somehow I missed -devel. Fixed now.

Sam (Mr. Jart) has looked at your patch and, I think, found one problem
which he thought could be resolved (--upper-limit and --lower-limit are
used elsewhere). I figured he'd whip out a resolution :) But there have
been holidays and work has been busy and we've been slower than we were
with YS.

Scott Parish

unread,
Jan 7, 2010, 11:06:59 PM1/7/10
to yaketyst...@googlegroups.com
Ah good to hear. Great work on YS and Jart! Really love the combination.

By the way is this the best way to get patches to you guys? I might
have a few more eventually

sRp

Sam Rowe

unread,
Jan 8, 2010, 9:07:19 AM1/8/10
to yaketyst...@googlegroups.com
Hi Scott,

Sorry it has taken me so long to reply.

If you manually set a limit and then use the drag tool, what happens?

I confess I only read (did not apply) your patch, but it looks like
those two would conflict.

Glad you're liking Jart. :)

Scott Parish

unread,
Jan 8, 2010, 9:20:56 AM1/8/10
to yaketyst...@googlegroups.com
No worries re time, I know how it goes with side projects.

If you manually set a limit that limit is held constant as you drag horizontally (dragging vertically has never done anything as far as I could tell). The limit is held until you clear it, at which point it goes back to the original behavior of automatically scaling.

sRp

Sam Rowe

unread,
Jan 8, 2010, 9:28:08 AM1/8/10
to yaketyst...@googlegroups.com
I'm surprised you don't get a syntax error for defining two max/mins.
I'll work on porting the patch to the latest version.

Have you messed with trunk at all?

Still trying to decide how to deal with sqlite. I hate the idea of
upgrading the schema.

On Fri, Jan 8, 2010 at 9:20 AM, Scott Parish <s...@srparish.net> wrote:
> No worries re time, I know how it goes with side projects.
>
> If you manually set a limit that limit is held constant as you drag horizontally (dragging vertically has never done anything as far as I could tell). The limit is held until you clear it, at which point it goes back to the original behavior of automatically scaling.
>
> sRp
>
> Sam Rowe <sam....@gmail.com> wrote:
>

Reply all
Reply to author
Forward
0 new messages