> xdo.h includes the name "class" which is a reserved keyword in c++. > This prevents including it in a C++ program: > extern "C" { > #include <xdo.h> > }
> g++ file.cpp > In file included from test.cpp:2:0: > /usr/include/xdo.h:530:37: error: expected ',' or '...' before 'class'
> please rename or remove the parameter.
I note that xdo.c already has the parameter re-named "_class" instead of "class", and it doesn't look to me like shifting the name of the parameter in xdo.h would change either the API or the ABI.
> xdo.h includes the name "class" which is a reserved keyword in c++. >> This prevents including it in a C++ program: >> extern "C" { >> #include <xdo.h> >> }
>> g++ file.cpp >> In file included from test.cpp:2:0: >> /usr/include/xdo.h:530:37: error: expected ',' or '...' before 'class'
>> please rename or remove the parameter.
> I note that xdo.c already has the parameter re-named "_class" instead of > "class", and it doesn't look to me like shifting the name of the parameter > in xdo.h would change either the API or the ABI.
> What do you think of the attached patch?
> Regards,
> --dkg
I swear I've fixed this like 30 times by now, my mind must be going! hah :)
Yeah shoot me a pull request or patch - otherwise I can hand patch it. FYI, in case I forgot to announce - the source repo lives here now: http://github.com/jordansissel/xdotool
