Re: SVN:(AG) [61602] Fixed wrong right-aligned text in HyperTreeList

[Frank Niessink]

Hi Andrea,

2009/8/4 <nor...@wxsite.net>:
> Fixed wrong right-aligned text in HyperTreeList

> - w = col_w - (image_w + wcheck + text_w + off_w + _MARGIN)
> + w = col_w - (image_w + wcheck + text_w + off_w + _MARGIN + 1)

Did you analyse the issue or did you just apply my patch? I'm asking
because although the '+ 1' fixed the issue for me, I'm not sure why
the original code didn't work. It looks right to me. It always makes
me feel bad when I'm changing code without really understanding what
I'm doing :-(

Thanks, Frank

[Frank Niessink]

2009/8/4 Frank Niessink <fr...@niessink.com>:

Oops, missed your response on wxPython-users, where you said:
"It looks correct to me, although I am not sure why sometimes there is
a 1-pixel offset... anyway, no need to create a ticket, I have applied
your fix in SVN. If someone else reports strange behaviours due to
this fix I'll take a deeper look at it."

I'll keep an eye out for text crossing column borders or misbehaving
in other creative ways :-)

Thanks again, Frank

[Andrea Gavana]

Hi Frank,

2009/8/4 Frank Niessink:

I have just applied your patch. A 1-pixel offset is a very small issue
for me: if it turns out that it is a problem, then I'll take a deeper
look at it... but right now is 22.30 and I can't possibly concentrate
on HyperTreeList :-D

Andrea.

"Imagination Is The Only Weapon In The War Against Reality."
http://xoomer.alice.it/infinity77/
http://thedoomedcity.blogspot.com/

[Frank Niessink]

2009/8/4 Andrea Gavana <andrea...@gmail.com>:

> I have just applied your patch. A 1-pixel offset is a very small issue
> for me: if it turns out that it is a problem, then I'll take a deeper
> look at it... but right now is 22.30 and I can't possibly concentrate
> on HyperTreeList :-D

I'm sorry, I try to be a pragmatic perfectionist, but I sometimes
forget about the pragmatic part :-)

Cheers, Frank