Assertions with treectrl sample on OSX

[houchins]

I am using widgets 2.9.4 on OSX, building with Cocoa.

When I run the treectrl sample, I get error assertions when it tries to create bitmap objects.  The bitmaps it tries to create are some 13x13 checkboxes, I think.  I have traced the problem to wxBitmapRefData::GetIconRef() in src/osx/core/bitmap.cpp line 586:

PicHandle pic = GetPictHandle() ;

The function GetPictHandle is not implemented, so returns a NULL handle value. That causes the following SetIconFamilyData call to not properly construct an icon object.

I found an old bitmap.cpp for Carbon posted on the net that implements a version of GetPictHandle. With some tweaking, my version seemed to work (at least quiet the assertions) and renders the checkbox images.  I have no idea if my fix is right.  If someone is interested, I can post it as a patch diff here.

[Stefan Csomor]

Hi

PICT is a QuickDraw Type which is not existing anymore on 64 bit at all, it has to be replaced 

Best,

Stefan

[houchins]

Hi

Does this mean a patch is imminent so that the assertion does not happen anymore?

[Stefan Csomor]

Hi

Does this mean a patch is imminent so that the assertion does not happen anymore?

please test with r72511

Thanks,

Stefan

[houchins]

Thanks for the patch.  But ... I am getting a compile error when integrating it:

../src/osx/core/bitmap.cpp: In member function ‘OpaqueIconRef* wxBitmapRefData::GetIconRef()’:

../src/osx/core/bitmap.cpp:464: error: ‘kIconServices1024PixelDataARGB’ was not declared in this scope

I found online that kIconServices1024PixelDataARGB is a new enum added for OS X 10.7 in CoreServices IconStorage.h, and it is in fact there on my system.

Ahhh ... we are building widgets using the  '.../SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6' setting because we intend our app to support 10.6.  Yes, I see, the 10.6 version of IconStorage.h does not have this enum value.  Seems like this could bite other developers, too.  Seems to me an #ifdef for 10.6 nees to be added to this patch around these lines of code.

Steve

[houchins]

I believe this will do it:

#if __MAC_OS_X_VERSION_MAX_ALLOWED > __MAC_10_6

            case 1024:

                dataType = kIconServices1024PixelDataARGB ;

                break;

#endif

[houchins]

Now that it compiles for me taking 10.6 into account, I am still getting the same assertion.  When I step through bitmap.cpp, my system executes the code inside #ifndef __LP64__, which leads to executing these lines (about line 618)

PicHandle pic = GetPictHandle() ;

SetIconFamilyData( iconFamily, 'PICT' , (Handle) pic ) ;

and the call to GetPictHandle is the problem since it returns null.

The assertion happens just below at this line:

wxCHECK_MSG( err == noErr, NULL, wxT("Error when constructing icon ref") );

So, my system doesn't have __LP64__ defined.  OS X 10.7.4

Steve

[Stefan Csomor]

I believe this will do it:

#if __MAC_OS_X_VERSION_MAX_ALLOWED > __MAC_10_6

            case 1024:

                dataType = kIconServices1024PixelDataARGB ;

                break;

#endif

yes, I've already added these lines in a subsequent patch

Thanks,

Stefan

[Stefan Csomor]

Hi

strange, I thought I still had the old QD code for 32 bit, generating PICTs, but it doesn't seem to be in there anymore, I'll check 

Thanks,

STefan 

[Stefan Csomor]

Hi

strange, I thought I still had the old QD code for 32 bit, generating PICTs, but it doesn't seem to be in there anymore, I'll check

I removed it when I removed 10.4 support, I'll complete the change

Thanks,

Stefan

[houchins]

I merged your Changeset 72515, which seems to be the removal of PICT you mention. There is still an issue with line 440 in bitmap.cpp:

     #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_7

This does not compile when using the 10.6 SDK because MAC_OS_X_VERSION_10_7 isn't defined in 10.6.  The line needs to be

    #if MAC_OS_X_VERSION_MAX_ALLOWED > MAC_OS_X_VERSION_10_6

OR your original #if needs to be fenced with #ifdef  MAC_OS_X_VERSION_10_7

With my change to this line, it builds fine and the treectrl sample no longer asserts.

Steve

[Stefan Csomor]

Hi

> #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_7
>
>This does not compile when using the 10.6 SDK because
>MAC_OS_X_VERSION_10_7 isn't defined in 10.6.

argh .. I forgot to update platform.h, I'm usually defining all systems
ahead, but didn't catch up ..

thanks for pointing this out,

Stefan