Re: #10939: provide .xrc support for loading wxDocChildFrameAny<> instances

9 views
Skip to first unread message

wxTrac

unread,
Oct 23, 2010, 11:31:17 AM10/23/10
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:2>

#10939: provide .xrc support for loading wxDocChildFrameAny<> instances
--------------------------------+-------------------------------------------
Reporter: wsu | Owner:
Type: enhancement | Status: confirmed
Priority: normal | Milestone: 3.0
Component: XRC | Version: 2.9-svn
Keywords: wxDocChildFrameAny | Blockedby: 8945
Patch: 1 | Blocking:
--------------------------------+-------------------------------------------
Changes (by vadz):

* status: new => confirmed
* blockedby: => 8945
* milestone: => 3.0


Comment:

This should probably be applied after dealing with #8945. We also need to
be able to test this code somehow, would be great to have some (even if
very simple) non-interactive unit tests for this and/or (but preferably
"and") a patch to the xrc sample showing this in action.

P.S. The patch doesn't quite apply any more, it's not difficult to apply
manually but if you work to enhance it further, could you please redo it
against the latest svn?

P.P.S. I wonder if any VC6 users could check if it compiles with this
compiler?


--
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:2>

wsu

unread,
Oct 23, 2010, 9:50:50 PM10/23/10
to wx-dev
I will try to revisit this after #8945 is resolved. I don't think I
see much point in doing anything with this until then.


On Oct 23, 11:31 am, "wxTrac" <nore...@wxsite.net> wrote:
> Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:2>
>
> #10939: provide .xrc support for loading wxDocChildFrameAny<> instances
> --------------------------------+------------------------------------------­-
>  Reporter:  wsu                 |       Owner:          
>      Type:  enhancement         |      Status:  confirmed
>  Priority:  normal              |   Milestone:  3.0      
> Component:  XRC                 |     Version:  2.9-svn  
>  Keywords:  wxDocChildFrameAny  |   Blockedby:  8945    
>     Patch:  1                   |    Blocking:          
> --------------------------------+------------------------------------------­-

wxTrac

unread,
Jun 16, 2013, 9:26:01 AM6/16/13
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:20>

#10939: provide .xrc support for loading wxDocChildFrameAny<> instances
--------------------------------+-------------------------------------------
Reporter: wsu | Owner:
Type: enhancement | Status: confirmed
Priority: normal | Milestone: 3.2
Component: XRC | Version: 2.9-svn
Keywords: wxDocChildFrameAny | Blockedby: 8945
Patch: 0 | Blocking:
--------------------------------+-------------------------------------------
Changes (by vadz):

* patch: 1 => 0
* blockedby: 8945, 8945, 8945, 8945, 8945, 8945, 8945, 8945, 8945, 8945,
8945, 8945, 8945, 8945, 8945, 8945, 8945,
8945, 8945 => 8945
* milestone: 3.0 => 3.2


Comment:

Unfortunately the patch needs to be modified to deal with the XRC
refactoring (i.e. the changes of r72727, see #10996). Could anybody
interested in this please do it?

I'm not going to have time to do it before 3.0 myself.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:20>

wxTrac

unread,
Jun 18, 2013, 10:26:30 PM6/18/13
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:23>

#10939: provide .xrc support for loading wxDocChildFrameAny<> instances
--------------------------------+-------------------------------------------
Reporter: wsu | Owner:
Type: enhancement | Status: confirmed
Priority: normal | Milestone: 3.2
Component: XRC | Version: 2.9-svn
Keywords: wxDocChildFrameAny | Blockedby: 8945, 8945
Patch: 0 | Blocking:
--------------------------------+-------------------------------------------

Comment(by wsu):

I have posted an updated patch that will run with r74246. However, it
still doesn't do anything about tests or samples.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:23>

wxTrac

unread,
Jun 29, 2013, 8:57:10 PM6/29/13
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:24>

#10939: provide .xrc support for loading wxDocChildFrameAny<> instances
--------------------------------+-------------------------------------------
Reporter: wsu | Owner:
Type: enhancement | Status: confirmed
Priority: normal | Milestone: 3.2
Component: XRC | Version: 2.9-svn
Keywords: wxDocChildFrameAny | Blockedby: 8945, 8945
Patch: 0 | Blocking:
--------------------------------+-------------------------------------------

Comment(by wsu):

I have added a patch that modifies the docview sample to demonstrate use
of LoadDocChildFrameAny().


--
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:24>

wxTrac

unread,
Jun 29, 2013, 9:39:14 PM6/29/13
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:25>

#10939: provide .xrc support for loading wxDocChildFrameAny<> instances
--------------------------------+-------------------------------------------
Reporter: wsu | Owner:
Type: enhancement | Status: confirmed
Priority: normal | Milestone: 3.2
Component: XRC | Version: 2.9-svn
Keywords: wxDocChildFrameAny | Blockedby: 8945, 8945
Patch: 0 | Blocking:
--------------------------------+-------------------------------------------

Comment(by wsu):

I forgot to state in the previous comment that the changes to the docview
sample add dependencies on

wxmsw29u[d]_xrc.lib
wxmsw29u[d]_html.lib
wxmsw29u[d]_adv.lib
wxbase29u[d]_xml.lib

The .vcproj file says not to edit it, so I didn't include that in the
patch. (I did verify that adding those libs to the .vcproj gave me a
functioning sample.)

I apologize for leaving some of the work undone, but I don't know how to
correctly add libs to the project, much less how to add them to the other
OS versions.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:25>

wxTrac

unread,
Jul 10, 2013, 8:26:23 AM7/10/13
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:26>

#10939: provide .xrc support for loading wxDocChildFrameAny<> instances
--------------------------------+-------------------------------------------
Reporter: wsu | Owner:
Type: enhancement | Status: confirmed
Priority: normal | Milestone: 3.2
Component: XRC | Version: 2.9-svn
Keywords: wxDocChildFrameAny | Blockedby: 8945
Patch: 0 | Blocking:
--------------------------------+-------------------------------------------
Changes (by vadz):

* blockedby: 8945, 8945 => 8945


Comment:

To add the libraries `docview.bkl` needs to be edited and `bakefile_gen`
reran but I can do it.

OTOH I really don't have to actually test it, could anybody please do it
and provide feedback here?

TIA!


--
Ticket URL: <http://trac.wxwidgets.org/ticket/10939#comment:26>
Reply all
Reply to author
Forward
0 new messages