Received: by 10.216.241.9 with SMTP id f9mr914628wer.5.1343759289677;
        Tue, 31 Jul 2012 11:28:09 -0700 (PDT)
X-BeenThere: wx-dev@googlegroups.com
Received: by 10.180.78.166 with SMTP id c6ls3175347wix.4.canary; Tue, 31 Jul
 2012 11:28:08 -0700 (PDT)
Received: by 10.180.106.3 with SMTP id gq3mr637402wib.1.1343759287995;
        Tue, 31 Jul 2012 11:28:07 -0700 (PDT)
Received: by 10.180.106.3 with SMTP id gq3mr637401wib.1.1343759287985;
        Tue, 31 Jul 2012 11:28:07 -0700 (PDT)
Return-Path: <nore...@wxsite.net>
Received: from riobu.com (riobu.com. [85.234.147.122])
        by gmr-mx.google.com with ESMTP id hm1si173338wib.3.2012.07.31.11.28.07;
        Tue, 31 Jul 2012 11:28:07 -0700 (PDT)
Received-SPF: neutral (google.com: 85.234.147.122 is neither permitted nor denied by best guess record for domain of nore...@wxsite.net) client-ip=85.234.147.122;
Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.234.147.122 is neither permitted nor denied by best guess record for domain of nore...@wxsite.net) smtp.mail=nore...@wxsite.net
Received: from riobu.com (localhost [127.0.0.1])
	by riobu.com (Postfix) with ESMTP id D8396ABF87F2
	for <wx-dev@googlegroups.com>; Tue, 31 Jul 2012 11:28:07 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: "wxTrac" <nore...@wxsite.net>
X-Trac-Version: 0.11.5
Precedence: bulk
Cc: wx-dev@googlegroups.com
Auto-Submitted: auto-generated
X-Mailer: Trac 0.11.5, by Edgewall Software
X-Trac-Project: wxWidgets
Date: Tue, 31 Jul 2012 18:28:07 -0000
Reply-To: wx-dev@googlegroups.com
X-URL: http://trac.wxwidgets.org/
Subject: Re: #14544: wxFileSystemWatcher: More fixes
X-Trac-Ticket-URL: http://trac.wxwidgets.org/ticket/14544#comment:6
Message-ID: <053.6e00dc6f2e33ceb1fc045545de61221e@wxsite.net>
References: <044.699bf46f9089b9d88a6a76155b9885f2@wxsite.net>
X-Trac-Ticket-ID: 14544
In-Reply-To: <044.699bf46f9089b9d88a6a76155b9885f2@wxsite.net>

Ticket URL: <http://trac.wxwidgets.org/ticket/14544#comment:6>

#14544: wxFileSystemWatcher: More fixes
---------------------------------+------------------------------------------
 Reporter:  dghart               |       Owner:                            =
                     =

     Type:  defect               |      Status:  new                       =
                     =

 Priority:  normal               |   Milestone:  2.9.5                     =
                     =

Component:  base                 |     Version:  2.9-svn                   =
                     =

 Keywords:  wxFileSystemWatcher  |   Blockedby:  14488, 14488, 14488, 14490=
, 14542, 14542, 14543
    Patch:  1                    |    Blocking:                            =
                     =

---------------------------------+------------------------------------------

Comment(by dghart):

 Replying to [comment:5 vadz]:
 > I'll try to look at this series soon although to be honest I'm a bit
 intimidated. It might be better to redo a series of patches
 (`0001-Something`, `0002-SomethingElse`, ...) if parts of the later
 patches change something done by the earlier ones as this should make
 reviewing them simpler.
 >
 > I.e. perhaps it would be more convenient for both of us if you created a
 new branch, cherry pick all your commits there and used `git rebase -i` to
 reorganize them in the optimal way and then just used `git format-patch`?
 >
 > If not, I'll try to look at this stuff starting from #14488 on Thursday.

 I tried to keep the patches clean and simple. With the exception of the
 unit-test, there are only minor 'internal' reversions in the series; by
 minor I mean just a couple of lines. So I think you'll find it easier that
 you expect.

 If not, I'll redo them differently.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/14544#comment:6>