Received: by 10.216.113.70 with SMTP id z48mr932760weg.6.1348599305778;
        Tue, 25 Sep 2012 11:55:05 -0700 (PDT)
X-BeenThere: wx-dev@googlegroups.com
Received: by 10.216.206.216 with SMTP id l66ls991458weo.4.gmail; Tue, 25 Sep
 2012 11:55:04 -0700 (PDT)
Received: by 10.180.106.102 with SMTP id gt6mr3594444wib.0.1348599304042;
        Tue, 25 Sep 2012 11:55:04 -0700 (PDT)
Received: by 10.180.106.102 with SMTP id gt6mr3594443wib.0.1348599304030;
        Tue, 25 Sep 2012 11:55:04 -0700 (PDT)
Return-Path: <nore...@wxsite.net>
Received: from riobu.com (riobu.com. [85.234.147.122])
        by gmr-mx.google.com with ESMTP id k11si1687149wiv.0.2012.09.25.11.55.03;
        Tue, 25 Sep 2012 11:55:04 -0700 (PDT)
Received-SPF: neutral (google.com: 85.234.147.122 is neither permitted nor denied by best guess record for domain of nore...@wxsite.net) client-ip=85.234.147.122;
Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.234.147.122 is neither permitted nor denied by best guess record for domain of nore...@wxsite.net) smtp.mail=nore...@wxsite.net
Received: from riobu.com (localhost [127.0.0.1])
	by riobu.com (Postfix) with ESMTP id DBF93ABF83A2;
	Tue, 25 Sep 2012 11:55:03 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: "wxTrac" <nore...@wxsite.net>
X-Trac-Version: 0.11.5
Precedence: bulk
Cc: wx-dev@googlegroups.com
Auto-Submitted: auto-generated
X-Mailer: Trac 0.11.5, by Edgewall Software
X-Trac-Project: wxWidgets
Date: Tue, 25 Sep 2012 18:55:03 -0000
Reply-To: wx-dev@googlegroups.com
X-URL: http://trac.wxwidgets.org/
Subject: Re: #14697: Native drag image support (MSW)
X-Trac-Ticket-URL: http://trac.wxwidgets.org/ticket/14697#comment:1
Message-ID: <053.0e0552e94b0699c80903883b673208fb@wxsite.net>
References: <044.02369b663532f57970a13a6bfb4b3939@wxsite.net>
X-Trac-Ticket-ID: 14697
In-Reply-To: <044.02369b663532f57970a13a6bfb4b3939@wxsite.net>

Ticket URL: <http://trac.wxwidgets.org/ticket/14697#comment:1>

#14697: Native drag image support (MSW)
-----------------------------------------------+----------------------------
 Reporter:  PeterO                             |       Owner:           =

     Type:  enhancement                        |      Status:  confirmed
 Priority:  low                                |   Milestone:           =

Component:  wxMSW                              |     Version:  2.9.4    =

 Keywords:  dnd drag image native docs-needed  |   Blockedby:           =

    Patch:  1                                  |    Blocking:           =

-----------------------------------------------+----------------------------
Changes (by vadz):

  * keywords:  dnd drag image native =3D> dnd drag image native docs-needed
  * priority:  normal =3D> low
  * status:  new =3D> confirmed


Comment:

 Thanks, this would be useful to have but we really need some documentation
 and an example of using this in the dnd sample, otherwise nobody would
 even know about it.

 I also wonder about the whole idea of "aux data" -- what does it all mean
 and what is it for? It would be nice to have some more in depth
 explanation of it in the comments.

 Also, a couple of minor remarks:

  1. Why does `wxDropSourceHelper` need to be public? AFAICS it's only used
 in the implementation code.
  1. It would be better to avoid including `shlobj.h` from a public header,
 forward declaring `IDropTargetHelper` should be enough.
  1. `DATASTORAGES` is a really bad name, we don't use all caps for the
 type names.
  1. It should also use `wxVector<>` instead of `std::vector<>` (nothing in
 the rest of the code should need any changes).
  1. It seems inconsistent to pass an image to `CreateDragImageFromImage()`
 but not a window to `CreateDragImageFromWindow()`.
  1. It also looks like it `CreateDragImageFromImage()` should take a
 `wxCursor` in the first place because it already is a `wxBitmap` with a
 hot spot. Using `wxImage` here is rather strange because if you already
 have a `wxCursor`, `wxIcon` or `wxBitmap` you'd need to convert it to
 `wxImage` only to convert it back in this code.
  1. It would be nice to use style consistent with the rest of the files
 you modify, i.e.
   * Put spaces around `if` conditions.
   * Avoid blank single line comments.

 Thanks in advance!


--
Ticket URL: <http://trac.wxwidgets.org/ticket/14697#comment:1>