Received: by 10.180.74.79 with SMTP id r15mr1129826wiv.4.1353261476233;
        Sun, 18 Nov 2012 09:57:56 -0800 (PST)
X-BeenThere: wx-dev@googlegroups.com
Received: by 10.180.8.5 with SMTP id n5ls1048079wia.15.gmail; Sun, 18 Nov 2012
 09:57:55 -0800 (PST)
Received: by 10.180.93.6 with SMTP id cq6mr1126756wib.2.1353261475241;
        Sun, 18 Nov 2012 09:57:55 -0800 (PST)
Received: by 10.180.93.6 with SMTP id cq6mr1126755wib.2.1353261475231;
        Sun, 18 Nov 2012 09:57:55 -0800 (PST)
Return-Path: <nore...@wxsite.net>
Received: from riobu.com (riobu.com. [85.234.147.122])
        by gmr-mx.google.com with ESMTP id eu17si377669wid.0.2012.11.18.09.57.55;
        Sun, 18 Nov 2012 09:57:55 -0800 (PST)
Received-SPF: neutral (google.com: 85.234.147.122 is neither permitted nor denied by best guess record for domain of nore...@wxsite.net) client-ip=85.234.147.122;
Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.234.147.122 is neither permitted nor denied by best guess record for domain of nore...@wxsite.net) smtp.mail=nore...@wxsite.net
Received: from riobu.com (localhost [127.0.0.1])
	by riobu.com (Postfix) with ESMTP id E9B03ABF8C86
	for <wx-dev@googlegroups.com>; Sun, 18 Nov 2012 09:57:54 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: "wxTrac" <nore...@wxsite.net>
X-Trac-Version: 0.11.5
Precedence: bulk
Cc: wx-dev@googlegroups.com
Auto-Submitted: auto-generated
X-Mailer: Trac 0.11.5, by Edgewall Software
X-Trac-Project: wxWidgets
Date: Sun, 18 Nov 2012 17:57:54 -0000
Reply-To: wx-dev@googlegroups.com
X-URL: http://trac.wxwidgets.org/
Subject: Re: #14834: wxFileSystemWatcher: Add wxFSW_EVENT_UNMOUNT flag for
 inotify's IN_UNMOUNT
X-Trac-Ticket-URL: http://trac.wxwidgets.org/ticket/14834#comment:2
Message-ID: <053.015d76a0b6eea23a514b1ef354916bc5@wxsite.net>
References: <044.d421ae490956d0fc87b22ee03f376de1@wxsite.net>
X-Trac-Ticket-ID: 14834
In-Reply-To: <044.d421ae490956d0fc87b22ee03f376de1@wxsite.net>

Ticket URL: <http://trac.wxwidgets.org/ticket/14834#comment:2>

#14834: wxFileSystemWatcher: Add wxFSW_EVENT_UNMOUNT flag for inotify's IN_=
UNMOUNT
-----------------------------------------------------+----------------------
 Reporter:  dghart                                   |       Owner:         =

     Type:  enhancement                              |      Status:  new    =

 Priority:  normal                                   |   Milestone:  3.0    =

Component:  base                                     |     Version:  2.9-svn
 Keywords:  wxFileSystemWatcher wxFSW_EVENT_UNMOUNT  |   Blockedby:         =

    Patch:  1                                        |    Blocking:         =

-----------------------------------------------------+----------------------

Comment(by dghart):

 I have no way of testing OS X. The code contains nflags &=3D ~NOTE_REVOKE,
 so I suspect it does nothing.

 On ejecting a CD in winXP, wxIOCPThread::ProcessNativeEvents received no
 event of any sort. (It's possible that being in a virtualbox guest
 affected this, but XP itself did notice the CD and its removal.)

 I've also now tested without the patch in wxGTK and found the
 errors/warnings code is broken. Prior to the r72961 change, it failed as
 GetErrorDescription() called Watcher2NativeFlags() and got back
 IN_ALL_EVENTS. This isn't in the list of known errors, so
 GetErrorDescription() asserted. Later GetFSWEventChangeTypeName() asserted
 too as it doesn't handle wxFSW_EVENT_WARNING or wxFSW_EVENT_ERROR. Since
 r72961 there are similar problems. These are fixed in errors.diff, which
 is needed whatever the IN_UNMOUNT decision.

 I've redone unmount.diff to apply over errors.diff, and also fixed the
 doc.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/14834#comment:2>