                                                                                                                                                                                                                                                                
Received-SPF: pass (google.com: domain of stephanv...@gmail.com designates 209.85.210.180 as permitted sender) client-ip=209.85.210.180;
MIME-Version: 1.0
Date: Sun, 14 Oct 2012 20:12:34 +0200
Message-ID: <CAJUTaS2wint5V2BMnVQkAJJ8UC2MttunKLAPVjN-S8VFKwK...@mail.gmail.com>
Subject: [PATCH] Inconsistent naming of optional features webview-ie and
 webview-webkit in configure
From: Stephan van den Akker <stephanv...@gmail.com>
To: wx-dev@googlegroups.com
Content-Type: multipart/mixed; boundary=14dae934068183bfd304cc08dd87

--14dae934068183bfd304cc08dd87
Content-Type: multipart/alternative; boundary=14dae934068183bfcd04cc08dd85

--14dae934068183bfcd04cc08dd85
Content-Type: text/plain; charset=ISO-8859-1

Hi, all!

I noticed today that:

configure --help

lists among its optional features:

  --enable-webview_webkit use wxWebView WebKit backend
  --enable-webview_ie     use wxWebView IE backend (Win32 only)

However, at present disabling these features requires the use of:

  --disable-webviewwebkit
  --disable-webviewie

This is inconsistent with the help information given by configure.

The attachment contains a proposed patch to make configure accept the same
options as suggested in it's help text.

Licence statement:
This contribution and all future contributions to wxWidgets, unless stated
otherwise, are licensed under the "wxWindows Licence" and the "wxWidgets
Licence".

Stephan van den Akker
Nijmegen
the Netherlands

--14dae934068183bfcd04cc08dd85
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi, all!<br><br>I noticed today that:<br><br>configure --help <br><br>lists=
 among its optional features:<br><br>=A0 --enable-webview_webkit use wxWebV=
iew WebKit backend<br>=A0 --enable-webview_ie=A0=A0=A0=A0 use wxWebView IE =
backend (Win32 only)<br>
=A0 <br>However, at present disabling these features requires the use of:<b=
r><br>=A0 --disable-webviewwebkit<br>=A0 --disable-webviewie<br>=A0 <br>Thi=
s is inconsistent with the help information given by configure.<br><br>The =
attachment contains a proposed patch to make configure accept the same opti=
ons as suggested in it&#39;s help text.<br>
<br>Licence statement:<br>This contribution and all future contributions to=
 wxWidgets, unless stated otherwise, are licensed under the &quot;wxWindows=
 Licence&quot; and the &quot;wxWidgets Licence&quot;.<br><br>Stephan van de=
n Akker<br>
Nijmegen<br>the Netherlands<br>

--14dae934068183bfcd04cc08dd85--
--14dae934068183bfd304cc08dd87
Content-Type: application/octet-stream; name="webview.svndiff"
Content-Disposition: attachment; filename="webview.svndiff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_h8agyht30

SW5kZXg6IGNvbmZpZ3VyZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjb25maWd1cmUJKHJldmlzaW9uIDcyNjc0
KQorKysgY29uZmlndXJlCSh3b3JraW5nIGNvcHkpCkBAIC0xMzYwLDcgKzEzNjAsNyBAQAogZW5h
YmxlX2FjY2Vzc2liaWxpdHkKIGVuYWJsZV91aWFjdGlvbnNpbQogZW5hYmxlX2RjdHJhbnNmb3Jt
Ci1lbmFibGVfd2Vidmlld3dlYmtpdAorZW5hYmxlX3dlYnZpZXdfd2Via2l0CiBlbmFibGVfcGFs
ZXR0ZQogZW5hYmxlX2ltYWdlCiBlbmFibGVfZ2lmCkBAIC0xMzc1LDcgKzEzNzUsNyBAQAogZW5h
YmxlX293bmVyZHJhd24KIGVuYWJsZV91eHRoZW1lCiBlbmFibGVfd3hkaWIKLWVuYWJsZV93ZWJ2
aWV3aWUKK2VuYWJsZV93ZWJ2aWV3X2llCiBlbmFibGVfYXV0b2lkbWFuCiBlbmFibGVfbGFyZ2Vm
aWxlCiBlbmFibGVfZ3RrdGVzdApAQCAtMTU0MzgsMjUgKzE1NDM4LDI1IEBACiAgICAgICAgICAg
ICAgIGZpCiAgICAgICAgICAgZmkKIAotICAgICAgICAgIHsgJGFzX2VjaG8gIiRhc19tZToke2Fz
X2xpbmVuby0kTElORU5PfTogY2hlY2tpbmcgZm9yIC0tJHtlbmFibGVzdHJpbmc6LWVuYWJsZX0t
d2Vidmlld3dlYmtpdCIgPiY1Ci0kYXNfZWNob19uICJjaGVja2luZyBmb3IgLS0ke2VuYWJsZXN0
cmluZzotZW5hYmxlfS13ZWJ2aWV3d2Via2l0Li4uICIgPiY2OyB9Ci0gICAgICAgICAgIyBDaGVj
ayB3aGV0aGVyIC0tZW5hYmxlLXdlYnZpZXd3ZWJraXQgd2FzIGdpdmVuLgotaWYgdGVzdCAiJHtl
bmFibGVfd2Vidmlld3dlYmtpdCtzZXR9IiA9IHNldDsgdGhlbiA6Ci0gIGVuYWJsZXZhbD0kZW5h
YmxlX3dlYnZpZXd3ZWJraXQ7CisgICAgICAgICAgeyAkYXNfZWNobyAiJGFzX21lOiR7YXNfbGlu
ZW5vLSRMSU5FTk99OiBjaGVja2luZyBmb3IgLS0ke2VuYWJsZXN0cmluZzotZW5hYmxlfS13ZWJ2
aWV3X3dlYmtpdCIgPiY1CiskYXNfZWNob19uICJjaGVja2luZyBmb3IgLS0ke2VuYWJsZXN0cmlu
ZzotZW5hYmxlfS13ZWJ2aWV3X3dlYmtpdC4uLiAiID4mNjsgfQorICAgICAgICAgICMgQ2hlY2sg
d2hldGhlciAtLWVuYWJsZS13ZWJ2aWV3X3dlYmtpdCB3YXMgZ2l2ZW4uCitpZiB0ZXN0ICIke2Vu
YWJsZV93ZWJ2aWV3X3dlYmtpdCtzZXR9IiA9IHNldDsgdGhlbiA6CisgIGVuYWJsZXZhbD0kZW5h
YmxlX3dlYnZpZXdfd2Via2l0OwogICAgICAgICAgICAgICAgICAgICAgICAgICBpZiB0ZXN0ICIk
ZW5hYmxldmFsIiA9IHllczsgdGhlbgotICAgICAgICAgICAgICAgICAgICAgICAgICAgIHd4X2N2
X3VzZV93ZWJ2aWV3d2Via2l0PSd3eFVTRV9XRUJWSUVXX1dFQktJVD15ZXMnCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgd3hfY3ZfdXNlX3dlYnZpZXdfd2Via2l0PSd3eFVTRV9XRUJWSUVX
X1dFQktJVD15ZXMnCiAgICAgICAgICAgICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB3eF9jdl91c2Vfd2Vidmlld3dlYmtpdD0nd3hVU0VfV0VCVklFV19X
RUJLSVQ9bm8nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgd3hfY3ZfdXNlX3dlYnZpZXdf
d2Via2l0PSd3eFVTRV9XRUJWSUVXX1dFQktJVD1ubycKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgZmkKIAogZWxzZQogCi0gICAgICAgICAgICAgICAgICAgICAgICAgIHd4X2N2X3VzZV93ZWJ2
aWV3d2Via2l0PSd3eFVTRV9XRUJWSUVXX1dFQktJVD0keydERUZBVUxUX3d4VVNFX1dFQlZJRVdf
V0VCS0lUIjotJGRlZmF1bHR2YWx9IgorICAgICAgICAgICAgICAgICAgICAgICAgICB3eF9jdl91
c2Vfd2Vidmlld193ZWJraXQ9J3d4VVNFX1dFQlZJRVdfV0VCS0lUPSR7J0RFRkFVTFRfd3hVU0Vf
V0VCVklFV19XRUJLSVQiOi0kZGVmYXVsdHZhbH0iCiAKIGZpCiAKIAotICAgICAgICAgIGV2YWwg
IiR3eF9jdl91c2Vfd2Vidmlld3dlYmtpdCIKKyAgICAgICAgICBldmFsICIkd3hfY3ZfdXNlX3dl
YnZpZXdfd2Via2l0IgogCiAgICAgICAgICAgaWYgdGVzdCB4IiRlbmFibGVzdHJpbmciID0geGRp
c2FibGU7IHRoZW4KICAgICAgICAgICAgIGlmIHRlc3QgJHd4VVNFX1dFQlZJRVdfV0VCS0lUID0g
bm87IHRoZW4KQEAgLTE2MTAyLDI1ICsxNjEwMiwyNSBAQAogICAgICAgICAgICAgICBmaQogICAg
ICAgICAgIGZpCiAKLSAgICAgICAgICB7ICRhc19lY2hvICIkYXNfbWU6JHthc19saW5lbm8tJExJ
TkVOT306IGNoZWNraW5nIGZvciAtLSR7ZW5hYmxlc3RyaW5nOi1lbmFibGV9LXdlYnZpZXdpZSIg
PiY1Ci0kYXNfZWNob19uICJjaGVja2luZyBmb3IgLS0ke2VuYWJsZXN0cmluZzotZW5hYmxlfS13
ZWJ2aWV3aWUuLi4gIiA+JjY7IH0KLSAgICAgICAgICAjIENoZWNrIHdoZXRoZXIgLS1lbmFibGUt
d2Vidmlld2llIHdhcyBnaXZlbi4KLWlmIHRlc3QgIiR7ZW5hYmxlX3dlYnZpZXdpZStzZXR9IiA9
IHNldDsgdGhlbiA6Ci0gIGVuYWJsZXZhbD0kZW5hYmxlX3dlYnZpZXdpZTsKKyAgICAgICAgICB7
ICRhc19lY2hvICIkYXNfbWU6JHthc19saW5lbm8tJExJTkVOT306IGNoZWNraW5nIGZvciAtLSR7
ZW5hYmxlc3RyaW5nOi1lbmFibGV9LXdlYnZpZXdfaWUiID4mNQorJGFzX2VjaG9fbiAiY2hlY2tp
bmcgZm9yIC0tJHtlbmFibGVzdHJpbmc6LWVuYWJsZX0td2Vidmlld19pZS4uLiAiID4mNjsgfQor
ICAgICAgICAgICMgQ2hlY2sgd2hldGhlciAtLWVuYWJsZS13ZWJ2aWV3X2llIHdhcyBnaXZlbi4K
K2lmIHRlc3QgIiR7ZW5hYmxlX3dlYnZpZXdfaWUrc2V0fSIgPSBzZXQ7IHRoZW4gOgorICBlbmFi
bGV2YWw9JGVuYWJsZV93ZWJ2aWV3X2llOwogICAgICAgICAgICAgICAgICAgICAgICAgICBpZiB0
ZXN0ICIkZW5hYmxldmFsIiA9IHllczsgdGhlbgotICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHd4X2N2X3VzZV93ZWJ2aWV3aWU9J3d4VVNFX1dFQlZJRVdfSUU9eWVzJworICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHd4X2N2X3VzZV93ZWJ2aWV3X2llPSd3eFVTRV9XRUJWSUVXX0lFPXll
cycKICAgICAgICAgICAgICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHd4X2N2X3VzZV93ZWJ2aWV3aWU9J3d4VVNFX1dFQlZJRVdfSUU9bm8nCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgd3hfY3ZfdXNlX3dlYnZpZXdfaWU9J3d4VVNFX1dFQlZJRVdf
SUU9bm8nCiAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpCiAKIGVsc2UKIAotICAgICAgICAg
ICAgICAgICAgICAgICAgICB3eF9jdl91c2Vfd2Vidmlld2llPSd3eFVTRV9XRUJWSUVXX0lFPSR7
J0RFRkFVTFRfd3hVU0VfV0VCVklFV19JRSI6LSRkZWZhdWx0dmFsfSIKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgd3hfY3ZfdXNlX3dlYnZpZXdfaWU9J3d4VVNFX1dFQlZJRVdfSUU9JHsnREVG
QVVMVF93eFVTRV9XRUJWSUVXX0lFIjotJGRlZmF1bHR2YWx9IgogCiBmaQogCiAKLSAgICAgICAg
ICBldmFsICIkd3hfY3ZfdXNlX3dlYnZpZXdpZSIKKyAgICAgICAgICBldmFsICIkd3hfY3ZfdXNl
X3dlYnZpZXdfaWUiCiAKICAgICAgICAgICBpZiB0ZXN0IHgiJGVuYWJsZXN0cmluZyIgPSB4ZGlz
YWJsZTsgdGhlbgogICAgICAgICAgICAgaWYgdGVzdCAkd3hVU0VfV0VCVklFV19JRSA9IG5vOyB0
aGVuCg==
--14dae934068183bfd304cc08dd87--