Re: [wx-dev] Re: CVS: [RR] wxWindows/build/bakefiles config.bkl,1.49,1.50 files.bkl,1.200,1.201 plugins_deps.bkl,1.1,1.2
Robert Roebling
> anon...@sunsite.dk wrote:
> > <set var="PLUGIN_ADV_EXTRALIBS">
> > <if cond="USE_PLUGINS=='0'">
> > $(EXTRALIBS_SDL)
> > + $(EXTRALIBS_GNOMEPRINT)
> > </if>
>
> This (as well as other changes implied by it, e.g. adding wxAdv to
> printing sample's dependencies) is wrong -- printing classes are not
> part of wxAdv library, they belong in wxCore and are there in all
> ports, wxGTK compiled with GNOME support should be no exception.
Well, sorry, but I did ask where to put it and you said
something like "along the lines of SDL" which is what
I did. I don't understand why wxGTK compiled with
external sound support may use wxAdv whereas wxGTK
compiled with external printing support may not.
Robert
Vaclav Slavik
anon...@sunsite.dk wrote:
> <set var="PLUGIN_ADV_EXTRALIBS">
> <if cond="USE_PLUGINS=='0'">
> $(EXTRALIBS_SDL)
> + $(EXTRALIBS_GNOMEPRINT)
> </if>
This (as well as other changes implied by it, e.g. adding wxAdv to
printing sample's dependencies) is wrong -- printing classes are not
part of wxAdv library, they belong in wxCore and are there in all
ports, wxGTK compiled with GNOME support should be no exception.
Regards,
Vaclav
--
PGP key: 0x465264C9, available from http://pgp.mit.edu/
Ron
> > This (as well as other changes implied by it, e.g. adding wxAdv to
> > printing sample's dependencies) is wrong -- printing classes are not
> > part of wxAdv library, they belong in wxCore and are there in all
> > ports, wxGTK compiled with GNOME support should be no exception.
>
> Well, sorry, but I did ask where to put it and you said
> something like "along the lines of SDL" which is what
> I did. I don't understand why wxGTK compiled with
> external sound support may use wxAdv whereas wxGTK
> compiled with external printing support may not.
Nor do I. Making core depend on gnome if gnome support
can be easily segregated seems utterly wrong. I can't say
if Adv is the right place for this, because making the rest
of it depend on gnome seems little better than doing that
to core, I think this should go in a lib 'like' adv all of
its own, where any other gnome tidbits might go if they ever
seem useful. But I can't blame Robert for trying to keep
his changes to bakefiles minimal while this be being tested
and incorporated. The factory interface of course should
remain centrally located, but not the gnome dependent impl.
Ron
Vaclav Slavik
Robert Roebling wrote:
> Well, sorry, but I did ask where to put it and you said
> something like "along the lines of SDL"
Err, you must have misunderstood what I said -- I asked you to make
the GNOME dependency temporarily "static", configure-time, like the
dependency on SDL is handled, not to move some of printing classes to
wxAdv.
> which is what
> I did. I don't understand why wxGTK compiled with
> external sound support may use wxAdv whereas wxGTK
> compiled with external printing support may not.
Very simple: wxSound is part of wxAdv in *all* ports, whereas printing
classes are in wxAdv in *none* of the ports (now with the exception
of wxGTK). See here:
http://www.lpthe.jussieu.fr/~zeitlin/wxWindows/docs/wxwin_librarieslist.html#librarieslist
This doesn't have anything to do with being "external", whatever that
means -- the problem is caused exactly in situation when is is *not*
in any way external/pluggable, but compiled directly into the
library.
Rergards