#11424: Cursor loading does nothing if manifest is not included (MSW)
wxTrac
#11424: Cursor loading does nothing if manifest is not included (MSW)
-----------------------------------------+----------------------------------
Reporter: triton | Owner:
Type: enhancement | Status: new
Priority: low | Milestone:
Component: wxMSW | Version: 2.9-svn
Keywords: cursor loading manifest doc | Blockedby:
Patch: 1 | Blocking:
-----------------------------------------+----------------------------------
I was trying to set a custom cursor and it didn't work. After some
searching I found out I needed to include the "wx/msw/wx.rc" resource
file. So I thought it would be a good idea to add this to the docs so in
the future, people like me who didn't know this was needed, don't need to
search.
See the attached patch. This is my first time generating a patch, so hope
everything is in order.
--
Ticket URL: <http://trac.wxwidgets.org/ticket/11424>
wxTrac
#11424: Cursor loading does nothing if wx.rc is not included (MSW)
-----------------------------------------+----------------------------------
Reporter: triton | Owner:
Type: enhancement | Status: confirmed
Component: wxMSW | Version: 2.9-svn
Keywords: cursor loading manifest doc | Blockedby:
Patch: 1 | Blocking:
-----------------------------------------+----------------------------------
* status: new => confirmed
Comment:
The patch is good, thanks, but I don't actually think this is correct.
Most of the standard cursors are defined by Windows, only a few of them
are in `wx.rc`. I guess we should mention that in the docs or at least say
that "some of the cursors require wx.rc to be included"?
OTOH including `wx.rc` is always the right thing to do, even if you don't
use cursors, as it contains other important definitions. So I wonder if we
shouldn't have an assert on app startup checking that it is loaded?
Finally, we could at least give a more useful error message in
`wxCursor::InitFromStock()` pointing to `wx.rc` too (as nobody reads the
documentation anyhow...).
--
Ticket URL: <http://trac.wxwidgets.org/ticket/11424#comment:1>
wxTrac
#11424: Cursor loading does nothing if wx.rc is not included (MSW)
-----------------------------------------+----------------------------------
Reporter: triton | Owner:
Type: enhancement | Status: confirmed
Priority: low | Milestone:
Component: wxMSW | Version: 2.9-svn
Keywords: cursor loading manifest doc | Blockedby:
Patch: 1 | Blocking:
-----------------------------------------+----------------------------------
Comment(by triton):
vadz, asserting when wx.rc isn't included sounds like a good idea to me,
especially since some stuff won't work and then people will not know why.
--
Ticket URL: <http://trac.wxwidgets.org/ticket/11424#comment:2>
wxTrac
#11424: Cursor loading does nothing if wx.rc is not included (MSW)
--------------------------+-------------------------------------------------
Reporter: triton | Owner:
Type: enhancement | Status: closed
Priority: low | Milestone:
Component: wxMSW | Version: 2.9-svn
Resolution: fixed | Keywords: cursor loading manifest doc
Blockedby: | Patch: 1
Blocking: |
--------------------------+-------------------------------------------------
Changes (by VZ):
* status: confirmed => closed
* resolution: => fixed
Comment:
(In [63276]) Try to prevent users from forgetting to include wx.rc from
their resources.
Document that some of the standard cursors are defined in this file.
Also add a (hopefully) helpful assert if loading one of such cursors
failed.
Closes #11424.
--
Ticket URL: <http://trac.wxwidgets.org/ticket/11424#comment:3>