Re: [wx-dev] Adding wxGzipInputStream / wxGzipOutputStream =?iso-8859-1?q?classes

0 views

Skip to first unread message

Vaclav Slavik

unread,

May 13, 2009, 10:21:35 PM5/13/09

to wx-...@lists.wxwindows.org

?=
Date: Wed, 11 Jun 2003 16:56:17 +0200
User-Agent: KMail/1.5.2
References: <20030609201625.ZPUV20145.mta07-svc.ntlworld.com@there> <200306101846.118...@matfyz.cz> <20030611051134.VILT18862.mta06-svc.ntlworld.com@there>
In-Reply-To: <20030611051134.VILT18862.mta06-svc.ntlworld.com@there>
X-KMail-Link-Message: 140077710
X-KMail-Link-Type: reply
MIME-Version: 1.0
Content-Type: multipart/signed;
protocol="application/pgp-signature";
micalg=pgp-sha1;
boundary="Boundary-02=_XM05+MtkMEhLADp";
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200306111656.234...@matfyz.cz>
Status: RO
X-Status: Q
X-KMail-EncryptionState:
X-KMail-SignatureState:

--Boundary-02=_XM05+MtkMEhLADp
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Description: signed data
Content-Disposition: inline

Hi,

Michael Wetherell wrote:
> > with .gz files) or derive from wxZlibInputStream (because there
> > two will no doubt share _losts_ of common code)?
>
> Yes I was going to make it a filter either way.=20

Ah, I'm sorry, I misunderstood you.

> though I guess it makes more sense for the structure of the library
> if filters are actually derived from wxFilterInputStream.

Yes...=20

> Anyway, I'll do as you suggest and derive from (or incorporate
> into) wxZlibInputStream. The reason I hesitated was that I thought
> maybe it would be better not to have to change anything about the
> implementation of wxZlibInputStream.

It depends on what changes would be required I guess. Vadim, what do=20
you think?

> wxZlibInputStream should override Peek and GetSize, shouldn't it?
> Should I do that while I'm working on it, or do you think someone
> might be depending on the current behaviour?

Such improvement would of course be most welcome! I think that current=20
behaviour is clearly a bug and if anybody depends on it, then his/her=20
code needs fixing.

> I have one last question: I've used wxDateTime for handling the
> timestamps, is that a reasonably dependancy? The timestamps in gzip
> files are Unix time_ts, so I could switch to using time_t in the
> interface, would that be better?=20

I personally think that wxDateTime is better choice.

Regards,
Vaclav

=2D-=20
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0x465264C9

--Boundary-02=_XM05+MtkMEhLADp
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA+50MXxDYa/UZSZMkRArmlAJ9BuFhmg35zpiEylwxHGVXINMxcBwCgkkxh
5mWmEtigi3h7MGIZBtO/JIA=
=YbDt
-----END PGP SIGNATURE-----