Re: #8874: support for windows unique volume names
wxTrac
#8874: support for windows unique volume names
---------------------------+------------------------------------------------
Reporter: talon_karrde | Owner:
Type: enhancement | Status: reopened
Priority: low | Milestone:
Component: base | Version: 2.9-svn
Resolution: | Keywords: windows unique volume name
Blockedby: | Patch: 1
Blocking: |
---------------------------+------------------------------------------------
Changes (by talon_karrde):
* keywords: => windows unique volume name
* status: closed => reopened
* version: => 2.9-svn
* component: => base
* type: => enhancement
Comment:
I've finally gotten to modify and resend the patch for this issue, sorry
for the extreme delay.
This patch has been made againt the trunk, I suppose 2.9-svn is the
closest value I could choose for the Version field.
Please tell me if there is still something wrong with the patch as I
haven't been around for some time so there is every chance I could have
gotten something wrong.
Btw is there a way to remove the old patch file from this ticket as it's
not needed and can just confuse people?
--
Ticket URL: <http://trac.wxwidgets.org/ticket/8874#comment:5>
wxTrac
#8874: support for windows unique volume names
---------------------------+------------------------------------------------
Reporter: talon_karrde | Owner:
Type: enhancement | Status: confirmed
Priority: low | Milestone:
Component: base | Version: 2.9-svn
Resolution: | Keywords: windows unique volume name
Blockedby: | Patch: 1
Blocking: |
---------------------------+------------------------------------------------
Changes (by vadz):
* cc: vadz (removed)
* status: reopened => confirmed
Comment:
Thanks for the update! Unfortunately the patch doesn't apply right now
because of the changes in the trunk since then, could you please redo it?
It shouldn't be difficult to fix it but I didn't want to do it because the
other points:
0. New function must be documented in `interface/wx/filename.h`.
1. I still wonder why should this constant need to be public, does the
user code really need to access it? If so, why (i.e. could you please
mention what is it useful for in the documentation of this constant too)?
2. It would be great to have unit tests for this stuff in
`tests/filename/filenametest.cpp` because as this is something that is
probably not used very often, chances of breaking support for volume names
and not noticing it are very high. Could you please use them in a couple
of the tests?
TIA!
--
Ticket URL: <http://trac.wxwidgets.org/ticket/8874#comment:6>
wxTrac
#8874: support for windows unique volume names
---------------------------+------------------------------------------------
Reporter: talon_karrde | Owner:
Type: enhancement | Status: confirmed
Priority: low | Milestone:
Component: base | Version: 2.9-svn
Resolution: | Keywords: windows unique volume name
Blockedby: | Patch: 1
Blocking: |
---------------------------+------------------------------------------------
Comment(by talon_karrde):
OK, I'll get down to doing points 1 and 3 shortly.
As for 2 - I can't think of any case in which the constant will be useful
to the user right now, and I'm not sure any exists. The reason I made it
public is because it's needed both in ::wxDirExists() and in wxFileName's
methods, so it had to be exposed. And I declared it with an export
declaration because any user code can use it once it's been declared like
that, and I don't see any point in allowing users to use it only if they
link statically to wxWidgets. Any suggestions are welcome.
--
Ticket URL: <http://trac.wxwidgets.org/ticket/8874#comment:7>
wxTrac
#8874: support for windows unique volume names
---------------------------+------------------------------------------------
Reporter: talon_karrde | Owner:
Type: enhancement | Status: confirmed
Priority: low | Milestone:
Component: base | Version: 2.9-svn
Resolution: | Keywords: windows unique volume name
Blockedby: | Patch: 1
Blocking: |
---------------------------+------------------------------------------------
Comment(by vadz):
Replying to [comment:7 talon_karrde]:
> OK, I'll get down to doing points 1 and 3 shortly.
TIA!
> As for 2 - I can't think of any case in which the constant will be
useful to the user right now, and I'm not sure any exists. The reason I
made it public is because it's needed both in ::wxDirExists() and in
wxFileName's methods
The best way to fix this would be to move `wxDirExists()` contents to
`wxFileName::DirExists()` and just call the latter from the former
(instead of vice versa, as it is done now). This is, of course, an
unrelated change and should be done as a separate patch but OTOH it does
make sense as the long-term plan is to get rid of all the global file-
related functions and use wxFileName for everything anyhow. If you could
please do it (and probably for `wxFileExists()` too for consistency) it
would be great.
Thanks again!
--
Ticket URL: <http://trac.wxwidgets.org/ticket/8874#comment:8>
wxTrac
#8874: support for windows unique volume names
---------------------------+------------------------------------------------
Reporter: talon_karrde | Owner:
Type: enhancement | Status: confirmed
Priority: low | Milestone:
Component: base | Version: 2.9-svn
Resolution: | Keywords: windows unique volume name
Blockedby: | Patch: 1
Blocking: |
---------------------------+------------------------------------------------
I submitted a patch which moves the logic from ::wxFile/DirExists() to
wxFileName::File/DirExists as proposed, see
[http://trac.wxwidgets.org/ticket/11488].
I'll wait for that patch to be committed to trunk before creating a new
patch for this ticket, because I wouldn't want to manually edit the diff
that would result if I made the changes over the dirty trunk now.
Regards,
Neno Ganchev
--
Ticket URL: <http://trac.wxwidgets.org/ticket/8874#comment:9>
wxTrac
#8874: support for windows unique volume names
---------------------------+------------------------------------------------
Reporter: talon_karrde | Owner:
Type: enhancement | Status: confirmed
Priority: low | Milestone:
Component: base | Version: 2.9-svn
Resolution: | Keywords: windows unique volume name
Blockedby: | Patch: 1
Blocking: |
---------------------------+------------------------------------------------
Comment(by talon_karrde):
actually very helpful:).
--
Ticket URL: <http://trac.wxwidgets.org/ticket/8874#comment:10>
wxTrac
#8874: support for windows unique volume names
---------------------------+------------------------------------------------
Reporter: talon_karrde | Owner:
Type: enhancement | Status: confirmed
Priority: low | Milestone:
Component: base | Version: 2.9-svn
Resolution: | Keywords: windows unique volume name
Blockedby: | Patch: 1
Blocking: |
---------------------------+------------------------------------------------
Thanks, will apply soon but I'll rename the function to
`IsMSWUniqueVolumeNamePath()` for consistency (a few of the existing MSW-
only functions use "MSW" in their names and AFAIK we don't use "Win"
anywhere).
--
Ticket URL: <http://trac.wxwidgets.org/ticket/8874#comment:11>
wxTrac
#8874: support for windows unique volume names
---------------------------+------------------------------------------------
Reporter: talon_karrde | Owner:
Component: base | Version: 2.9-svn
Blocking: |
---------------------------+------------------------------------------------
* status: confirmed => closed
* resolution: => fixed
Comment:
(In [62782]) Add support for MSW unique volume names to wxFileName.
Recognize the paths starting with "\\?\Volume{GUID}" under MSW and provide
a
way to test for them.
Closes #8874.
--
Ticket URL: <http://trac.wxwidgets.org/ticket/8874#comment:12>