#14710: Bad wxAuiNotebook child position (theming problem ?)
---------------------------+----------------------------------------------- -
 Reporter:  EmilienKia     |       Owner:        
     Type:  defect         |      Status:  new    
 Priority:  normal         |   Milestone:        
Component:  wxAui          |     Version:  2.9-svn
 Keywords:  wxAuiNotebook  |   Blockedby:        
    Patch:  0              |    Blocking:        
---------------------------+----------------------------------------------- -
 Hi all,

 This is a little problem of theming with wxAuiNotebook on Linux
 (wxAuiGtkTabArt): child windows are not well placed relative to theme.
 They use all available width without letting space to border theme.

 The problem is visible on screenshots (AUI sample versus Pluma/Gedit).

 Best regards,

 Emilien

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710>

#14710: Bad wxAuiNotebook child position (theming problem ?)
---------------------------+----------------------------------------------- -
 Reporter:  EmilienKia     |       Owner:        
     Type:  defect         |      Status:  new    
 Priority:  normal         |   Milestone:        
Component:  wxAui          |     Version:  2.9-svn
 Keywords:  wxAuiNotebook  |   Blockedby:        
    Patch:  0              |    Blocking:        
---------------------------+----------------------------------------------- -
Changes (by vadz):

 * cc: jens (added)

Comment:

 Just adding jens to the cc in the hope he might be able to look at this.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:1>

#14710: Bad wxAuiNotebook child position (theming problem ?)
---------------------------+----------------------------------------------- -
 Reporter:  EmilienKia     |       Owner:        
     Type:  defect         |      Status:  new    
 Priority:  normal         |   Milestone:        
Component:  wxAui          |     Version:  2.9-svn
 Keywords:  wxAuiNotebook  |   Blockedby:        
    Patch:  0              |    Blocking:        
---------------------------+----------------------------------------------- -

Comment(by jens):

 Replying to [comment:1 vadz]:
 > Just adding jens to the cc in the hope he might be able to look at this.
 I will look into it.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:2>

#14710: Bad wxAuiNotebook child position (theming problem ?)
---------------------------+----------------------------------------------- -
 Reporter:  EmilienKia     |       Owner:        
     Type:  defect         |      Status:  new    
 Priority:  normal         |   Milestone:        
Component:  wxAui          |     Version:  2.9-svn
 Keywords:  wxAuiNotebook  |   Blockedby:        
    Patch:  0              |    Blocking:        
---------------------------+----------------------------------------------- -

Comment(by jens):

 Just for the record:
 It's not a tabart(gtk) problem.
 The tabart-classes draw the tab-control, but not the part that contains
 the pane assigend to the tab.

 Changes have to be done in the dockart, floatpane and framemanager
 sources.
 I think it should be possible to add something like dockartgtk.

 But this will (most likely) take a little longer, than just fixing
 existing drawing code in tabartgtk.

 Nevertheless: I start working on it.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:3>

#14710: Bad wxAuiNotebook child position (theming problem ?)
---------------------------+----------------------------------------------- -
 Reporter:  EmilienKia     |       Owner:        
     Type:  defect         |      Status:  new    
 Priority:  normal         |   Milestone:        
Component:  wxAui          |     Version:  2.9-svn
 Keywords:  wxAuiNotebook  |   Blockedby:        
    Patch:  1              |    Blocking:        
---------------------------+----------------------------------------------- -
Changes (by jens):

  * patch:  0 => 1

Comment:

 I attach a patch, that fixes the described issue.
 The patch let the notebooks render the pan-border themselves, instead of
 doing this in dockart.cpp.
 The size of the tab's content-window will be decreased accordingly.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:4>

#14710: Bad wxAuiNotebook child position (theming problem ?)
---------------------------+----------------------------------------------- -
 Reporter:  EmilienKia     |       Owner:        
     Type:  defect         |      Status:  new    
 Priority:  normal         |   Milestone:  2.9.5  
Component:  wxAui          |     Version:  2.9-svn
 Keywords:  wxAuiNotebook  |   Blockedby:        
    Patch:  1              |    Blocking:        
---------------------------+----------------------------------------------- -
Changes (by vadz):

 * cc: mmacleod@… (added)
  * milestone:  => 2.9.5

Comment:

 Looks fine to me, thanks!

 Malcolm, OK to apply or would you prefer to wait for your merge/include
 this in it?

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:5>

#14710: Bad wxAuiNotebook child position (theming problem ?)
---------------------------+----------------------------------------------- -
 Reporter:  EmilienKia     |       Owner:        
     Type:  defect         |      Status:  new    
 Priority:  normal         |   Milestone:  2.9.5  
Component:  wxAui          |     Version:  2.9-svn
 Keywords:  wxAuiNotebook  |   Blockedby:        
    Patch:  1              |    Blocking:        
---------------------------+----------------------------------------------- -

Comment(by mmacleod):

 Think you can go ahead on this one, thanks.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:6>

#14710: Bad wxAuiNotebook child position (theming problem ?)
---------------------------+----------------------------------------------- -
 Reporter:  EmilienKia     |       Owner:        
     Type:  defect         |      Status:  new    
 Priority:  normal         |   Milestone:        
Component:  wxAui          |     Version:  2.9-svn
 Keywords:  wxAuiNotebook  |   Blockedby:        
    Patch:  1              |    Blocking:        
---------------------------+----------------------------------------------- -
Changes (by vadz):

  * milestone:  2.9.5 =>

Comment:

 Unfortunately applying the patch results in the following when running aui
 sample under Linux:
 {{{
 (auidemo:12421): Gdk-CRITICAL **: gdk_drawable_get_depth: assertion
 `GDK_IS_DRAWABLE (drawable)' failed

 (auidemo:12421): Gtk-CRITICAL **: gtk_paint_box: assertion `style->depth
 == gdk_drawable_get_depth (window)' failed

 (auidemo:12421): Gdk-CRITICAL **: gdk_drawable_get_depth: assertion
 `GDK_IS_DRAWABLE (drawable)' failed

 (auidemo:12421): Gtk-CRITICAL **: gtk_paint_box: assertion `style->depth
 == gdk_drawable_get_depth (window)' failed

 (auidemo:12421): Gdk-CRITICAL **: gdk_drawable_get_depth: assertion
 `GDK_IS_DRAWABLE (drawable)' failed

 (auidemo:12421): Gtk-CRITICAL **: gtk_paint_box: assertion `style->depth
 == gdk_drawable_get_depth (window)' failed

 (auidemo:12421): Gdk-CRITICAL **: gdk_drawable_get_depth: assertion
 `GDK_IS_DRAWABLE (drawable)' failed

 (auidemo:12421): Gtk-CRITICAL **: gtk_paint_box: assertion `style->depth
 == gdk_drawable_get_depth (window)' failed
 }}}

 Could you please look into this Jens? TIA!

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:7>

#14710: Bad wxAuiNotebook child position (theming problem ?)
---------------------------+----------------------------------------------- -
 Reporter:  EmilienKia     |       Owner:        
     Type:  defect         |      Status:  new    
 Priority:  normal         |   Milestone:        
Component:  wxAui          |     Version:  2.9-svn
 Keywords:  wxAuiNotebook  |   Blockedby:        
    Patch:  1              |    Blocking:        
---------------------------+----------------------------------------------- -

Comment(by jens):

 The updated patch should fix this issue.

 Sorry for the inconvenience.

 Jens

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:8>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:              
      Type:  defect      |      Status:  closed      
  Priority:  normal      |   Milestone:              
 Component:  wxAui       |     Version:  2.9-svn      
Resolution:  fixed       |    Keywords:  wxAuiNotebook
 Blockedby:              |       Patch:  1            
  Blocking:              |  
-------------------------+------------------------------------------------- -
Changes (by VZ):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 (In [72641]) Improve wxAuiNotebook appearance when using some GTK themes.

 Let wxAuiNotebook render the border itself, instead of doing it in dock
 art
 class. This allows the notebook to do it correctly for the current theme.

 Closes #14710.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:9>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:              
      Type:  defect      |      Status:  closed      
  Priority:  normal      |   Milestone:              
 Component:  wxAui       |     Version:  2.9-svn      
Resolution:  fixed       |    Keywords:  wxAuiNotebook
 Blockedby:              |       Patch:  1            
  Blocking:              |  
-------------------------+------------------------------------------------- -

Comment(by LukasK):

 Attached a screenshot of an error occuring in my application on Windows 7
 after r72641.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:10>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:              
      Type:  defect      |      Status:  reopened    
  Priority:  normal      |   Milestone:              
 Component:  wxAui       |     Version:  2.9-svn      
Resolution:              |    Keywords:  wxAuiNotebook
 Blockedby:              |       Patch:  1            
  Blocking:              |  
-------------------------+------------------------------------------------- -
Changes (by LukasK):

  * status:  closed => reopened
  * resolution:  fixed =>

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:11>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:                          
      Type:  defect      |      Status:  confirmed              
  Priority:  normal      |   Milestone:  2.9.5                  
 Component:  wxAui       |     Version:  2.9-svn                
Resolution:              |    Keywords:  wxAuiNotebook regression
 Blockedby:              |       Patch:  1                      
  Blocking:              |  
-------------------------+------------------------------------------------- -
Changes (by vadz):

  * keywords:  wxAuiNotebook => wxAuiNotebook regression
  * status:  reopened => confirmed
  * milestone:  => 2.9.5

Comment:

 I don't see this immediately on sample startup but I do see it if I reduce
 and increase back the main window height in the aui sample.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:12>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:                          
      Type:  defect      |      Status:  confirmed              
  Priority:  normal      |   Milestone:  2.9.5                  
 Component:  wxAui       |     Version:  2.9-svn                
Resolution:              |    Keywords:  wxAuiNotebook regression
 Blockedby:              |       Patch:  1                      
  Blocking:              |  
-------------------------+------------------------------------------------- -

Comment(by jens):

 I can look into it this evening.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:13>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:                          
      Type:  defect      |      Status:  confirmed              
  Priority:  normal      |   Milestone:  2.9.5                  
 Component:  wxAui       |     Version:  2.9-svn                
Resolution:              |    Keywords:  wxAuiNotebook regression
 Blockedby:              |       Patch:  1                      
  Blocking:              |  
-------------------------+------------------------------------------------- -

Comment(by jens):

 A little later, but this patch fixes the issue.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:14>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:                          
      Type:  defect      |      Status:  confirmed              
  Priority:  normal      |   Milestone:  2.9.5                  
 Component:  wxAui       |     Version:  2.9-svn                
Resolution:              |    Keywords:  wxAuiNotebook regression
 Blockedby:              |       Patch:  1                      
  Blocking:              |  
-------------------------+------------------------------------------------- -

Comment(by LukasK):

 The patch (fix_for_regression_introduced_in_72641.patch) removed the
 refresh problem in my application.
 Thanks!

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:15>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:                          
      Type:  defect      |      Status:  confirmed              
  Priority:  normal      |   Milestone:  2.9.5                  
 Component:  wxAui       |     Version:  2.9-svn                
Resolution:              |    Keywords:  wxAuiNotebook regression
 Blockedby:              |       Patch:  1                      
  Blocking:              |  
-------------------------+------------------------------------------------- -

Comment(by vadz):

 Thanks Jens!

 Should this be also applied to the dynamic notebook branch?

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:16>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:                          
      Type:  defect      |      Status:  closed                  
  Priority:  normal      |   Milestone:  2.9.5                  
 Component:  wxAui       |     Version:  2.9-svn                
Resolution:  fixed       |    Keywords:  wxAuiNotebook regression
 Blockedby:              |       Patch:  1                      
  Blocking:              |  
-------------------------+------------------------------------------------- -
Changes (by VZ):

  * status:  confirmed => closed
  * resolution:  => fixed

Comment:

 (In [72720]) Fix border size computation in wxAuiTabArt.

 Space was reserved for the borders even when it wasn't filled, resulting
 in
 visual artefacts. Fix this by virtualizing the function returning the
 additional space needed for the borders and only overriding it to return
 non
 zero in wxAuiGtkTabArt.

 Closes #14710.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:17>

#14710: Bad wxAuiNotebook child position (theming problem ?)
-------------------------+------------------------------------------------- -
  Reporter:  EmilienKia  |       Owner:                          
      Type:  defect      |      Status:  closed                  
  Priority:  normal      |   Milestone:  2.9.5                  
 Component:  wxAui       |     Version:  2.9-svn                
Resolution:  fixed       |    Keywords:  wxAuiNotebook regression
 Blockedby:              |       Patch:  1                      
  Blocking:              |  
-------------------------+------------------------------------------------- -

Comment(by jens):

 Replying to [comment:16 vadz]:
 > Thanks Jens!
 >
 > Should this be also applied to the dynamic notebook branch?
 No, it is not included in the branch and needs to be reimplemented.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14710#comment:18>