#14323: wxfontdialog blows up when entering text for font point size

May 21, 2012, 2:04:37 PM5/21/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:20>

#14323: wxFontDialog blows up when entering text for font point size

-------------------------+--------------------------------------------------
Reporter: krakorar | Owner:
Type: defect | Status: new
Priority: critical | Milestone: 2.9.4
Component: wxOSX-Cocoa | Version: 2.9.3
Keywords: | Blockedby:
Patch: 0 | Blocking:
-------------------------+--------------------------------------------------

Comment(by krakorar):

Replying to [comment:19 plorkyeran]:

> I can consistent trigger a crash with the following steps (10.7.4,
latest wx trunk):
> 1. Open dialog sample
> 2. Open font dialog, type .5 after the 13, hit OK
> 3. Open font dialog, type .5 after the 14
> 4. Program crashes immediately
>
> Even very similar steps don't cause crashes, but they do have very
strange results -- in step 3, if instead of typing .5 I select the text
and try to type 15 it doesn't crash, but when I press 5 it instead inserts
4.

Thanks for confirming this. I thought that I was going mad. This has
been happening on Lion (all versions). I have not yet tested on Snow
Leopard.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:20>

wxTrac

unread,

May 21, 2012, 5:52:51 PM5/21/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:21>

#14323: wxFontDialog blows up when entering text for font point size

-------------------------+--------------------------------------------------
Reporter: krakorar | Owner:
Type: defect | Status: new
Priority: critical | Milestone: 2.9.4
Component: wxOSX-Cocoa | Version: 2.9.3
Keywords: | Blockedby:
Patch: 0 | Blocking:
-------------------------+--------------------------------------------------

Comment(by krakorar):

I found this on cocotron about a bug in nsfontpanel. I know Apple's is
probably a little different. This bug report and fixes specifically
mentions the font size text view messing up the font panel and it was
filed on May 2nd of this year.

http://code.google.com/p/cocotron/issues/detail?id=950

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:21>

wxTrac

unread,

May 21, 2012, 9:39:41 PM5/21/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:22>

#14323: wxFontDialog blows up when entering text for font point size

-------------------------+--------------------------------------------------
Reporter: krakorar | Owner:
Type: defect | Status: new
Priority: critical | Milestone: 2.9.4
Component: wxOSX-Cocoa | Version: 2.9.3
Keywords: | Blockedby:
Patch: 0 | Blocking:
-------------------------+--------------------------------------------------

unread,

May 22, 2012, 7:02:18 AM5/22/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:26>

#14323: wxFontDialog blows up when entering text for font point size
-------------------------+--------------------------------------------------
Reporter: krakorar | Owner:
Type: defect | Status: new
Priority: critical | Milestone: 2.9.4
Component: wxOSX-Cocoa | Version: 2.9.3
Keywords: | Blockedby:
Patch: 0 | Blocking:
-------------------------+--------------------------------------------------

Comment(by krakorar):

NSFontPanel's size field is interfering with the font panel itself
Inbox
x
Robert Krakora May 17 (5 days ago)
Hi, I am using NSFontPanel and I am having a problem where the size field
is ...
Robert Krakora May 17 (5 days ago)
Hi, This also seems to describe the problem I am having...
http://www.cocoabu...
Corbin Dunn May 17 (4 days ago)
Hi Rob, The best thing to do is log this as a bug: bugreporter.apple.com
If p...
Robert Krakora May 17 (4 days ago)
Hi Corbin, After entering my login and password, I get this: An error has
occ...
Robert Krakora May 17 (4 days ago)
Hi Corbin, In the attached file the function int
RunMixedFontDialog(wxFontDia...
Robert Krakora May 18 (4 days ago)
Hi Corbin, I was finally able to file a bug report. Thanks for your help.
Corbin Dunn May 18 (4 days ago)
Awesome, thanks!
Robert Krakora 9:35 AM (21 hours ago)
Here is the exception in nsfontpanel... 2012-05-21 09:32:02.424
smbanner[6232...
Corbin Dunn 10:48 AM (20 hours ago)
Thanks -- definitely include it in the bug report so the right person can
loo...
Robert Krakora

10:51 AM (20 hours ago)

to Corbin, bcc: Jerry
Hi Corbin,

I just updated the bug report.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:26>

wxTrac

unread,

May 22, 2012, 7:08:26 AM5/22/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:27>

#14323: wxFontDialog blows up when entering text for font point size
-------------------------+--------------------------------------------------
Reporter: krakorar | Owner:

Type: defect | Status: confirmed
Priority: high | Milestone: 3.0

Component: wxOSX-Cocoa | Version: 2.9.3
Keywords: | Blockedby:
Patch: 0 | Blocking:
-------------------------+--------------------------------------------------

Changes (by vadz):

* priority: critical => high
* status: new => confirmed
* milestone: 2.9.4 => 3.0

Comment:

Replying to [comment:25 krakorar]:

> Replying to [comment:23 csomor]:
> > cocotron is a 3rd party reimplementation, you can hardly file Apple a
bug report for code of which they didn't write
>
>
> Hey there is no need to talk to me like this.

There was absolutely nothing impolite (i.e. like anything involving the
word "jerk") in what Stefan wrote so I really wonder what could explain,
let alone justify, your reaction. In any case, please keep discussion here
related to technical issues, this comment didn't add anything useful.

Thanks.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:27>

wxTrac

unread,

May 22, 2012, 7:41:26 AM5/22/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:28>

#14323: wxFontDialog blows up when entering text for font point size
-------------------------+--------------------------------------------------
Reporter: krakorar | Owner:
Type: defect | Status: confirmed
Priority: high | Milestone: 3.0
Component: wxOSX-Cocoa | Version: 2.9.3
Keywords: | Blockedby:
Patch: 0 | Blocking:
-------------------------+--------------------------------------------------

Comment(by krakorar):

you can hardly file Apple a bug report for code of which they didn't write

Sorry, but this sounded a bit impolite to me. It is hard to grasp context
and emotion via textual communication. I am sorry if I offended. I have
been working on this issue for a little over a month and I explored every
avenue before I committed to filing a bug report so that I would not waste
any wxWidgets developers time looking in to something that was really a
non-issue. I love wxWidgets. ;-)

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:28>

wxTrac

unread,

May 22, 2012, 7:50:17 AM5/22/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:29>

unread,

May 22, 2012, 5:05:21 PM5/22/12

Resolution: invalid | Keywords:
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------
Changes (by krakorar):

* status: confirmed => closed
* resolution: => invalid

Comment:

I have found out that the Lion image on my mid-2011 Mac Mini became
corrupted somehow causing the problem that I was seeing. wxFontDialog no
longer blows up and I cannot get it to blow up using fractional numbers
either. I am closing this and apologizing to Stephan and all the other
precious wxWidgets developers who graciously looked in to this non-
existent issue. Sorry all. :-(

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:70>

wxTrac

unread,

May 30, 2012, 3:10:03 PM5/30/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:71>

#14323: wxFontDialog blows up when entering text for font point size
--------------------------+-------------------------------------------------
Reporter: krakorar | Owner:

Type: defect | Status: reopened

Priority: high | Milestone: 3.0
Component: wxOSX-Cocoa | Version: 2.9.3

Resolution: | Keywords:

Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------
Changes (by krakorar):

* status: closed => reopened
* resolution: invalid =>

Comment:

Spoke too soon, can still make it happen without the fix I posted in
comments a little above...reopening...

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:71>

wxTrac

unread,

May 30, 2012, 3:13:47 PM5/30/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:72>

#14323: wxFontDialog blows up when entering text for font point size
--------------------------+-------------------------------------------------
Reporter: krakorar | Owner:
Type: defect | Status: reopened
Priority: high | Milestone: 3.0
Component: wxOSX-Cocoa | Version: 2.9.3
Resolution: | Keywords:
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------

Comment(by krakorar):

2012-05-30 15:11:38.890 smbanner[25237:603] *** NSRunStorage,

_NSBlockNumberForIndex(): index (2) beyond array bounds (2)

2012-05-30 15:11:38.893 smbanner[25237:603] (
0 CoreFoundation 0x938f8a67 __raiseError +
231
1 libobjc.A.dylib 0x9b1f9149
objc_exception_throw + 155
2 CoreFoundation 0x93860289 +[NSException

raise:format:arguments:] + 137

3 CoreFoundation 0x938601f9 +[NSException
raise:format:] + 57
4 AppKit 0x94f5314c
_NSBlockNumberForIndex + 83
5 AppKit 0x94f58f24

-[NSLayoutManager textContainerForGlyphAtIndex:effectiveRange:] + 274

6 AppKit 0x950656aa

-[NSTextView(NSSharing) updateInsertionPointStateAndRestartTimer:] + 812

7 AppKit 0x95069cc0

-[NSTextView(NSPrivate) _setWindow:] + 331

8 AppKit 0x94ef10d0
__NSViewRecursionHelper + 40
9 CoreFoundation 0x937e71a9
CFArrayApplyFunction + 57
10 AppKit 0x94fc4f14 -[NSView
_setWindow:] + 3029
11 AppKit 0x94fc5593 -[NSView
removeFromSuperview] + 453
12 AppKit 0x951f969e

-[_NSKeyboardFocusClipView removeFromSuperview] + 68

13 AppKit 0x94fca98c -[NSWindow
endEditingFor:] + 578
14 AppKit 0x94fc580c -[NSView
_endEditingIfFirstResponderIsASubview] + 146
15 AppKit 0x94fc5461 -[NSView
removeFromSuperview] + 147
16 AppKit 0x951f969e

-[_NSKeyboardFocusClipView removeFromSuperview] + 68

17 AppKit 0x951faf6c -[NSCell
endEditing:] + 463
18 AppKit 0x95501b1e -[NSTextField
textDidEndEditing:] + 431
19 Foundation 0x91dc2df1

unread,

Jun 21, 2012, 1:14:44 PM6/21/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:84>

#14323: wxFontDialog blows up when entering text for font point size
--------------------------+-------------------------------------------------
Reporter: krakorar | Owner:
Type: defect | Status: reopened
Priority: high | Milestone: 3.0
Component: wxOSX-Cocoa | Version: 2.9.3
Resolution: | Keywords:
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------

Comment(by krakorar):

extern "C" int RunMixedFontDialog(wxFontDialog* dialog) ;
int RunMixedFontDialog(wxFontDialog* dialog)
{
#if wxOSX_USE_COCOA
wxFontData& fontdata= ((wxFontDialog*)dialog)->GetFontData() ;
#else
wxUnusedVar(dialog);
#endif
int retval = wxID_CANCEL ;

wxAutoNSAutoreleasePool pool;

// setting up the ok/cancel buttons

NSFontPanel *fontPanel = [[NSFontManager sharedFontManager]
fontPanel:YES];

// adjust modality for carbon environment
#if wxOSX_USE_CARBON

WindowRef carbonWindowRef = (WindowRef)[fontPanel windowRef] ;
SetWindowModality(carbonWindowRef, kWindowModalityAppModal , 0) ;
SetWindowGroup(carbonWindowRef ,
GetWindowGroupOfClass(kMovableModalWindowClass));
#endif

[fontPanel setFloatingPanel:NO] ;
[[fontPanel standardWindowButton:NSWindowCloseButton] setEnabled:NO] ;

wxMacFontPanelAccView* accessoryView = (wxMacFontPanelAccView*)
[fontPanel accessoryView] ;
if ( accessoryView == nil)
{
NSRect rectBox = NSMakeRect( 0 , 0 , 192 , 40 );
accessoryView = [[wxMacFontPanelAccView alloc]
initWithFrame:rectBox];
[fontPanel setAccessoryView:accessoryView];
[accessoryView release];

[fontPanel setDefaultButtonCell:[[accessoryView okButton] cell]] ;
}

[accessoryView resetFlags];
#if wxOSX_USE_COCOA
wxFont font = *wxNORMAL_FONT ;
if ( fontdata.m_initialFont.IsOk() )
{
font = fontdata.m_initialFont ;

}

[[NSFontManager sharedFontManager] setSelectedFont:
font.OSXGetNSFont() isMultiple:NO];

if(fontdata.m_fontColour.IsOk())
[[NSColorPanel sharedColorPanel] setColor:

[NSColor colorWithCalibratedRed:fontdata.m_fontColour.Red() /
255.0
green:fontdata.m_fontColour.Green() / 255.0
blue:fontdata.m_fontColour.Blue()
/ 255.0
alpha:1.0]
];

else
[[NSColorPanel sharedColorPanel] setColor:[NSColor blackColor]];
#endif

// Lets start the modal loop for NSFontPanel that has been modified
// to fix the NSTextView exception occurring in Lion (OSX 10.7.X)
NSView* savedView = nil;
NSTableView* tableView = nil;
NSTextView* textView = nil;
NSString *origString = nil;
//BOOL done = NO;

NSModalSession session = [NSApp beginModalSessionForWindow:fontPanel];

if ([NSApp runModalSession:session] == NSRunContinuesResponse)
{
// Enumerate the views on NSFontPanel
NSMutableArray* array = allSubviewsOfView([fontPanel
contentView]);
NSString* classString = [NSString stringWithString:@"NSTextView"];
NSString* string = nil;
// Save view that initially has focus when the NSFontPanel is
instantiated
savedView = (NSView*)[fontPanel firstResponder];
// Get view count
NSUInteger count = [array count];
// Search for NSTextView
for (NSUInteger i = 0; i < count; i++)
{
string = NSStringFromClass([[array objectAtIndex: i] class]);
if (string != nil && [string isEqualToString: classString])
{
// Get NSTextView
textView = (NSTextView*)[array objectAtIndex: i];
// Save the original NSString in NSTextView
origString = [[textView textStorage] string];
// Delete NSString in NSTextView
[[textView textStorage] beginEditing];
[[textView textStorage]
deleteCharactersInRange:NSMakeRange(0, [[textView textStorage] length])];
[[textView textStorage] endEditing];
NSLog(@"\nNSTextView:\n%@", textView);
break;
}
}

classString = [NSString stringWithString:@"NSFontPanelTableView"];
string = nil;
// Search for NSTableView (actually subclassed as
NSFontPanelTableView)
// The first NSFontPanelTableView is the one we want and the one
we will get
// as it is the first one encountered in the enumeration. It
contains a list of
// "canned" font point sizes.
for (NSUInteger i = 0; i < count; i++)
{
string = NSStringFromClass([[array objectAtIndex: i] class]);
if (string != nil && [string isEqualToString: classString])
{
// Get NSFontPanelTableView
tableView = (NSTableView*)[array objectAtIndex: i];
NSLog(@"\nNSFontPanelTableView:\n%@", tableView);
break;
}
}

// NSFontPanelTableView found?
if (tableView != nil)
{
// Is one of the "canned" font point sizes in the list
selected?
if ([tableView selectedRow] >= 0)
{
// Get index of selected "canned" font point size
NSIndexSet *indexSet = [NSIndexSet indexSetWithIndex:
[tableView selectedRow]];
// Select the currently selected "canned" font point
size...I know, it is redundant,
// but this is part of the recipe to avoid the exception
encountered in the
// NSTextView without this hack
[tableView selectRowIndexes:indexSet
byExtendingSelection:NO];

// Delete NSString in NSTextView resulting from selection
of "canned" font point size
// above
[[textView textStorage] beginEditing];
[[textView textStorage]
deleteCharactersInRange:NSMakeRange(0, [[textView textStorage] length])];
[[textView textStorage] endEditing];
}

// Set focus to NSFontPanelTableView
[fontPanel makeFirstResponder: (NSResponder*)tableView];

// Is "canned" font point size selected?
if ([tableView selectedRow] >= 0)
{
// Get window position of selected row of "canned" font
point size
NSPoint origin =[tableView frameOfCellAtColumn:0
row:[tableView selectedRow]].origin;

// Convert to window coords
origin = [tableView convertPoint:origin toView:nil];
// Convert to screen coords - This is not needed...
//origin = [[view window] convertBaseToScreen:origin];

// Send left mouse down event to selected row of "canned"
font point size
NSEvent *newEvent = [NSEvent
mouseEventWithType:NSLeftMouseDown
location:origin
modifierFlags:0
timestamp:0
windowNumber:[[tableView
window] windowNumber]
context:[[tableView
window] graphicsContext]
eventNumber:0
clickCount:1
pressure:0
];
[NSApp postEvent:newEvent atStart:NO];

// Send left mouse up event to selected row of "canned"
font point size
newEvent = [NSEvent mouseEventWithType:NSLeftMouseUp
location:origin
modifierFlags:0
timestamp:0
windowNumber:[[tableView
window] windowNumber]
context:[[tableView
window] graphicsContext]
eventNumber:0
clickCount:1
pressure:0
];
[NSApp postEvent:newEvent atStart:NO];
}
// "canned" font point size was not selected, could be font
point size
// not in list that is residing in NSTextView
else
{
// Was there a NSString orginally in NSTextView?
if (origString != nil)
{
// Put orininal NSString back in to NSTextView
[textView insertText: origString];
}
}

// Restore focus to view that had focus when NSFontPanel was
// first instantiated
if (savedView != nil)
{
// Set focus to saved view
[fontPanel makeFirstResponder: (NSResponder*)savedView];
}
}
}

[NSApp runModalForWindow:fontPanel];

[NSApp endModalSession:session];

// if we don't reenable it, FPShowHideFontPanel does not work
[[fontPanel standardWindowButton:NSWindowCloseButton] setEnabled:YES]
;

#if wxOSX_USE_CARBON
if( FPIsFontPanelVisible())
FPShowHideFontPanel() ;
#else
[fontPanel close];
#endif

if ( [accessoryView closedWithOk])
{
#if wxOSX_USE_COCOA

NSFont* theFont = [fontPanel panelConvertFont:[NSFont
userFontOfSize:0]];

fontdata.m_chosenFont = wxFont( theFont );

//Get the shared color panel along with the chosen color and set
the chosen color
NSColor* theColor = [[[NSColorPanel sharedColorPanel] color]
colorUsingColorSpaceName:NSCalibratedRGBColorSpace];

fontdata.m_fontColour.Set((unsigned char) ([theColor redComponent]
* 255.0),
(unsigned char) ([theColor
greenComponent] * 255.0),
(unsigned char) ([theColor
blueComponent] * 255.0));
#endif
retval = wxID_OK ;
}
[fontPanel setAccessoryView:nil];

return retval ;
}

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:84>

wxTrac

unread,

Nov 25, 2012, 6:46:30 PM11/25/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:85>

#14323: wxFontDialog blows up when entering text for font point size
--------------------------+-------------------------------------------------
Reporter: krakorar | Owner:
Type: defect | Status: reopened
Priority: high | Milestone:

Component: wxOSX-Cocoa | Version: 2.9.3
Resolution: | Keywords:
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------

Changes (by vadz):

* milestone: 3.0 =>

Comment:

I don't think we can fix this in time for 3.0.

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:85>

wxTrac

unread,

Nov 25, 2012, 7:12:25 PM11/25/12

to wx-...@googlegroups.com

Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:86>

#14323: wxFontDialog blows up when entering text for font point size
--------------------------+-------------------------------------------------
Reporter: krakorar | Owner:
Type: defect | Status: reopened
Priority: high | Milestone:
Component: wxOSX-Cocoa | Version: 2.9.3
Resolution: | Keywords:
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------

Comment(by krakorar):

Hello,

Turns out that this is a >= OSX 10.6 bug. I submitted it and source code
to reproduce the problem to Apple. A couple of months ago it was
submitted to engineering according to a notification that I received. I
was able to "fix" the bad behavior of the font dialog by modifying the
wxWidgets source...but it is not pretty and may make your eyes bleed.
However, if you are interested, I can attach it to this bug report.

Best Regards,

Rob Krakora

--
Ticket URL: <http://trac.wxwidgets.org/ticket/14323#comment:86>

Reply all

Reply to author

Forward