2.8: Regression in src/mac/carbon/textctrl.cpp rev 61098/61106

[Tim Kosse]

Hi,

a recent regression in src/mac/carbon/textctrl.cpp is causing crashes on
OS X during drag&drop if multiple displays are attached to the system.

This is an old problem that has been fixed in revisions 54763 and 54764
but has recently been reintroduced in revisions 61098 and 61106.

One of the original bug reports is http://trac.wxwidgets.org/ticket/9748

The regression has first been reported at
http://trac.filezilla-project.org/ticket/4620

Regards,
Tim Kosse

[Julian Smart]

Tim Kosse wrote:
> Hi,
>
> a recent regression in src/mac/carbon/textctrl.cpp is causing crashes on
> OS X during drag&drop if multiple displays are attached to the system.
>
> This is an old problem that has been fixed in revisions 54763 and 54764
> but has recently been reintroduced in revisions 61098 and 61106.
>
> One of the original bug reports is http://trac.wxwidgets.org/ticket/9748
>

Hm. Looks like we have a choice - we either break the appearance of spin
controls and combo controls so they don't get their borders refreshed
when the focus changed (whether CD or non-CG), or we have drag and drop
crashes.

Alas I don't think either option is good, but if you don't happen to be
doing a lot of drag and drop then having a broken appearance seems (to
me) to suck especially badly. I suppose we could use wxSystemOptions to
choose which bug we preferred...

Stefan, do you have any thoughts about the border issue? With 61098 and
61106 reverted it's pretty easy to reproduce on 10.5 by clicking between
controls on the wxSpinCtrl page of the widgets sample. I also get the
problem with wxComboBox in my apps though I can't remember if the sample
shows this one.

Regards,

Julian

[Stefan Csomor]

Hi Julian

> Stefan, do you have any thoughts about the border issue? With 61098 and
> 61106 reverted it's pretty easy to reproduce on 10.5 by clicking between
> controls on the wxSpinCtrl page of the widgets sample. I also get the
> problem with wxComboBox in my apps though I can't remember if the sample
> shows this one.

I'll try to find another solution, we should really be able to use
HITextView for single line text controls under 10.5

Best,

Stefan

[Julian Smart]

Great, thanks for looking into it!

Best regards,

Julian

[Tim Kosse]

Julian Smart wrote:
> Alas I don't think either option is good, but if you don't happen to be
> doing a lot of drag and drop then having a broken appearance seems (to
> me) to suck especially badly. I suppose we could use wxSystemOptions to
> choose which bug we preferred...

Personally I do not use much drag & drop, however I know of many users
which use drag & drop almost exclusively to perform many tasks,
especially Mac users which do not know about context menus.

I think stability is of more importance than visual appearance. If a
program looks odd it can still be used, but if an application crashes a
lot of work in progress can get lost.

In case no solution can be found and the wxSystemOptions approach is
implemented I recommend to make avoiding the crash the default.

Regards,
Tim

[Stefan Csomor]

Hi Julian

> Stefan, do you have any thoughts about the border issue? With 61098 and
> 61106 reverted it's pretty easy to reproduce on 10.5 by clicking between
> controls on the wxSpinCtrl page of the widgets sample. I also get the
> problem with wxComboBox in my apps though I can't remember if the sample
> shows this one.

using my own 2.8 sandbox without the latest changes, I have no problem with
the widgets sample

I click into the textctrl box of the spin control, the focus rect is shown,
I click back into the 'current value' field, the focus is moved, spin
control is not having focus anymore

I'll update now, rebuild and test again, perhaps you have some other steps I
should take, also are you having full keyboard access on (system
preferenes->keyboard & mouse->bottom right (all controls or only text and
listboxes)

Best,

Stefan

[Stefan Csomor]

Hi Julian

> I'll update now, rebuild and test again, perhaps you have some other steps I
> should take, also are you having full keyboard access on (system
> preferenes->keyboard & mouse->bottom right (all controls or only text and
> listboxes)

ok, I can only reproduce the problem with full keyboard access on, which is
not the default on mac, I'll see what I can do

Best,

Stefan

[Stefan Csomor]

Hi Julian

could you please retest with my fixes, if it works, I'll do the final
cleanup

Thanks,

Stefan

[Julian Smart]

Hi Stefan,

Stefan Csomor wrote:
>>> I'll update now, rebuild and test again, perhaps you have some other steps I
>>> should take, also are you having full keyboard access on (system
>>> preferenes->keyboard & mouse->bottom right (all controls or only text and
>>> listboxes)
>>>
>> ok, I can only reproduce the problem with full keyboard access on, which is
>> not the default on mac, I'll see what I can do
>>
>
> could you please retest with my fixes, if it works, I'll do the final
> cleanup
>

Cool - from a cursory test, it seems to be working for both my app and
the widgets sample.

Many thanks for fixing it so fast!!

Julian

[Tim Kosse]

Stefan Csomor wrote:
> could you please retest with my fixes, if it works, I'll do the final
> cleanup

Looking good so far.

Thanks,
Tim