#11479: Fixed accel alignment problem on owner-drawn menu

1 view
Skip to first unread message

wxTrac

unread,
Nov 24, 2009, 10:34:27 AM11/24/09
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/11479>

#11479: Fixed accel alignment problem on owner-drawn menu
----------------------------------+-----------------------------------------
Reporter: malcompl | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: wxMSW | Version:
Keywords: wxMenu, wxOwnerDrawn | Blockedby:
Patch: 1 | Blocking:
----------------------------------+-----------------------------------------
Correction accel alignment on owner-drawn menu for more native look.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/11479>

wxTrac

unread,
Nov 25, 2009, 9:17:19 AM11/25/09
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:1>

#11479: Fixed accel alignment problem on owner-drawn menu

--------------------------+-------------------------------------------------
Reporter: malcompl | Owner:
Type: enhancement | Status: closed

Priority: normal | Milestone:
Component: wxMSW | Version:

Resolution: fixed | Keywords: wxMenu, wxOwnerDrawn
Blockedby: | Patch: 1
Blocking: |
--------------------------+-------------------------------------------------
Changes (by VZ):

* status: new => closed
* resolution: => fixed


Comment:

(In [62712]) Correct alignment of menu accelerator strings in owner-drawn
menus.

Draw them right-aligned as the native menus do.

Closes #11479.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:1>

wxTrac

unread,
Jan 23, 2010, 8:21:48 AM1/23/10
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:2>

#11479: Fixed accel alignment problem on owner-drawn menu

--------------------------+-------------------------------------------------
Reporter: malcompl | Owner:
Type: enhancement | Status: closed

Priority: normal | Milestone:
Component: wxMSW | Version:

Resolution: fixed | Keywords: wxMenu, wxOwnerDrawn
Blockedby: | Patch: 1
Blocking: |
--------------------------+-------------------------------------------------

Comment(by VZ):

(In [63224]) Correct alignment of menu accelerator strings in owner-drawn
menus.

Draw them right-aligned as the native menus do.

Closes #11479.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:2>

wxTrac

unread,
Jan 26, 2010, 9:11:51 AM1/26/10
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:3>

#11479: Fixed accel alignment problem on owner-drawn menu

--------------------------+-------------------------------------------------
Reporter: malcompl | Owner:
Type: enhancement | Status: reopened
Priority: normal | Milestone:
Component: wxMSW | Version: 2.9-svn
Resolution: | Keywords: wxMenu, wxOwnerDrawn
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------
Changes (by rk):

* status: closed => reopened
* version: => 2.9-svn
* resolution: fixed =>
* patch: 1 => 0


Comment:

I don't see the accelerators being right-aligned in my application. The
menu sample shows them left-aligned aswell when opening the "File/Standard
items demo" menu.
I am on WinXP and have wxUSE_OWNER_DRAWN enabled. Maybe I am doing
something wrong?


--
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:3>

wxTrac

unread,
Jan 26, 2010, 5:43:24 PM1/26/10
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:4>

#11479: Fixed accel alignment problem on owner-drawn menu

--------------------------+-------------------------------------------------
Reporter: malcompl | Owner:
Type: enhancement | Status: confirmed
Priority: normal | Milestone: 2.9.1

Component: wxMSW | Version: 2.9-svn
Resolution: | Keywords: wxMenu, wxOwnerDrawn
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------

Changes (by vadz):

* status: reopened => confirmed
* milestone: => 2.9.1


Comment:

This bug can also be seen only under XP (and older systems, presumably).
The accelerators are drawn correctly under Win7 but I do see the bug in
the menu sample under XP.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:4>

wxTrac

unread,
Feb 3, 2010, 2:50:38 AM2/3/10
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:5>

#11479: Fixed accel alignment problem on owner-drawn menu

--------------------------+-------------------------------------------------
Reporter: malcompl | Owner:

Type: enhancement | Status: confirmed
Priority: normal | Milestone: 2.9.1
Component: wxMSW | Version: 2.9-svn

Resolution: | Keywords: wxMenu, wxOwnerDrawn
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------

Comment(by malcompl):

This is not a bug, is a native behavior emulation, Windows without themes
accelerators aligns to the left, with themes to right. See native menu in
sample.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:5>

wxTrac

unread,
Feb 3, 2010, 3:29:21 AM2/3/10
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:6>

#11479: Fixed accel alignment problem on owner-drawn menu

--------------------------+-------------------------------------------------
Reporter: malcompl | Owner:
Type: enhancement | Status: infoneeded_new

Priority: normal | Milestone: 2.9.1
Component: wxMSW | Version: 2.9-svn

Resolution: | Keywords: wxMenu, wxOwnerDrawn
Blockedby: | Patch: 0
Blocking: |
--------------------------+-------------------------------------------------

Changes (by rk):

* status: confirmed => infoneeded_new


Comment:

You are right. I realized that after investigating the problem described
in #11657.
Although, this raises the question: Shouldn't it be possible to force a
menu to be owner-drawn other than having to set an image or changing the
color of one of its items. The problem is that if I have a menu bar I want
all menus to look the same even if I don't use icons/colors in one of
them. Maybe we should add a new style flag (wxMENU_OWNERDRAWN) to wxMenu
to support that. This should probably become a new ticket.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/11479#comment:6>

Reply all
Reply to author
Forward
0 new messages