Can't build "image" sample

[iko...@earthlink.net]

Hi, ALL,

igor@IgorsGentooOnNetwork ~/wxWidgets.current/buildGTKlaptop/samples/image $ make
/home/igor/wxWidgets.current/buildGTKlaptop/bk-deps i686-pc-linux-gnu-g++ -c -o image_image.o -D__WXGTK__ -I../../../samples/image -DWXUSINGDLL -I../../../samples/image/../../samples -Wall -Wundef -Wunused-parameter -Wno-ctor-dtor-privacy -Woverloaded-virtual -D_FILE_OFFSET_BITS=64 -I/home/igor/wxWidgets.current/buildGTKlaptop/lib/wx/include/gtk2-unicode-2.9 -I../../../include -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -pthread -DORBIT2=1 -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -DWX_PRECOMP -pthread -ggdb -pg -O0 -I/usr/include/libgnomeprintui-2.2 -I/usr/include/libgnomeprint-2.2 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/pango-1.0 -I/usr/include/gail-1.0 -I/usr/include/gtk-2.0 -I/usr/include/freetype2 -I/usr/include/atk-1.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/lib/gtk-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -fvisibility=hidden -fvisibility-inlines-hidden ../../../samples/image/image.cpp
../../../samples/image/image.cpp: In member function 'void MyImageFrame::OnSave(wxCommandEvent&)':
../../../samples/image/image.cpp:281: error: 'wxPNG_TYPE_COLOUR' was not declared in this scope
../../../samples/image/image.cpp:283: error: 'wxPNG_TYPE_GREY' was not declared in this scope
../../../samples/image/image.cpp:285: error: 'wxPNG_TYPE_GREY_RED' was not declared in this scope
../../../samples/image/image.cpp:306: error: 'wxIMAGE_OPTION_PNG_FORMAT' was not declared in this scope
../../../samples/image/image.cpp:307: error: 'wxIMAGE_OPTION_PNG_BITDEPTH' was not declared in this scope
../../../samples/image/image.cpp:339: error: 'wxIMAGE_OPTION_PNG_COMPRESSION_LEVEL' was not declared in this scope
../../../samples/image/image.cpp:340: error: 'wxIMAGE_OPTION_PNG_COMPRESSION_MEM_LEVEL' was not declared in this scope
../../../samples/image/image.cpp:341: error: 'wxIMAGE_OPTION_PNG_COMPRESSION_STRATEGY' was not declared in this scope
../../../samples/image/image.cpp:342: error: 'wxIMAGE_OPTION_PNG_FILTER' was not declared in this scope
../../../samples/image/image.cpp:343: error: 'wxIMAGE_OPTION_PNG_COMPRESSION_BUFFER_SIZE' was not declared in this scope
make: *** [image_image.o] Error 1

This is on the rev 62664 SVN TRUNK.

Thank you.

[Vadim Zeitlin]

Buildbot does build this sample without problems and the symbols are, of
course, defined so the only explanation I can see is that you turned off
PNG support in your build.

Did you?
VZ

[iko...@earthlink.net]

Vadim,

Yes, I did.
But it still should build the sample fine, since those symbols should be defined only
when PNG support is on, right?

All I need is xpm and bitmap support, but I can't build the sample to check some other
format.

Thank you.

>VZ

[Vadim Zeitlin]

On Tue, 24 Nov 2009 23:08:44 -0500 (EST) iko...@earthlink.net wrote:

> > Buildbot does build this sample without problems and the symbols are, of
> >course, defined so the only explanation I can see is that you turned off
> >PNG support in your build.
> >
> > Did you?
>
> Yes, I did.
> But it still should build the sample fine,

Yes. But it would have been nice of you to mention that you disabled PNG
support when reporting PNG-related errors instead of exercising my crystal
ball gazing skills again.

> since those symbols should be defined only
> when PNG support is on, right?

Adding "#if wxUSE_LIBPNG" around the parts of the sample using PNG stuff
should be pretty simple, please feel free to submit a patch doing it.

Thanks,
VZ