r72950 - trunk/Links

14 views
Skip to first unread message

svnco...@wowace.com

unread,
May 7, 2008, 5:54:42 AM5/7/08
to wowace-gar...@googlegroups.com
Author: jerry
Date: Wed May 7 05:54:38 2008
New Revision: 72950

Log:
Links: force load the Blizzard_CombatLog addon to correct a tainting bug. I'm unhappy with this solution.


Modified:
trunk/Links/Links.lua

Modified: trunk/Links/Links.lua
==============================================================================
--- trunk/Links/Links.lua (original)
+++ trunk/Links/Links.lua Wed May 7 05:54:38 2008
@@ -595,6 +595,22 @@
end
end

+--[[
+I need here to load Blizzard_CombatLog, for the following reason:
+
+Blizzard_CombatLog hooks SetItemRef in a similar manner than this addon :
+
+AddOns/Blizzard_CombatLog/Blizzard_CombatLog.lua:3520
+local oldSetItemRef = SetItemRef;
+
+if Links has replaced SetItemRef by its own version at this point, then the
+execution of the remainder of Blizzard_CombatLog.lua becomes tainted.
+This should not be a problem, but it ends up tainting UIFrameFade(), which cause issues.
+
+So I make sure the combatlog addon is loaded here.
+]]
+_G.CombatLog_LoadUI()
+
_G.SetItemRef = function (...)
if Links:IsEnabled() then
return Links:SetItemRef(...)

Reply all
Reply to author
Forward
0 new messages