bug report: -16px left overhang in outline nodes

[Dave Jones]

When I changed the background color to something other than white, I noticed a -16px margin-left hard-coded in all outline nodes.

http://worknotes.southernbread.org/bugs/3281220321PmByDj


DJ

[Dave Winer]

Thanks Dave -- that looks like it might be a loose end.

I'll have a look a little later this evening or tomorrow first thing.

Dave

[Dave Winer]

BTW, you can put <style> elements directly in your outline.

[Dave Winer]

Okay I took a closer look, and I can't move those styles and the script without breaking op.render.viewOutline. It's a fairly low-level routine, and those styles are like software. You really can't change them without (probably) also changing op.render.viewOutline code, which is a very carefully written routine that does some very powerful stuff. It's probably the 8th version of that code I've written, and it works just the way I want it to, except in this regard.

You're a lot more skilled in the CSS issues than I am. Those values were arrived at by fumbling around with some very part-time people on Scripting News, years back when I wanted to add expand and collapse to the site. I was assured that was standard CSS, but it always seemed weird to me to have elements that were displayed outside of the box of the object that contains them.

So I propose that you very slowly and carefully experiment on your own system with values in op.render.data.html.style, and see if you can improve it so it works the way you want, and keep the basic functionality that we have now. In fact the blue wedges stopped lining up properly at some point, probably when we went to Bootstrap 2.0. So the whole thing could use a careful review from someone such as yourself.

But it's only valuable if it's done carefully.

Dave

[Dave Jones]

Ok, I'll make a backup of op.render.data.html.style and carefully walk through it as you suggest and see what I can come up with.  Will take notes in the bug report.

For now I put a corrective <style> right before the closing </body> tag in the "main" template as a workaround.  That fixed my specific issue and I noted it in the bug report writeup.


DJ

[Dave Jones]

This is what I have come up with to address these two specific issues (the left overhang and the blue wedge alignment):

http://worknotes.southernbread.org/bugs/3291212821PmByDj

I can't see any breakage coming from this, and it sure does make the default alignment feel more sane.  Somebody correct me if I've missed something.

DJ

[Dave Winer]

Dave, I took a look with an eye toward releasing the changes, but
there was breakage.

http://worknotes.scripting.com/march2012/33112ByDw/notReleasingDaveJonesFixYet/

Dave

[Dave Jones]

Should the default be a zero clearance left margin?  That was my original fix, but as soon as I changed the background color it looked crammed without a margin.  Like this:

http://dropbox.southernbread.org/public2/fix-divoutlinebody16-ss3.jpg

I have the zero left clearance fix already written down.  I'll put it in a new fix note for you to review.

DJ

[Dave Jones]

Dave, would it be possible to get an extra class put on blank wedge img's?  Something like class="expandIcon wedgeblank"?

DJ

[Dave Winer]

I'm going to give you full control of all of it.

But I want to do it with a fresh start tomorrow.

Dave

[Dave Winer]

Here are the changes I made this morning.

http://worknotes.scripting.com/april2012/4112ByDw/movingOprenderStylesAndScripts/

DJ, you should now be able to take full control of the outline
rendering styles, without having to hack anything.

Please keep us posted on what you learn.

And see the note about adding a class to blank icons. Wasn't able to
get it in with all these other changes. Too risky.

Dave

On Mar 31, 5:27 pm, Dave Winer <dave.wi...@gmail.com> wrote:
> I'm going to give you full control of all of it.
>
> But I want to do it with a fresh start tomorrow.
>
> Dave
>
> On Sat, Mar 31, 2012 at 5:07 PM, Dave Jones <sec...@gmail.com> wrote:
> > Dave, would it be possible to get an extra class put on blank wedge
> > img's?  Something like class="expandIcon wedgeblank"?
>
> > DJ
>
> > On Saturday, March 31, 2012 9:13:40 AM UTC-5, Dave Winer wrote:
>
> >> Dave, I took a look with an eye toward releasing the changes, but
> >> there was breakage.
>

> >>http://worknotes.scripting.**com/march2012/33112ByDw/**
> >> notReleasingDaveJonesFixYet/<http://worknotes.scripting.com/march2012/33112ByDw/notReleasingDaveJo...>

>
> >> Dave
>
> >> On Mar 29, 4:16 pm, Dave Jones <sec...@gmail.com> wrote:
> >> > This is what I have come up with to address these two specific issues
> >> (the
> >> > left overhang and the blue wedge alignment):
>

> >> >http://worknotes.**southernbread.org/bugs/**3291212821PmByDj<http://worknotes.southernbread.org/bugs/3291212821PmByDj>

[Dave Jones]

Awesome!  This is perfect.

I'm going to start messing with it in a bit and will take notes in a new worknote.


DJ